Implement TC-SC-3.6 as a Python test #21719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
robszewczyk
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #21719: Size comparison from 34a8570 to 79c05c2 Increases (5 builds for bl602, cc13x2_26x2, k32w, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tehampson
approved these changes
Aug 8, 2022
mrjerryjohns
previously requested changes
Aug 8, 2022
mrjerryjohns
reviewed
Aug 9, 2022
msandstedt
approved these changes
Aug 9, 2022
mrjerryjohns
approved these changes
Aug 9, 2022
src/controller/python/chip/utils/CommissioningBuildingBlocks.py
Outdated
Show resolved
Hide resolved
mrjerryjohns
reviewed
Aug 9, 2022
mrjerryjohns
reviewed
Aug 9, 2022
- Test TC-SC-3.6 was not feasible with chip-tool and manual intervention due to the complexity of validating that the correct sessions were established, establishing all of them, and ensuring all subscriptions fire as intended. This PR: - Adds a version of TC-SC-3.6 in Python - Updates the Python code with minor improvements needed during the development of the test - **Touches no C++ SDK code** Testing done: - Ran the test as it could be done by an end-user, passed on Linux and on ESP32 (after some changes to resources in the examples, not included in this PR) To run: - Build all-clusters app Linux: - `scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false` - In a shell, run: `clear && rm -f kvs1 && out/debug/standalone/chip-all-clusters-app --discriminator 2118 --KVS kvs1` - Build the Python environment, activate it, then run the test - `./scripts/build_python.sh -m platform -i separate` - `. ./out/python_env/bin/activate` - Run the test: `rm -f admin_storage.json && python src/python_testing/TC_SC_3_6.py -m on-network -d 2118 -p 20202021`
woody-apple
force-pushed
the
trials-fill-table2
branch
from
0ab0bc6 to
0de5681
Compare
|
PR #21719: Size comparison from 397d642 to 0de5681 Increases (1 build for cc13x2_26x2)
Decreases (5 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Implement TC-SC-3.6 as a Python test - Test TC-SC-3.6 was not feasible with chip-tool and manual intervention due to the complexity of validating that the correct sessions were established, establishing all of them, and ensuring all subscriptions fire as intended. This PR: - Adds a version of TC-SC-3.6 in Python - Updates the Python code with minor improvements needed during the development of the test - **Touches no C++ SDK code** Testing done: - Ran the test as it could be done by an end-user, passed on Linux and on ESP32 (after some changes to resources in the examples, not included in this PR) To run: - Build all-clusters app Linux: - `scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false` - In a shell, run: `clear && rm -f kvs1 && out/debug/standalone/chip-all-clusters-app --discriminator 2118 --KVS kvs1` - Build the Python environment, activate it, then run the test - `./scripts/build_python.sh -m platform -i separate` - `. ./out/python_env/bin/activate` - Run the test: `rm -f admin_storage.json && python src/python_testing/TC_SC_3_6.py -m on-network -d 2118 -p 20202021` * Apply review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
intervention due to the complexity of validating that the
correct sessions were established, establishing all of them,
and ensuring all subscriptions fire as intended.
Issue #21009
Change overview
the development of the test
Testing
and on ESP32 (after some changes to resources in the examples, not
included in this PR)
To run:
scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=falseclear && rm -f kvs1 && out/debug/standalone/chip-all-clusters-app --discriminator 2118 --KVS kvs1./scripts/build_python.sh -m platform -i separate. ./out/python_env/bin/activaterm -f admin_storage.json && python src/python_testing/TC_SC_3_6.py -m on-network -d 2118 -p 20202021