Matter zap cleanup #21713
Merged
Matter zap cleanup #21713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecimovic
requested review from
andy31415,
woody-apple,
bzbarsky-apple and
vivien-apple
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
rgoliver and
robszewczyk
krypton36
reviewed
Aug 12, 2022
tecimovic
force-pushed
the
matter-zap-cleanup
branch
from
47a8e60 to
51279c7
Compare
|
PR #21713: Size comparison from 0888818 to 51279c7 Decreases (1 build for bl602)
Full report (12 builds for bl602, cyw30739, linux, mbed, nrfconnect, telink)
|
|
PR #21713: Size comparison from 0888818 to 71f38b2 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
@jmartinez-silabs : It's not. I'll remove that change from the PR. Well, I have to rebase the whole thing anyway, so I'll just rebase that change out of existence. @jmartinez-silabs : taken care of. The new rebased branch doesn't have a change to silabe/matter_support. |
0. Use the common helper aliases in the template json files. 1. Update templates.json with correct reference. 2. Update another template. 3. Add resources to the templates files, so that helpers can access the yaml stuff. 4. Fix wrong paths in templates.json
tecimovic
force-pushed
the
matter-zap-cleanup
branch
from
c83c5f6 to
f9ae43d
Compare
|
PR #21713: Size comparison from 1c613ad to f9ae43d Increases (2 builds for bl602, cyw30739)
Decreases (1 build for telink)
Full report (18 builds for bl602, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #21713: Size comparison from 1c613ad to 42356ae Increases (4 builds for bl602, cyw30739, telink)
Full report (21 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
|
PR #21713: Size comparison from 1c613ad to 1c93a9b Increases (5 builds for bl602, cc13x2_26x2, cyw30739, telink)
Decreases (1 build for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Aug 15, 2022
krypton36
approved these changes
Aug 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Add the sdk.json for zap regeneration. * Rework the helper infrastructure to support aliases and categories. 0. Use the common helper aliases in the template json files. 1. Update templates.json with correct reference. 2. Update another template. 3. Add resources to the templates files, so that helpers can access the yaml stuff. 4. Fix wrong paths in templates.json * Use ZAP_PATH to run zap from other location than third_party/zap. * Convert the tests to JSON files. * Remove all the duplicated and unneeded js code. * Keep tests in sync with the changes on master. * Update zap submodule. * Add the updates from the mainline. * Restyled by whitespace * Restyled by prettier-json * Remove a manual test. Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ZAP source dependency was detrimental to end-customer experience, because every Matter end user had to set themselves up as a ZAP developer: right versions of node, right versions of some shared libraries, etc. The binary build of zap could not be used, because the JS extensions on the Matter SDK reached back into the zap repo looking for source code, which does not exist in a binary build.
Change overview
Testing
Follow-up
This work opens up the ability to run zap differently. So there will be follow-up work afterwards: