-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Add On/Off Light Device Type to ota-requestor-app #21695
Merged
carol-apple
merged 2 commits into
project-chip:master
from
carol-apple:ota_requestor_lighting_device_type
Aug 8, 2022
Merged
[OTA] Add On/Off Light Device Type to ota-requestor-app #21695
carol-apple
merged 2 commits into
project-chip:master
from
carol-apple:ota_requestor_lighting_device_type
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
August 5, 2022 20:10
pullapprove
bot
requested review from
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 5, 2022 20:10
PR #21695: Size comparison from dc85dad to 880145c Increases above 0.2%:
Increases (5 builds for bl602, cyw30739, linux, telink)
Decreases (2 builds for esp32, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2022
examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter
Show resolved
Hide resolved
PR #21695: Size comparison from dc85dad to 3a40b6a Increases above 0.2%:
Increases (8 builds for bl602, cyw30739, esp32, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
harsha-rajendran
approved these changes
Aug 8, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The original purpose of ota-requestor-app is to create a sample app that contains the OTA Requestor Server cluster to be used for verifying OTA functionality. However, in reality, an accessory with only the OTA Requestor Server cluster and no other clusters does not make sense.
Change overview
Add an On/Off Light Device Type to make ota-requestor-app a more realistic accessory
Testing
Tree compiles and app can be commissioned