Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some Thread Network Diagnostics XML/ZAP issues. #21692

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fix some Thread Network Diagnostics XML/ZAP issues. #21692

merged 1 commit into from
Aug 8, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

  • Rename "ChannelMask" to "ChannelPage0Mask" to align with spec.
  • Rename "delay" to "Delay" to align with spec.
  • Add SecurityPolicy and OperationalDatasetComponents to the "must be external"
    list, since they are struct-typed.

Problem

Not aligned with spec, has footgun attributes that require manual External setting in ZAP files.

Change overview

Fix that.

@bzbarsky-apple
Fix some Thread Network Diagnostics XML/ZAP issues.
dedd67e 
* Rename "ChannelMask" to "ChannelPage0Mask" to align with spec.
* Rename "delay" to "Delay" to align with spec.
* Add SecurityPolicy and OperationalDatasetComponents to the "must be external"
  list, since they are struct-typed.
@bzbarsky-apple bzbarsky-apple force-pushed the thread-diagnostics-fix branch from b9a9111 to dedd67e Compare August 5, 2022 19:15
@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

PR #21692: Size comparison from b6859d7 to dedd67e

Increases (6 builds for bl602, cc13x2_26x2, cyw30739, linux, telink)
platform target config section b6859d7 dedd67e change % change
bl602 lighting-app bl602+rpc .text 1079376 1079380 4 0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 159584 159592 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584382 584390 8 0.0
.app_xip_area 461184 461192 8 0.0
lock cyw930739m2evb_01 (read/write) 590302 590310 8 0.0
.app_xip_area 462320 462328 8 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859340 16 0.0
.rodata 464508 464524 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805844 8 0.0
text 569642 569646 4 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section b6859d7 dedd67e change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 682791 682783 -8 -0.0
.text 593060 593052 -8 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b6859d7 dedd67e change % change
bl602 lighting-app bl602 (read/write) 1379634 1379634 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047876 1047876 0 0.0
bl602+rpc (read/write) 1424890 1424890 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079376 1079380 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670775 0 0.0
(read/write) 180608 180608 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 581988 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636311 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558260 0 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672619 0 0.0
(read/write) 168948 168948 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595728 0 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655107 0 0.0
(read/write) 182148 182148 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101307 101307 0 0.0
.text 553320 553320 0 0.0
pump-app LP_CC2652R7 (read only) 682791 682783 -8 -0.0
(read/write) 159584 159592 8 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 593060 593052 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667255 0 0.0
(read/write) 175256 175256 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581984 581984 0 0.0
shell LP_CC2652R7 (read only) 663450 663450 0 0.0
(read/write) 183452 183452 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577716 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584382 584390 8 0.0
.app_xip_area 461184 461192 8 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590302 590310 8 0.0
.app_xip_area 462320 462328 8 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589378 0 0.0
.app_xip_area 466996 466996 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096004 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961068 961068 0 0.0
BRD4161A+rpc (read/write) 1150300 1150300 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998468 998468 0 0.0
BRD4161A+rs911x (read/write) 985284 985284 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821024 821024 0 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135960 0 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989052 989052 0 0.0
window-app BRD4161A (read/write) 1087736 1087736 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951328 951328 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025832 1025832 0 0.0
(read/write) 1487226 1487226 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216856 216856 0 0.0
.flash.text 1025832 1025832 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079115 1079115 0 0.0
(read/write) 489232 489232 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247252 247252 0 0.0
.flash.text 1073731 1073731 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643340 643340 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568856 568856 0 0.0
lock k32w0+release (read/write) 700676 700676 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625712 625712 0 0.0
linux all-clusters-app debug (read only) 3022745 3022745 0 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272779 272779 0 0.0
.text 2571106 2571106 0 0.0
all-clusters-minimal-app debug (read only) 2864609 2864609 0 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272875 272875 0 0.0
.text 2415506 2415506 0 0.0
bridge-app debug+rpc (read only) 2363881 2363881 0 0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202024 202024 0 0.0
.text 1999378 1999378 0 0.0
chip-tool debug (read only) 10444721 10444721 0 0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 533141 533141 0 0.0
.text 8415220 8415220 0 0.0
chip-tool-ipv6only arm64 (read only) 9859324 9859340 16 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464508 464524 16 0.0
.text 7767524 7767524 0 0.0
lighting-app debug+rpc (read only) 2587497 2587497 0 0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218672 218672 0 0.0
.text 2198258 2198258 0 0.0
lock-app debug (read only) 2571745 2571745 0 0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235664 235664 0 0.0
.text 2169570 2169570 0 0.0
ota-provider-app debug (read only) 2349297 2349297 0 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207832 207832 0 0.0
.text 1978114 1978114 0 0.0
ota-requestor-app debug (read only) 2473337 2473337 0 0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212384 212384 0 0.0
.text 2088962 2088962 0 0.0
shell debug (read only) 2593345 2593345 0 0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233266 233266 0 0.0
.text 2201874 2201874 0 0.0
thermostat-no-ble arm64 (read only) 2349676 2349676 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139620 139620 0 0.0
.text 1972544 1972544 0 0.0
tv-app debug (read only) 3167153 3167153 0 0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257544 257544 0 0.0
.text 2719842 2719842 0 0.0
tv-casting-app debug (read only) 5402513 5402513 0 0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340465 340465 0 0.0
.text 4794082 4794082 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452392 2452392 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415036 1415036 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177679 1177679 0 0.0
bss 143222 143222 0 0.0
rodata 142704 142704 0 0.0
text 812912 812912 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157735 1157735 0 0.0
bss 142460 142460 0 0.0
rodata 134400 134400 0 0.0
text 802064 802064 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690756 1690756 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530552 1530552 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634948 1634948 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475464 1475464 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553668 1553668 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402504 1402504 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1590956 1590956 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435296 1435296 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805844 8 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569642 569646 4 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827644 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587618 587618 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 6056898 into project-chip:master Aug 8, 2022
@bzbarsky-apple bzbarsky-apple deleted the thread-diagnostics-fix branch August 8, 2022 20:34
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Fix some Thread Network Diagnostics XML/ZAP issues. (project-chip#21692)
35dc058 
* Rename "ChannelMask" to "ChannelPage0Mask" to align with spec.
* Rename "delay" to "Delay" to align with spec.
* Add SecurityPolicy and OperationalDatasetComponents to the "must be external"
  list, since they are struct-typed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples linux platform review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @tcarmelveilleux @jmartinez-silabs