-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chip-tool: add more flexibility in PAA root folder selection #21691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Fixes project-chip#21681 chip-tool: add more flexibility in PAA root folder selection #### Change overview If `--paa-trust-store-path` is not given, and the environment variable `CHIPTOOL_PAA_TRUST_STORE_PATH` exists, use its value. #### Testing Manual confirmation of the logged `mPaaTrustStorePath.Value()`.
PR #21691: Size comparison from b6859d7 to ec195d8 Increases (5 builds for bl602, cyw30739, linux)
Decreases (2 builds for esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #21691: Size comparison from b6859d7 to ba3539e Increases (5 builds for bl602, cyw30739, linux)
Decreases (3 builds for efr32, esp32, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2022
tcarmelveilleux
approved these changes
Aug 8, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…-chip#21691) * chip-tool: add more flexibility in PAA root folder selection #### Problem Fixes project-chip#21681 chip-tool: add more flexibility in PAA root folder selection #### Change overview If `--paa-trust-store-path` is not given, and the environment variable `CHIPTOOL_PAA_TRUST_STORE_PATH` exists, use its value. #### Testing Manual confirmation of the logged `mPaaTrustStorePath.Value()`. * restyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #21681 chip-tool: add more flexibility in PAA root folder selection
Change overview
If
--paa-trust-store-path
is not given, and the environment variableCHIPTOOL_PAA_TRUST_STORE_PATH
exists, use its value.Testing
Manual confirmation of the logged
mPaaTrustStorePath.Value()
.