Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Remove test mode from examples #21676

Merged
merged 1 commit into from
Aug 9, 2022
Merged

[nrfconnect] Remove test mode from examples #21676

merged 1 commit into from
Aug 9, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Test mode is a leftover from very early phase of the project when we had the rendezvous bypass mode.

Change overview

Remove the obsolete code from nRF Connect examples.

Testing

N/A (code removal)

@Damian-Nordic
[nrfconnect] Remove test mode from examples
e7ed16a 
It is a leftover from very early phase of the project when
we had the redezvous bypass mode.

Signed-off-by: Damian Krolik <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

PR #21676: Size comparison from 753415d to e7ed16a

Increases (4 builds for cyw30739, telink)
platform target config section 753415d e7ed16a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 584834 584842 8 0.0
.app_xip_area 461636 461644 8 0.0
lock cyw930739m2evb_01 (read/write) 590762 590770 8 0.0
.app_xip_area 462780 462788 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805820 805828 8 0.0
text 569628 569632 4 0.0
lighting-app tlsr9518adk80d (read/write) 827492 827500 8 0.0
text 587468 587472 4 0.0
Decreases (9 builds for esp32, nrfconnect)
platform target config section 753415d e7ed16a change % change
esp32 all-clusters-app c3devkit (read only) 1025656 1025652 -4 -0.0
.flash.text 1025656 1025652 -4 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1168799 1167527 -1272 -0.1
rodata 124176 123992 -184 -0.1
text 820908 819812 -1096 -0.1
nrf52840dk_nrf52840+rpc (read/write) 1138359 1137051 -1308 -0.1
rodata 115640 115468 -172 -0.1
text 798172 797048 -1124 -0.1
nrf52840dongle_nrf52840 (read/write) 1075815 1074523 -1292 -0.1
rodata 93320 93148 -172 -0.2
text 749400 748276 -1124 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 1072302 1071018 -1284 -0.1
rodata 116588 116408 -180 -0.2
text 733472 732372 -1100 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 1128591 1127303 -1288 -0.1
rodata 142160 141976 -184 -0.1
text 771912 770812 -1100 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 1032362 1031078 -1284 -0.1
rodata 134632 134452 -180 -0.1
text 684532 683428 -1104 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 1079835 1078547 -1288 -0.1
rodata 117388 117204 -184 -0.2
text 748980 747880 -1100 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 1066475 1065187 -1288 -0.1
rodata 113868 113684 -184 -0.2
text 739276 738172 -1104 -0.1
Full report (51 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 753415d e7ed16a change % change
bl602 lighting-app bl602 (read/write) 1380298 1380298 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048400 1048400 0 0.0
bl602+rpc (read/write) 1425546 1425546 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079900 1079900 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670647 670647 0 0.0
(read/write) 180736 180736 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88479 88479 0 0.0
.text 581852 581852 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636159 636159 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558108 558108 0 0.0
lock-ftd LP_CC2652R7 (read only) 673123 673123 0 0.0
(read/write) 168444 168444 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76547 76547 0 0.0
.text 596096 596096 0 0.0
lock-mtd LP_CC2652R7 (read only) 655595 655595 0 0.0
(read/write) 181660 181660 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101435 101435 0 0.0
.text 553680 553680 0 0.0
pump-app LP_CC2652R7 (read only) 682639 682639 0 0.0
(read/write) 159736 159736 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 592908 592908 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667103 667103 0 0.0
(read/write) 175408 175408 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581832 581832 0 0.0
shell LP_CC2652R7 (read only) 663314 663314 0 0.0
(read/write) 183588 183588 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85426 85426 0 0.0
.text 577572 577572 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584834 584842 8 0.0
.app_xip_area 461636 461644 8 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590762 590770 8 0.0
.app_xip_area 462780 462788 8 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589882 589882 0 0.0
.app_xip_area 467500 467500 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096572 1096572 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961636 961636 0 0.0
BRD4161A+rpc (read/write) 1150868 1150868 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 999036 999036 0 0.0
BRD4161A+rs911x (read/write) 985860 985860 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821600 821600 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136456 1136456 0 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989548 989548 0 0.0
window-app BRD4161A (read/write) 1088312 1088312 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951904 951904 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025656 1025652 -4 -0.0
(read/write) 1487234 1487234 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216864 0 0.0
.flash.text 1025656 1025652 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079027 1079027 0 0.0
(read/write) 489240 489240 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247260 0 0.0
.flash.text 1073643 1073643 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644460 644460 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569976 569976 0 0.0
lock k32w0+release (read/write) 701796 701796 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626832 626832 0 0.0
linux all-clusters-app debug (read only) 3021713 3021713 0 0.0
(read/write) 155688 155688 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85352 85352 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272491 272491 0 0.0
.text 2570338 2570338 0 0.0
all-clusters-minimal-app debug (read only) 2863561 2863561 0 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272555 272555 0 0.0
.text 2414754 2414754 0 0.0
bridge-app debug+rpc (read only) 2369433 2369433 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203336 203336 0 0.0
.text 2003090 2003090 0 0.0
chip-tool debug (read only) 10440169 10440169 0 0.0
(read/write) 646432 646432 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611784 611784 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 532373 532373 0 0.0
.text 8411412 8411412 0 0.0
chip-tool-ipv6only arm64 (read only) 9856140 9856140 0 0.0
(read/write) 694097 694097 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639336 639336 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464460 464460 0 0.0
.text 7764452 7764452 0 0.0
lighting-app debug+rpc (read only) 2592017 2592017 0 0.0
(read/write) 130200 130200 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72440 72440 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 219088 219088 0 0.0
.text 2201858 2201858 0 0.0
lock-app debug (read only) 2576281 2576281 0 0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 236080 236080 0 0.0
.text 2173186 2173186 0 0.0
ota-provider-app debug (read only) 2354881 2354881 0 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209176 209176 0 0.0
.text 1981826 1981826 0 0.0
ota-requestor-app debug (read only) 2475425 2475425 0 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212672 212672 0 0.0
.text 2090258 2090258 0 0.0
shell debug (read only) 2592553 2592553 0 0.0
(read/write) 141872 141872 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233042 233042 0 0.0
.text 2201282 2201282 0 0.0
thermostat-no-ble arm64 (read only) 2349068 2349068 0 0.0
(read/write) 141617 141617 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5024 5024 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1972064 1972064 0 0.0
tv-app debug (read only) 3164265 3164265 0 0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79088 79088 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257000 257000 0 0.0
.text 2717474 2717474 0 0.0
tv-casting-app debug (read only) 5400985 5400985 0 0.0
(read/write) 158824 158824 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98584 98584 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340433 340433 0 0.0
.text 4792562 4792562 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453688 2453688 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1416332 1416332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177519 1177519 0 0.0
bss 143222 143222 0 0.0
rodata 142704 142704 0 0.0
text 812744 812744 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157575 1157575 0 0.0
bss 142460 142460 0 0.0
rodata 134400 134400 0 0.0
text 801896 801896 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1168799 1167527 -1272 -0.1
bss 144799 144799 0 0.0
rodata 124176 123992 -184 -0.1
text 820908 819812 -1096 -0.1
nrf52840dk_nrf52840+rpc (read/write) 1138359 1137051 -1308 -0.1
bss 145212 145212 0 0.0
rodata 115640 115468 -172 -0.1
text 798172 797048 -1124 -0.1
nrf52840dongle_nrf52840 (read/write) 1075815 1074523 -1292 -0.1
bss 152014 152014 0 0.0
rodata 93320 93148 -172 -0.2
text 749400 748276 -1124 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 1072302 1071018 -1284 -0.1
bss 141170 141170 0 0.0
rodata 116588 116408 -180 -0.2
text 733472 732372 -1100 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 1128591 1127303 -1288 -0.1
bss 135755 135755 0 0.0
rodata 142160 141976 -184 -0.1
text 771912 770812 -1100 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 1032362 1031078 -1284 -0.1
bss 132158 132158 0 0.0
rodata 134632 134452 -180 -0.1
text 684532 683428 -1104 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 1079835 1078547 -1288 -0.1
bss 134654 134654 0 0.0
rodata 117388 117204 -184 -0.2
text 748980 747880 -1100 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 1066475 1065187 -1288 -0.1
bss 134449 134449 0 0.0
rodata 113868 113684 -184 -0.2
text 739276 738172 -1104 -0.1
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690580 1690580 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530376 1530376 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634772 1634772 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475288 1475288 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1555060 1555060 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403896 1403896 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592348 1592348 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436688 1436688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805820 805828 8 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569628 569632 4 0.0
lighting-app tlsr9518adk80d (read/write) 827492 827500 8 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587468 587472 4 0.0

@woody-apple woody-apple enabled auto-merge (squash) August 9, 2022 14:51
@woody-apple woody-apple merged commit a30d766 into project-chip:master Aug 9, 2022
@Damian-Nordic Damian-Nordic mentioned this pull request Aug 11, 2022
Merged
Damian-Nordic pushed a commit to Damian-Nordic/connectedhomeip that referenced this pull request Sep 1, 2022
@markaj-nordic @Damian-Nordic
[nrf fromtree] Remove test mode from examples (project-chip#21676)
238a18d 
It is a leftover from very early phase of the project when
we had the redezvous bypass mode.

 Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic pushed a commit to Damian-Nordic/connectedhomeip that referenced this pull request Sep 1, 2022
@kkasperczyk-no
Revert "[nrf fromtree] Remove test mode from examples (project-chip#2…
9f7d6f5 
…1676)"

This reverts commit 238a18d.
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@Damian-Nordic @isiu-apple
[nrfconnect] Remove test mode from examples (project-chip#21676)
1e8ce94 
It is a leftover from very early phase of the project when
we had the redezvous bypass mode.

Signed-off-by: Damian Krolik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Damian-Nordic @bzbarsky-apple @woody-apple