Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WiFi Network Diagnostics cluster to align with the spec changes #21653

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Update WiFi Network Diagnostics cluster to align with the spec changes #21653

merged 2 commits into from
Aug 5, 2022

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Aug 5, 2022 •
edited
Loading

Problem

What is being fixed? Examples:

Change overview

Update WiFi Network Diagnostics cluster to align with the spec changes

Testing

How was this tested? (at least one bullet point required)

  • verify we still able to read out those attributes with this change
./chip-tool wifinetworkdiagnostics read packet-unicast-rx-count 12344321 0

[1659661799.599226][103296:103301] CHIP:EM: Rxd Ack; Removing MessageCounter:3593757 from Retrans Table on exchange 8670i
[1659661799.599264][103296:103301] CHIP:EM: Removed CHIP MessageCounter:3593757 from RetransTable on exchange 8670i
[1659661799.599364][103296:103301] CHIP:DMG: ReportDataMessage =
[1659661799.599404][103296:103301] CHIP:DMG: {
[1659661799.599428][103296:103301] CHIP:DMG: 	AttributeReportIBs =
[1659661799.599471][103296:103301] CHIP:DMG: 	[
[1659661799.599501][103296:103301] CHIP:DMG: 		AttributeReportIB =
[1659661799.599550][103296:103301] CHIP:DMG: 		{
[1659661799.599585][103296:103301] CHIP:DMG: 			AttributeDataIB =
[1659661799.599622][103296:103301] CHIP:DMG: 			{
[1659661799.599657][103296:103301] CHIP:DMG: 				DataVersion = 0xb39b0fc2,
[1659661799.599687][103296:103301] CHIP:DMG: 				AttributePathIB =
[1659661799.599718][103296:103301] CHIP:DMG: 				{
[1659661799.599747][103296:103301] CHIP:DMG: 					Endpoint = 0x0,
[1659661799.599782][103296:103301] CHIP:DMG: 					Cluster = 0x36,
[1659661799.599812][103296:103301] CHIP:DMG: 					Attribute = 0x0000_0009,
[1659661799.599846][103296:103301] CHIP:DMG: 				}
[1659661799.599880][103296:103301] CHIP:DMG: 					
[1659661799.599912][103296:103301] CHIP:DMG: 				Data = 313, 
[1659661799.599938][103296:103301] CHIP:DMG: 			},
[1659661799.599973][103296:103301] CHIP:DMG: 			
[1659661799.599996][103296:103301] CHIP:DMG: 		},
[1659661799.600030][103296:103301] CHIP:DMG: 		
[1659661799.600052][103296:103301] CHIP:DMG: 	],
[1659661799.600087][103296:103301] CHIP:DMG: 	
[1659661799.600111][103296:103301] CHIP:DMG: 	SuppressResponse = true, 
[1659661799.600137][103296:103301] CHIP:DMG: 	InteractionModelRevision = 1
[1659661799.600158][103296:103301] CHIP:DMG: }
[1659661799.600369][103296:103301] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0036 Attribute 0x0000_0009 DataVersion: 3013283778
[1659661799.600454][103296:103301] CHIP:TOO:   PacketUnicastRxCount: 313
[1659661799.600566][103296:103301] CHIP:EM: Sending Standalone Ack for MessageCounter:14514825 on exchange 8670i

@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

PR #21653: Size comparison from 8c555ca to 80011b9

Increases (39 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8c555ca 80011b9 change % change
bl602 lighting-app bl602 (read/write) 1380210 1380298 88 0.0
.text 1048312 1048400 88 0.0
bl602+rpc (read/write) 1425458 1425546 88 0.0
.text 1079812 1079900 88 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670551 670647 96 0.0
.text 581756 581852 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636063 636159 96 0.0
.text 558012 558108 96 0.0
lock-ftd LP_CC2652R7 (read only) 673027 673123 96 0.0
.text 596000 596096 96 0.0
lock-mtd LP_CC2652R7 (read only) 655459 655595 136 0.0
.text 553544 553680 136 0.0
pump-app LP_CC2652R7 (read/write) 159736 159744 8 0.0
shell LP_CC2652R7 (read only) 663218 663314 96 0.0
.text 577476 577572 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584738 584842 104 0.0
.app_xip_area 461540 461644 104 0.0
lock cyw930739m2evb_01 (read/write) 590674 590770 96 0.0
.app_xip_area 462692 462788 96 0.0
efr32 lighting-app BRD4161A (read/write) 1096476 1096572 96 0.0
.text 961540 961636 96 0.0
BRD4161A+rpc (read/write) 1150756 1150868 112 0.0
.text 998924 999036 112 0.0
BRD4161A+rs911x (read/write) 985764 985860 96 0.0
.text 821504 821600 96 0.0
lock-app BRD4161A+wf200 (read/write) 1136328 1136456 128 0.0
.text 989420 989548 128 0.0
window-app BRD4161A (read/write) 1088216 1088312 96 0.0
.text 951808 951904 96 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025652 168 0.0
.flash.text 1025484 1025652 168 0.0
m5stack (read only) 1078931 1079027 96 0.0
.flash.text 1073547 1073643 96 0.0
k32w light k32w0+release (read/write) 644316 644460 144 0.0
.text 569832 569976 144 0.0
lock k32w0+release (read/write) 701652 701796 144 0.0
.text 626688 626832 144 0.0
linux all-clusters-app debug (read only) 3020241 3021713 1472 0.0
.text 2568866 2570338 1472 0.1
all-clusters-minimal-app debug (read only) 2862073 2863561 1488 0.1
.text 2413266 2414754 1488 0.1
bridge-app debug+rpc (read only) 2367961 2369433 1472 0.1
.text 2001618 2003090 1472 0.1
chip-tool debug (read only) 10436417 10437201 784 0.0
.text 8408228 8409012 784 0.0
chip-tool-ipv6only arm64 (read only) 9845100 9846732 1632 0.0
.text 7753972 7755604 1632 0.0
lighting-app debug+rpc (read only) 2590545 2592017 1472 0.1
.text 2200386 2201858 1472 0.1
lock-app debug (read only) 2574793 2576281 1488 0.1
.text 2171698 2173186 1488 0.1
shell debug (read only) 2591065 2592553 1488 0.1
.text 2199794 2201282 1488 0.1
thermostat-no-ble arm64 (read only) 2347804 2349068 1264 0.1
.text 1970800 1972064 1264 0.1
tv-app debug (read only) 3162793 3164265 1472 0.0
.text 2716002 2717474 1472 0.1
tv-casting-app debug (read only) 5400665 5402313 1648 0.0
.text 4792818 4794466 1648 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2453560 2453688 128 0.0
.text 1416204 1416332 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177519 128 0.0
text 812612 812744 132 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157447 1157575 128 0.0
text 801764 801896 132 0.0
p6 all-clusters-app default (read/write) 1690484 1690580 96 0.0
.text 1530280 1530376 96 0.0
all-clusters-minimal-app default (read/write) 1634692 1634772 80 0.0
.text 1475208 1475288 80 0.0
light-app default (read/write) 1554980 1555060 80 0.0
.text 1403816 1403896 80 0.0
lock-app default (read/write) 1592252 1592348 96 0.0
.text 1436592 1436688 96 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805660 805828 168 0.0
text 569462 569630 168 0.0
lighting-app tlsr9518adk80d (read/write) 827332 827500 168 0.0
text 587302 587470 168 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 8c555ca 80011b9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180832 180736 -96 -0.1
lock-ftd LP_CC2652R7 (read/write) 168540 168444 -96 -0.1
lock-mtd LP_CC2652R7 (read/write) 181796 181660 -136 -0.1
pump-app LP_CC2652R7 (read only) 682639 682631 -8 -0.0
.text 592908 592900 -8 -0.0
shell LP_CC2652R7 (read/write) 183684 183588 -96 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8c555ca 80011b9 change % change
bl602 lighting-app bl602 (read/write) 1380210 1380298 88 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048312 1048400 88 0.0
bl602+rpc (read/write) 1425458 1425546 88 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079812 1079900 88 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670551 670647 96 0.0
(read/write) 180832 180736 -96 -0.1
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88479 88479 0 0.0
.text 581756 581852 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636063 636159 96 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558012 558108 96 0.0
lock-ftd LP_CC2652R7 (read only) 673027 673123 96 0.0
(read/write) 168540 168444 -96 -0.1
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76547 76547 0 0.0
.text 596000 596096 96 0.0
lock-mtd LP_CC2652R7 (read only) 655459 655595 136 0.0
(read/write) 181796 181660 -136 -0.1
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101435 101435 0 0.0
.text 553544 553680 136 0.0
pump-app LP_CC2652R7 (read only) 682639 682631 -8 -0.0
(read/write) 159736 159744 8 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 592908 592900 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 667103 667103 0 0.0
(read/write) 175408 175408 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581832 581832 0 0.0
shell LP_CC2652R7 (read only) 663218 663314 96 0.0
(read/write) 183684 183588 -96 -0.1
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85426 85426 0 0.0
.text 577476 577572 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584738 584842 104 0.0
.app_xip_area 461540 461644 104 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590674 590770 96 0.0
.app_xip_area 462692 462788 96 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589882 589882 0 0.0
.app_xip_area 467500 467500 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096476 1096572 96 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961540 961636 96 0.0
BRD4161A+rpc (read/write) 1150756 1150868 112 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998924 999036 112 0.0
BRD4161A+rs911x (read/write) 985764 985860 96 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821504 821600 96 0.0
lock-app BRD4161A+wf200 (read/write) 1136328 1136456 128 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989420 989548 128 0.0
window-app BRD4161A (read/write) 1088216 1088312 96 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951808 951904 96 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025652 168 0.0
(read/write) 1487234 1487234 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216864 0 0.0
.flash.text 1025484 1025652 168 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078931 1079027 96 0.0
(read/write) 489240 489240 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247260 0 0.0
.flash.text 1073547 1073643 96 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644316 644460 144 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569832 569976 144 0.0
lock k32w0+release (read/write) 701652 701796 144 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626688 626832 144 0.0
linux all-clusters-app debug (read only) 3020241 3021713 1472 0.0
(read/write) 155688 155688 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85352 85352 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272491 272491 0 0.0
.text 2568866 2570338 1472 0.1
all-clusters-minimal-app debug (read only) 2862073 2863561 1488 0.1
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272555 272555 0 0.0
.text 2413266 2414754 1488 0.1
bridge-app debug+rpc (read only) 2367961 2369433 1472 0.1
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203336 203336 0 0.0
.text 2001618 2003090 1472 0.1
chip-tool debug (read only) 10436417 10437201 784 0.0
(read/write) 646368 646368 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 532021 532021 0 0.0
.text 8408228 8409012 784 0.0
chip-tool-ipv6only arm64 (read only) 9845100 9846732 1632 0.0
(read/write) 694033 694033 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464124 464124 0 0.0
.text 7753972 7755604 1632 0.0
lighting-app debug+rpc (read only) 2590545 2592017 1472 0.1
(read/write) 130200 130200 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72440 72440 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 219088 219088 0 0.0
.text 2200386 2201858 1472 0.1
lock-app debug (read only) 2574793 2576281 1488 0.1
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 236080 236080 0 0.0
.text 2171698 2173186 1488 0.1
ota-provider-app debug (read only) 2354881 2354881 0 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209176 209176 0 0.0
.text 1981826 1981826 0 0.0
ota-requestor-app debug (read only) 2475425 2475425 0 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212672 212672 0 0.0
.text 2090258 2090258 0 0.0
shell debug (read only) 2591065 2592553 1488 0.1
(read/write) 141872 141872 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233042 233042 0 0.0
.text 2199794 2201282 1488 0.1
thermostat-no-ble arm64 (read only) 2347804 2349068 1264 0.1
(read/write) 141617 141617 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5024 5024 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1970800 1972064 1264 0.1
tv-app debug (read only) 3162793 3164265 1472 0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79088 79088 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257000 257000 0 0.0
.text 2716002 2717474 1472 0.1
tv-casting-app debug (read only) 5400665 5402313 1648 0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98488 98488 0 0.0
.dynamic 608 608 0 0.0
.got 4752 4752 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340337 340337 0 0.0
.text 4792818 4794466 1648 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453560 2453688 128 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1416204 1416332 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177519 128 0.0
bss 143222 143222 0 0.0
rodata 142704 142704 0 0.0
text 812612 812744 132 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157447 1157575 128 0.0
bss 142460 142460 0 0.0
rodata 134400 134400 0 0.0
text 801764 801896 132 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690484 1690580 96 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530280 1530376 96 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634692 1634772 80 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475208 1475288 80 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554980 1555060 80 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403816 1403896 80 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592252 1592348 96 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436592 1436688 96 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805660 805828 168 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569462 569630 168 0.0
lighting-app tlsr9518adk80d (read/write) 827332 827500 168 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587302 587470 168 0.0

@yufengwangca yufengwangca merged commit daf5030 into project-chip:master Aug 5, 2022
@yufengwangca yufengwangca mentioned this pull request Aug 24, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yufengwangca @isiu-apple
Update WiFi Network Diagnostics cluster to align with the spec changes (
b6aaafc 
project-chip#21653)

* Update WiFi Network Diagnostics cluster to align with the spec changes

* Run codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All attributes in WiFi Network Diagnostics cluster have been changed to optional
3 participants
@yufengwangca @yunhanw-google @bzbarsky-apple