Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infineon] Update BLE Char C2 to Indicate instead of Notify #21652

Merged
merged 1 commit into from
Aug 10, 2022
Merged

[Infineon] Update BLE Char C2 to Indicate instead of Notify #21652

merged 1 commit into from
Aug 10, 2022

Conversation

praveenCY
Copy link
Contributor

Problem

Matter spec BTP C2 Char changed to Indication instead of Notification

Change overview

Change BLE BTP C2 Char to indication

Testing

Manually tested commissioning with latest Chip-tool and it works.

@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

PR #21652: Size comparison from 8c555ca to 359c7f3

Increases (7 builds for bl602, cc13x2_26x2, esp32, p6)
platform target config section 8c555ca 359c7f3 change % change
bl602 lighting-app bl602+rpc (read/write) 1425458 1425466 8 0.0
.text 1079812 1079816 4 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 655459 655467 8 0.0
.text 553544 553552 8 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025486 2 0.0
.flash.text 1025484 1025486 2 0.0
p6 all-clusters-app default (read/write) 1690484 1690548 64 0.0
.text 1530280 1530344 64 0.0
all-clusters-minimal-app default (read/write) 1634692 1634740 48 0.0
.text 1475208 1475256 48 0.0
light-app default (read/write) 1554980 1555044 64 0.0
.text 1403816 1403880 64 0.0
lock-app default (read/write) 1592252 1592316 64 0.0
.text 1436592 1436656 64 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 8c555ca 359c7f3 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 181796 181788 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 827332 827324 -8 -0.0
text 587302 587300 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8c555ca 359c7f3 change % change
bl602 lighting-app bl602 (read/write) 1380210 1380210 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048312 1048312 0 0.0
bl602+rpc (read/write) 1425458 1425466 8 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079812 1079816 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670551 670551 0 0.0
(read/write) 180832 180832 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88479 88479 0 0.0
.text 581756 581756 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636063 636063 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558012 558012 0 0.0
lock-ftd LP_CC2652R7 (read only) 673027 673027 0 0.0
(read/write) 168540 168540 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76547 76547 0 0.0
.text 596000 596000 0 0.0
lock-mtd LP_CC2652R7 (read only) 655459 655467 8 0.0
(read/write) 181796 181788 -8 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101435 101435 0 0.0
.text 553544 553552 8 0.0
pump-app LP_CC2652R7 (read only) 682639 682639 0 0.0
(read/write) 159736 159736 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 592908 592908 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667103 667103 0 0.0
(read/write) 175408 175408 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581832 581832 0 0.0
shell LP_CC2652R7 (read only) 663218 663218 0 0.0
(read/write) 183684 183684 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85426 85426 0 0.0
.text 577476 577476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584738 584738 0 0.0
.app_xip_area 461540 461540 0 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590674 590674 0 0.0
.app_xip_area 462692 462692 0 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589882 589882 0 0.0
.app_xip_area 467500 467500 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096476 1096476 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961540 961540 0 0.0
BRD4161A+rpc (read/write) 1150756 1150756 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998924 998924 0 0.0
BRD4161A+rs911x (read/write) 985764 985764 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821504 821504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136328 1136328 0 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989420 989420 0 0.0
window-app BRD4161A (read/write) 1088216 1088216 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951808 951808 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025486 2 0.0
(read/write) 1487234 1487234 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216864 0 0.0
.flash.text 1025484 1025486 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078931 1078931 0 0.0
(read/write) 489240 489240 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247260 0 0.0
.flash.text 1073547 1073547 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644316 644316 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569832 569832 0 0.0
lock k32w0+release (read/write) 701652 701652 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626688 626688 0 0.0
linux all-clusters-app debug (read only) 3020241 3020241 0 0.0
(read/write) 155688 155688 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85352 85352 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272491 272491 0 0.0
.text 2568866 2568866 0 0.0
all-clusters-minimal-app debug (read only) 2862073 2862073 0 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272555 272555 0 0.0
.text 2413266 2413266 0 0.0
bridge-app debug+rpc (read only) 2367961 2367961 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203336 203336 0 0.0
.text 2001618 2001618 0 0.0
chip-tool debug (read only) 10436417 10436417 0 0.0
(read/write) 646368 646368 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 532021 532021 0 0.0
.text 8408228 8408228 0 0.0
chip-tool-ipv6only arm64 (read only) 9845100 9845100 0 0.0
(read/write) 694033 694033 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464124 464124 0 0.0
.text 7753972 7753972 0 0.0
lighting-app debug+rpc (read only) 2590545 2590545 0 0.0
(read/write) 130200 130200 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72440 72440 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 219088 219088 0 0.0
.text 2200386 2200386 0 0.0
lock-app debug (read only) 2574793 2574793 0 0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 236080 236080 0 0.0
.text 2171698 2171698 0 0.0
ota-provider-app debug (read only) 2354881 2354881 0 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209176 209176 0 0.0
.text 1981826 1981826 0 0.0
ota-requestor-app debug (read only) 2475425 2475425 0 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212672 212672 0 0.0
.text 2090258 2090258 0 0.0
shell debug (read only) 2591065 2591065 0 0.0
(read/write) 141872 141872 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233042 233042 0 0.0
.text 2199794 2199794 0 0.0
thermostat-no-ble arm64 (read only) 2347804 2347804 0 0.0
(read/write) 141617 141617 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5024 5024 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1970800 1970800 0 0.0
tv-app debug (read only) 3162793 3162793 0 0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79088 79088 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257000 257000 0 0.0
.text 2716002 2716002 0 0.0
tv-casting-app debug (read only) 5400665 5400665 0 0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98488 98488 0 0.0
.dynamic 608 608 0 0.0
.got 4752 4752 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340337 340337 0 0.0
.text 4792818 4792818 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453560 2453560 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1416204 1416204 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177391 0 0.0
bss 143222 143222 0 0.0
rodata 142704 142704 0 0.0
text 812612 812612 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157447 1157447 0 0.0
bss 142460 142460 0 0.0
rodata 134400 134400 0 0.0
text 801764 801764 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690484 1690548 64 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530280 1530344 64 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634692 1634740 48 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475208 1475256 48 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554980 1555044 64 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403816 1403880 64 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592252 1592316 64 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436592 1436656 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805660 805660 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569462 569462 0 0.0
lighting-app tlsr9518adk80d (read/write) 827332 827324 -8 -0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587302 587300 -2 -0.0

robertfarnum
robertfarnum approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@robertfarnum robertfarnum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me per spec. Did you have the opportunity to test against the CHIPTool, and if so, which versions (Linux, Darwin, Android)?

@praveenCY
Copy link
Contributor Author

Looks good to me per spec. Did you have the opportunity to test against the CHIPTool, and if so, which versions (Linux, Darwin, Android)?

tested with ChipTool Linux version and it works properly.

@woody-apple woody-apple enabled auto-merge (squash) August 9, 2022 14:16
@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

PR #21652: Size comparison from 36fb7cd to d641f08

Increases (12 builds for bl602, cc13x2_26x2, cyw30739, k32w, nrfconnect, p6, telink)
platform target config section 36fb7cd d641f08 change % change
bl602 lighting-app bl602+rpc .text 1079512 1079516 4 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 655315 655323 8 0.0
.text 553472 553480 8 0.0
pump-app LP_CC2652R7 (read/write) 159428 159436 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584470 584478 8 0.0
.app_xip_area 461272 461280 8 0.0
k32w light k32w0+release (read/write) 643564 643580 16 0.0
.text 569080 569096 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177879 1177895 16 0.0
text 813040 813044 4 0.0
p6 all-clusters-app default (read/write) 1691108 1691172 64 0.0
.text 1530904 1530968 64 0.0
all-clusters-minimal-app default (read/write) 1635276 1635324 48 0.0
.text 1475792 1475840 48 0.0
light-app default (read/write) 1553988 1554052 64 0.0
.text 1402824 1402888 64 0.0
lock-app default (read/write) 1591316 1591380 64 0.0
.text 1435656 1435720 64 0.0
telink light-switch-app tlsr9518adk80d text 569734 569736 2 0.0
lighting-app tlsr9518adk80d (read/write) 827832 827840 8 0.0
text 587708 587710 2 0.0
Decreases (3 builds for cc13x2_26x2, esp32)
platform target config section 36fb7cd d641f08 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 181940 181932 -8 -0.0
pump-app LP_CC2652R7 (read only) 682947 682939 -8 -0.0
.text 593148 593140 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1026010 1026006 -4 -0.0
.flash.text 1026010 1026006 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 36fb7cd d641f08 change % change
bl602 lighting-app bl602 (read/write) 1379834 1379834 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048012 1048012 0 0.0
bl602+rpc (read/write) 1425090 1425090 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079512 1079516 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670863 670863 0 0.0
(read/write) 180520 180520 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 582076 582076 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636399 636399 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558348 558348 0 0.0
lock-ftd LP_CC2652R7 (read only) 672715 672715 0 0.0
(read/write) 168852 168852 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595824 595824 0 0.0
lock-mtd LP_CC2652R7 (read only) 655315 655323 8 0.0
(read/write) 181940 181932 -8 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101363 101363 0 0.0
.text 553472 553480 8 0.0
pump-app LP_CC2652R7 (read only) 682947 682939 -8 -0.0
(read/write) 159428 159436 8 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89315 89315 0 0.0
.text 593148 593140 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 667415 667415 0 0.0
(read/write) 175096 175096 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84863 84863 0 0.0
.text 582072 582072 0 0.0
shell LP_CC2652R7 (read only) 663546 663546 0 0.0
(read/write) 183356 183356 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577812 577812 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584470 584478 8 0.0
.app_xip_area 461272 461280 8 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590414 590414 0 0.0
.app_xip_area 462432 462432 0 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596922 596922 0 0.0
.app_xip_area 474444 474444 0 0.0
.bss 64952 64952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096324 1096324 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961388 961388 0 0.0
BRD4161A+rpc (read/write) 1150588 1150588 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998756 998756 0 0.0
BRD4161A+rs911x (read/write) 985844 985844 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821584 821584 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136404 1136404 0 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989496 989496 0 0.0
window-app BRD4161A (read/write) 1088056 1088056 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951648 951648 0 0.0
esp32 all-clusters-app c3devkit (read only) 1026010 1026006 -4 -0.0
(read/write) 1487418 1487418 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217048 217048 0 0.0
.flash.text 1026010 1026006 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079315 1079315 0 0.0
(read/write) 489392 489392 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247412 247412 0 0.0
.flash.text 1073931 1073931 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643564 643580 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569080 569096 16 0.0
lock k32w0+release (read/write) 701012 701012 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626048 626048 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10005036 10005036 0 0.0
(read/write) 695153 695153 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640360 640360 0 0.0
.dynamic 560 560 0 0.0
.got 13656 13656 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 474028 474028 0 0.0
.text 7901332 7901332 0 0.0
thermostat-no-ble arm64 (read only) 2349964 2349964 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139716 139716 0 0.0
.text 1972720 1972720 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452656 2452656 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415300 1415300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177879 1177895 16 0.0
bss 143222 143222 0 0.0
rodata 142776 142776 0 0.0
text 813040 813044 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157919 1157919 0 0.0
bss 142460 142460 0 0.0
rodata 134472 134472 0 0.0
text 802164 802164 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1691108 1691172 64 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530904 1530968 64 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635276 1635324 48 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475792 1475840 48 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553988 1554052 64 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402824 1402888 64 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591316 1591380 64 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435656 1435720 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806032 806032 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569734 569736 2 0.0
lighting-app tlsr9518adk80d (read/write) 827832 827840 8 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587708 587710 2 0.0

@praveenCY
Copy link
Contributor Author

/rebase

@praveenCY praveenCY force-pushed the topic/pucn_updatebleindicate branch from d641f08 to e068d7c Compare August 9, 2022 20:36
@woody-apple woody-apple force-pushed the topic/pucn_updatebleindicate branch from e068d7c to 9068505 Compare August 9, 2022 21:51
@woody-apple woody-apple merged commit d059680 into project-chip:master Aug 10, 2022
@github-actions
Copy link

github-actions bot commented Aug 10, 2022 •
edited
Loading

PR #21652: Size comparison from 3860268 to 9068505

Increases (9 builds for bl602, cc13x2_26x2, efr32, p6, telink)
platform target config section 3860268 9068505 change % change
bl602 lighting-app bl602+rpc .text 1079632 1079636 4 0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 683011 683019 8 0.0
.text 593212 593220 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1136468 1136484 16 0.0
.text 989560 989576 16 0.0
p6 all-clusters-app default (read/write) 1693812 1693876 64 0.0
.text 1533600 1533664 64 0.0
all-clusters-minimal-app default (read/write) 1637980 1638044 64 0.0
.text 1478488 1478552 64 0.0
light-app default (read/write) 1556668 1556732 64 0.0
.text 1405496 1405560 64 0.0
lock-app default (read/write) 1593980 1594044 64 0.0
.text 1438312 1438376 64 0.0
telink light-switch-app tlsr9518adk80d text 569822 569826 4 0.0
lighting-app tlsr9518adk80d text 587798 587800 2 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 3860268 9068505 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 159364 159356 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3860268 9068505 change % change
bl602 lighting-app bl602 (read/write) 1379954 1379954 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048132 1048132 0 0.0
bl602+rpc (read/write) 1425210 1425210 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079632 1079636 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670927 670927 0 0.0
(read/write) 180456 180456 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 582140 582140 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636471 636471 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558420 558420 0 0.0
lock-ftd LP_CC2652R7 (read only) 672787 672787 0 0.0
(read/write) 168780 168780 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595896 595896 0 0.0
lock-mtd LP_CC2652R7 (read only) 655395 655395 0 0.0
(read/write) 181860 181860 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101363 101363 0 0.0
.text 553552 553552 0 0.0
pump-app LP_CC2652R7 (read only) 683011 683019 8 0.0
(read/write) 159364 159356 -8 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89315 89315 0 0.0
.text 593212 593220 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667487 667487 0 0.0
(read/write) 175024 175024 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84863 84863 0 0.0
.text 582144 582144 0 0.0
shell LP_CC2652R7 (read only) 663610 663610 0 0.0
(read/write) 183292 183292 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577876 577876 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584646 584646 0 0.0
.app_xip_area 461448 461448 0 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590582 590582 0 0.0
.app_xip_area 462600 462600 0 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596962 596962 0 0.0
.app_xip_area 474484 474484 0 0.0
.bss 64952 64952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096372 1096372 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961436 961436 0 0.0
BRD4161A+rpc (read/write) 1150636 1150636 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998804 998804 0 0.0
BRD4161A+rs911x (read/write) 985908 985908 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821648 821648 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136468 1136484 16 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989560 989576 16 0.0
window-app BRD4161A (read/write) 1088104 1088104 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951696 951696 0 0.0
esp32 all-clusters-app c3devkit (read only) 1026078 1026078 0 0.0
(read/write) 1487418 1487418 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217048 217048 0 0.0
.flash.text 1026078 1026078 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079367 1079367 0 0.0
(read/write) 489392 489392 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247412 247412 0 0.0
.flash.text 1073983 1073983 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643644 643644 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569160 569160 0 0.0
lock k32w0+release (read/write) 701076 701076 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626112 626112 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10007084 10007084 0 0.0
(read/write) 695153 695153 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640360 640360 0 0.0
.dynamic 560 560 0 0.0
.got 13656 13656 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 474124 474124 0 0.0
.text 7903284 7903284 0 0.0
thermostat-no-ble arm64 (read only) 2350956 2350956 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139716 139716 0 0.0
.text 1973712 1973712 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452720 2452720 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415364 1415364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177959 1177959 0 0.0
bss 143222 143222 0 0.0
rodata 142776 142776 0 0.0
text 813112 813112 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157983 1157983 0 0.0
bss 142460 142460 0 0.0
rodata 134472 134472 0 0.0
text 802232 802232 0 0.0
p6 all-clusters-app default (read only) 881520 881520 0 0.0
(read/write) 1693812 1693876 64 0.0
.bss 149168 149168 0 0.0
.data 2656 2656 0 0.0
.text 1533600 1533664 64 0.0
all-clusters-minimal-app default (read only) 882240 882240 0 0.0
(read/write) 1637980 1638044 64 0.0
.bss 148448 148448 0 0.0
.data 2656 2656 0 0.0
.text 1478488 1478552 64 0.0
light-app default (read only) 890560 890560 0 0.0
(read/write) 1556668 1556732 64 0.0
.bss 140336 140336 0 0.0
.data 2448 2448 0 0.0
.text 1405496 1405560 64 0.0
lock-app default (read only) 886064 886064 0 0.0
(read/write) 1593980 1594044 64 0.0
.bss 144816 144816 0 0.0
.data 2464 2464 0 0.0
.text 1438312 1438376 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806120 806120 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569822 569826 4 0.0
lighting-app tlsr9518adk80d (read/write) 827928 827928 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587798 587800 2 0.0

isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@praveenCY @isiu-apple
[Infineon] Update BLE Char C2 to Indicate instead of Notify (project-…
cd8b163 
…chip#21652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@robertfarnum robertfarnum robertfarnum approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praveenCY @yunhanw-google @robertfarnum @woody-apple