Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed attributes from client cluster #21620

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Removed attributes from client cluster #21620

merged 1 commit into from
Aug 5, 2022

Conversation

jadhavrohit924
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

See above

Testing

How was this tested? (at least one bullet point required)

  • testing not required.

@github-actions github-actions bot added the app label Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022 •
edited
Loading

PR #21620: Size comparison from 8e8a97e to 08848e6

Increases (1 build for nrfconnect)
platform target config section 8e8a97e 08848e6 change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157511 1157527 16 0.0
text 801808 801812 4 0.0
Decreases (1 build for esp32)
platform target config section 8e8a97e 08848e6 change % change
esp32 all-clusters-app c3devkit (read only) 1025492 1025490 -2 -0.0
.flash.text 1025492 1025490 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8e8a97e 08848e6 change % change
bl602 lighting-app bl602 (read/write) 1380202 1380202 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048308 1048308 0 0.0
bl602+rpc (read/write) 1425458 1425458 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079808 1079808 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670667 670667 0 0.0
(read/write) 180716 180716 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88539 88539 0 0.0
.text 581812 581812 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636195 636195 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77795 77795 0 0.0
.text 558076 558076 0 0.0
lock-ftd LP_CC2652R7 (read only) 673151 673151 0 0.0
(read/write) 168416 168416 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76607 76607 0 0.0
.text 596064 596064 0 0.0
lock-mtd LP_CC2652R7 (read only) 655555 655555 0 0.0
(read/write) 181700 181700 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101467 101467 0 0.0
.text 553608 553608 0 0.0
pump-app LP_CC2652R7 (read only) 682743 682743 0 0.0
(read/write) 159632 159632 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89271 89271 0 0.0
.text 592988 592988 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667207 667207 0 0.0
(read/write) 175304 175304 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84815 84815 0 0.0
.text 581912 581912 0 0.0
shell LP_CC2652R7 (read only) 663334 663334 0 0.0
(read/write) 183568 183568 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85486 85486 0 0.0
.text 577532 577532 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584814 584814 0 0.0
.app_xip_area 461624 461624 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590718 590718 0 0.0
.app_xip_area 462744 462744 0 0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 590038 590038 0 0.0
.app_xip_area 467656 467656 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1090900 1090900 0 0.0
.bss 133292 133292 0 0.0
.data 2064 2064 0 0.0
.text 955524 955524 0 0.0
BRD4161A+rpc (read/write) 1145196 1145196 0 0.0
.bss 149972 149972 0 0.0
.data 2276 2276 0 0.0
.text 992924 992924 0 0.0
BRD4161A+rs911x (read/write) 977368 977368 0 0.0
.bss 161784 161784 0 0.0
.data 2052 2052 0 0.0
.text 813512 813512 0 0.0
lock-app BRD4161A+wf200 (read/write) 1130896 1130896 0 0.0
.bss 144416 144416 0 0.0
.data 2060 2060 0 0.0
.text 984400 984400 0 0.0
window-app BRD4161A (read/write) 1082644 1082644 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945784 945784 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025492 1025490 -2 -0.0
(read/write) 1487234 1487234 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216864 0 0.0
.flash.text 1025492 1025490 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078939 1078939 0 0.0
(read/write) 489232 489232 0 0.0
.dram0.bss 75832 75832 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247260 0 0.0
.flash.text 1073555 1073555 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644408 644408 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569916 569916 0 0.0
lock k32w0+release (read/write) 701720 701720 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626756 626756 0 0.0
linux all-clusters-app debug (read only) 3020145 3020145 0 0.0
(read/write) 155688 155688 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85352 85352 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272491 272491 0 0.0
.text 2568770 2568770 0 0.0
all-clusters-minimal-app debug (read only) 2861977 2861977 0 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272555 272555 0 0.0
.text 2413170 2413170 0 0.0
bridge-app debug+rpc (read only) 2367817 2367817 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203304 203304 0 0.0
.text 2001506 2001506 0 0.0
chip-tool debug (read only) 10441369 10441369 0 0.0
(read/write) 646336 646336 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 531349 531349 0 0.0
.text 8414068 8414068 0 0.0
chip-tool-ipv6only arm64 (read only) 9848684 9848684 0 0.0
(read/write) 694017 694017 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 463452 463452 0 0.0
.text 7758404 7758404 0 0.0
lighting-app debug+rpc (read only) 2590481 2590481 0 0.0
(read/write) 130232 130232 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 219120 219120 0 0.0
.text 2200290 2200290 0 0.0
lock-app debug (read only) 2574665 2574665 0 0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 236048 236048 0 0.0
.text 2171602 2171602 0 0.0
ota-provider-app debug (read only) 2354753 2354753 0 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209144 209144 0 0.0
.text 1981730 1981730 0 0.0
ota-requestor-app debug (read only) 2475361 2475361 0 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212704 212704 0 0.0
.text 2090162 2090162 0 0.0
shell debug (read only) 2591353 2591353 0 0.0
(read/write) 141840 141840 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76976 76976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233426 233426 0 0.0
.text 2199698 2199698 0 0.0
thermostat-no-ble arm64 (read only) 2347660 2347660 0 0.0
(read/write) 141601 141601 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1970672 1970672 0 0.0
tv-app debug (read only) 3161617 3161617 0 0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79104 79104 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257032 257032 0 0.0
.text 2715010 2715010 0 0.0
tv-casting-app debug (read only) 5398561 5398561 0 0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340337 340337 0 0.0
.text 4790930 4790930 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453424 2453424 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1416068 1416068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177455 1177455 0 0.0
bss 143222 143222 0 0.0
rodata 142736 142736 0 0.0
text 812656 812656 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157511 1157527 16 0.0
bss 142460 142460 0 0.0
rodata 134432 134432 0 0.0
text 801808 801812 4 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690500 1690500 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530296 1530296 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634692 1634692 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475208 1475208 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554980 1554980 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403816 1403816 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592268 1592268 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436608 1436608 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805760 805760 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569548 569548 0 0.0
lighting-app tlsr9518adk80d (read/write) 827432 827432 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587388 587388 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 753415d into project-chip:master Aug 5, 2022
@jadhavrohit924 jadhavrohit924 deleted the client-cluster branch August 5, 2022 06:26
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@jadhavrohit924 @isiu-apple
Removed attributes from client cluster (project-chip#21620)
b32b9e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@dhrishi dhrishi dhrishi approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some client clusters has attributes in xml
3 participants
@jadhavrohit924 @dhrishi @bzbarsky-apple