Listen for group messages on all relevant interfaces in the sockets implementation. #21611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplementation. We were listening on the "default" interface if MulticastGroupJoinLeave got called for an enpoint that was bound to the wildcard interface. But that does not work in some situation (e.g. on Mac). Instead, detect that we're dealing with the wildcard interface, and explicitly iterate over all viable interfaces.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
saurabhst
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
jepenven-silabs
approved these changes
Aug 3, 2022
|
PR #21611: Size comparison from a494ddf to 8eca981 Increases (4 builds for bl602, linux)
Decreases (1 build for cyw30739)
Full report (13 builds for bl602, cyw30739, k32w, linux, nrfconnect, telink)
|
|
PR #21611: Size comparison from a494ddf to 1ba0288 Increases (16 builds for bl602, cc13x2_26x2, linux)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 4, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…mplementation. (project-chip#21611) * Listen for group messages on all relevant interfaces in the sockets implementation. We were listening on the "default" interface if MulticastGroupJoinLeave got called for an enpoint that was bound to the wildcard interface. But that does not work in some situation (e.g. on Mac). Instead, detect that we're dealing with the wildcard interface, and explicitly iterate over all viable interfaces. * Fix build on MbedOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were listening on the "default" interface if MulticastGroupJoinLeave got called for an enpoint that was bound to the wildcard interface. But that does not work in some situation (e.g. on Mac).
Instead, detect that we're dealing with the wildcard interface, and
explicitly iterate over all viable interfaces.
Problem
See above.
Change overview
See above.
Testing
Should now be able to run the groups tests in CI on Mac.