-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change for on off transitiontime feature #21569
change for on off transitiontime feature #21569
Conversation
PR #21569: Size comparison from 3aa138f to 66fbcdb Increases (15 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, esp32, k32w, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
66fbcdb
to
99944df
Compare
PR #21569: Size comparison from edb93a0 to 99944df Increases (13 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
99944df
to
359c1bf
Compare
PR #21569: Size comparison from dc66d4e to 359c1bf Increases (12 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
359c1bf
to
77023c9
Compare
PR #21569: Size comparison from f2cd15f to 77023c9 Increases (13 builds for bl702, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6)
Decreases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #21569: Size comparison from f72807b to e23eaf4 Increases (11 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg)
Decreases (5 builds for cc13x2_26x2, psoc6, qpg, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
e23eaf4
to
9a74ce4
Compare
PR #21569: Size comparison from 57c7321 to 9a74ce4 Increases (13 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #21569: Size comparison from 5056270 to 318ff11 Increases (9 builds for bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, psoc6, qpg, telink)
Full report (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, psoc6, qpg, telink)
|
318ff11
to
390085b
Compare
PR #21569: Size comparison from 0bff5ad to 390085b Increases (16 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for esp32, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
The "Darwin" test that fails does the following:
That 3 second timeout is getting hit. As far as I can tell, OnOffTransitionTime is 0 in this case, so there is no a priori reason that this timeout should be getting hit in this situation. I also tried to change the 3-second wait to 15 seconds, and the test failed in exactly the same way. So at first glance there is a real bug here and either the onoff state is never changing to "off" or the subscription reports are not being sent correctly when it does. |
390085b
to
0c1346d
Compare
PR #21569: Size comparison from 7b284c0 to 0c1346d Increases (10 builds for bl702, cyw30739, esp32, nrfconnect, psoc6)
Decreases (5 builds for bl702, esp32, psoc6, qpg)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
2db7754
to
7ba8720
Compare
PR #21569: Size comparison from c46da7c to 7ba8720 Increases (13 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6)
Decreases (7 builds for esp32, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* change for on off transitiontime feature * Restyled by clang-format * update for build error * Restyled by clang-format * Fix subscription test to handle separate reports for different attributes better. Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
This reverts commit b810f77.
Problem
Fixes #22750
Fixed the OnOffTransition feature when receiving an off command and OnOffTransitionTime is non-zero.
Testing OnOffTransitionTime feature, when receiving off command, the previous order: onoff attribute change to off, then execute move-to-level,
The phenomenon of light is off immediately, no fade out.
The correct order should be : when receiving off command ,if defined EMBER_AF_PLUGIN_LEVEL_CONTROL, should execute move-to-level-with-on-off, adjust level first, when the level move to min-level, change the onoff attribute to off, if not define on-level, set current level to stored level.
Change overview
Testing
test using esp32 lighting-app example