Updated DAC Validation Procedure to Match the Spec. #21531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
saurabhst and
selissia
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #21531: Size comparison from cbd90ca to dc6cd50 Increases (1 build for linux)
Decreases (2 builds for linux, telink)
Full report (13 builds for bl602, linux, mbed, nrfconnect, p6, telink)
|
emargolis
force-pushed
the
emargolis/feature/update-dac-time-validity
branch
from
dc6cd50 to
305ef9c
Compare
|
PR #21531: Size comparison from cbd90ca to 305ef9c Increases (8 builds for bl602, cc13x2_26x2, esp32, linux)
Decreases (6 builds for cc13x2_26x2, esp32, linux, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 2, 2022
tcarmelveilleux
approved these changes
Aug 2, 2022
msandstedt
reviewed
Aug 2, 2022
src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.cpp
Outdated
Show resolved
Hide resolved
msandstedt
reviewed
Aug 2, 2022
There was a problem hiding this comment.
Most of this looks functionally good to me, but it would be nice if we could close on this:
https://github.com/project-chip/connectedhomeip/pull/21531/files#r936068987
The operative question is whether a DAC requires NotAfter to be set to X509NoWellDefinedExpirationDate in order to achieve non-expiration for the chain. The spec is very explicit that PAA and PAI don't require this, but I can't find any language that would remove the requirement for a DAC.
- Updated mbedTLS implementation of the ValidateCertificateChain() to ignore
validity checks of the certificates in the validation chain.
- Updated OpenSSL implementation of the ValidateCertificateChain() to use
notBefore time of the DAC certificate as a current time. That way the chain
validation function checks exactly that the PAA and PAI were valid at the
time of DAC generation.
- NOTE: Ideally it would be nice if mbedTLS and OpenSSL implementations of
ValidateCertificateChain() function behaive similar. Unfortunately, I didn't
find a way to adjust the mbedTLS current time during the chain validation.
- Created new test vectors for PAA, PAI, and DAC (correct and with errors)
to validate all various corner cases of the implementation.
emargolis
force-pushed
the
emargolis/feature/update-dac-time-validity
branch
from
305ef9c to
d0a8a60
Compare
|
PR #21531: Size comparison from 3deee28 to d0a8a60 Increases above 0.2%:
Increases (6 builds for esp32, linux)
Decreases (5 builds for cyw30739, esp32, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Aug 4, 2022
This was referenced Aug 9, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
- Removed use of IsCertificateValidAtCurrentTime() as spec doesn't require
DAC certificate validity check at the current time.
- Updated mbedTLS implementation of the ValidateCertificateChain() to ignore
validity checks of the certificates in the validation chain.
- Updated OpenSSL implementation of the ValidateCertificateChain() to use
notBefore time of the DAC certificate as a current time. That way the chain
validation function checks exactly that the PAA and PAI were valid at the
time of DAC generation.
- NOTE: Ideally it would be nice if mbedTLS and OpenSSL implementations of
ValidateCertificateChain() function behaive similar. Unfortunately, I didn't
find a way to adjust the mbedTLS current time during the chain validation.
- Created new test vectors for PAA, PAI, and DAC (correct and with errors)
to validate all various corner cases of the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The attestation certificate chain validation doesn't match the spec requirements.
ticket #21007
Change overview
DAC certificate validity check at the current time.
validity checks of the certificates in the validation chain.
notBefore time of the DAC certificate as a current time. That way the chain
validation function checks exactly that the PAA and PAI were valid at the
time of DAC generation.
ValidateCertificateChain() function behaive similar. Unfortunately, I didn't
find a way to adjust the mbedTLS current time during the chain validation.
to validate all various corner cases of the implementation.
Testing
Generated new test vectors and added new tests