Fix comparison of a nullable value to a non-nullable saved value. #21507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code generated for the case when a non-nullable value was saved via saveAs and then a nullable value was being compared to it did not compile, because we would try to do .IsNull() and .Value() on the non-nullable saved value. The changes here check whether the saved value is actually nullable and generate code accordingly, instead of assuming that if we're comparing a nullable to something the something must also be nullable.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #21507: Size comparison from 7a4f84f to cc47116 Increases (3 builds for cc13x2_26x2, nrfconnect)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 2, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
…1507) The code generated for the case when a non-nullable value was saved via saveAs and then a nullable value was being compared to it did not compile, because we would try to do .IsNull() and .Value() on the non-nullable saved value. The changes here check whether the saved value is actually nullable and generate code accordingly, instead of assuming that if we're comparing a nullable to something the something must also be nullable.
woody-apple
added a commit
that referenced
this pull request
Aug 2, 2022
…1507) (#21516) The code generated for the case when a non-nullable value was saved via saveAs and then a nullable value was being compared to it did not compile, because we would try to do .IsNull() and .Value() on the non-nullable saved value. The changes here check whether the saved value is actually nullable and generate code accordingly, instead of assuming that if we're comparing a nullable to something the something must also be nullable. Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…oject-chip#21507) The code generated for the case when a non-nullable value was saved via saveAs and then a nullable value was being compared to it did not compile, because we would try to do .IsNull() and .Value() on the non-nullable saved value. The changes here check whether the saved value is actually nullable and generate code accordingly, instead of assuming that if we're comparing a nullable to something the something must also be nullable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code generated for the case when a non-nullable value was saved via saveAs
and then a nullable value was being compared to it did not compile, because we
would try to do .IsNull() and .Value() on the non-nullable saved value.
The changes here check whether the saved value is actually nullable and generate
code accordingly, instead of assuming that if we're comparing a nullable to
something the something must also be nullable.
Problem
See above. This came up in #21361
Change overview
See above.
Testing
Verified that regenerating #21361 with this change makes it generate correct code.