-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't touch member variables from async dispatch. #21506
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-7a4f84f311ebd29857cef880c753a732dd723877
Aug 2, 2022
Merged
Don't touch member variables from async dispatch. #21506
woody-apple
merged 1 commit into
sve
from
cherry-pick-7a4f84f311ebd29857cef880c753a732dd723877
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were null-checking members, then calling them from an async block, by which point they might be null. Fixes #21453
PR #21506: Size comparison from c5e7ab6 to c39c4c2 Increases (3 builds for bl602, k32w, telink)
Decreases (2 builds for nrfconnect, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-7a4f84f311ebd29857cef880c753a732dd723877
branch
August 2, 2022 01:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were null-checking members, then calling them from an async block,
by which point they might be null.
Fixes #21453
Problem
Crashes.
Change overview
See above.
Testing
Need to do stress-testing to see how this does on the crash stacks we are seeing...