Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lockout for door lock #21498

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Implement lockout for door lock #21498

merged 1 commit into from
Aug 1, 2022

Conversation

woody-apple
Copy link
Contributor

Problem

Change overview

Now door lock cluster tracks the lockout per each endpoint.

Testing

  • Manual testing: attempt to lock/unlock with valid PIN, then 3 times with invalid and verified that for 10 seconds my commands were ignored (failure response and absence of LockOperationError event).

@Morozov-5F @web-flow
Implement lockout for door lock (#21408)
9cf02d5 
* [#19989] Implement lockout for door lock

* Update auto-generated files
@github-actions
Copy link

github-actions bot commented Aug 1, 2022 •
edited
Loading

PR #21498: Size comparison from 59ecf97 to 9cf02d5

Increases above 0.2%:

platform target config section 59ecf97 9cf02d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 88283 88467 184 0.2
all-clusters-minimal-app LP_CC2652R7 .rodata 77507 77691 184 0.2
lock-ftd LP_CC2652R7 .rodata 76351 76535 184 0.2
lock-mtd LP_CC2652R7 .rodata 101107 101531 424 0.4
shell LP_CC2652R7 .rodata 85262 85446 184 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 142928 143344 416 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 134456 134876 420 0.3
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section 59ecf97 9cf02d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669139 669707 568 0.1
.bss 74252 74276 24 0.0
.rodata 88283 88467 184 0.2
.text 580540 580924 384 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 634659 635227 568 0.1
(read/write) 157828 157844 16 0.0
.bss 73540 73556 16 0.0
.rodata 77507 77691 184 0.2
.text 556828 557212 384 0.1
lock-ftd LP_CC2652R7 (read only) 671999 672567 568 0.1
.bss 71324 71348 24 0.0
.rodata 76351 76535 184 0.2
.text 595168 595552 384 0.1
lock-mtd LP_CC2652R7 (read only) 654283 655139 856 0.1
.bss 67012 67036 24 0.0
.rodata 101107 101531 424 0.4
.text 552696 553128 432 0.1
shell LP_CC2652R7 (read only) 661838 662406 568 0.1
.bss 76572 76596 24 0.0
.rodata 85262 85446 184 0.2
.text 576260 576644 384 0.1
cyw30739 lock cyw930739m2evb_01 (read/write) 589654 589998 344 0.1
.app_xip_area 461880 462200 320 0.1
.bss 70360 70384 24 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1129216 1130096 880 0.1
.bss 144376 144400 24 0.0
.text 982764 983620 856 0.1
esp32 all-clusters-app c3devkit (read only) 1023870 1024394 524 0.1
(read/write) 1486602 1487042 440 0.0
.dram0.bss 70312 70336 24 0.0
.flash.rodata 216248 216672 424 0.2
.flash.text 1023870 1024394 524 0.1
m5stack (read only) 1077319 1077863 544 0.1
(read/write) 488624 489064 440 0.1
.dram0.bss 75824 75840 16 0.0
.flash.rodata 246660 247084 424 0.2
.flash.text 1071935 1072479 544 0.1
k32w lock k32w0+release (read/write) 700608 701512 904 0.1
.bss 70160 70184 24 0.0
.text 625668 626548 880 0.1
linux chip-tool-ipv6only arm64 (read only) 9854044 9858172 4128 0.0
.rodata 469468 470140 672 0.1
.text 7806564 7810020 3456 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452344 2453224 880 0.0
.bss 214532 214548 16 0.0
.text 1414988 1415868 880 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180071 1180935 864 0.1
bss 143204 143224 20 0.0
rodata 142928 143344 416 0.3
text 815060 815508 448 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159959 1160811 852 0.1
bss 142440 142460 20 0.0
rodata 134456 134876 420 0.3
text 804220 804656 436 0.1
p6 all-clusters-app default (read/write) 1688300 1689268 968 0.1
.bss 149152 149168 16 0.0
.text 1528112 1529064 952 0.1
all-clusters-minimal-app default (read/write) 1632324 1633300 976 0.1
.bss 148424 148448 24 0.0
.text 1472864 1473816 952 0.1
lock-app default (read/write) 1591012 1591988 976 0.1
.bss 144792 144816 24 0.0
.text 1435376 1436328 952 0.1
Decreases (7 builds for cc13x2_26x2, p6)
platform target config section 59ecf97 9cf02d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182220 181676 -544 -0.3
lock-ftd LP_CC2652R7 (read/write) 169544 169000 -544 -0.3
lock-mtd LP_CC2652R7 (read/write) 182948 182116 -832 -0.5
shell LP_CC2652R7 (read/write) 185040 184496 -544 -0.3
p6 all-clusters-app default (read only) 881544 881528 -16 -0.0
all-clusters-minimal-app default (read only) 882272 882248 -24 -0.0
lock-app default (read only) 886096 886072 -24 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section 59ecf97 9cf02d5 change % change
bl602 lighting-app bl602 (read/write) 1382250 1382250 0 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052364 1052364 0 0.0
bl602+rpc (read/write) 1427682 1427682 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1084060 1084060 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669139 669707 568 0.1
(read/write) 182220 181676 -544 -0.3
.bss 74252 74276 24 0.0
.data 3372 3372 0 0.0
.rodata 88283 88467 184 0.2
.text 580540 580924 384 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 634659 635227 568 0.1
(read/write) 157828 157844 16 0.0
.bss 73540 73556 16 0.0
.data 3372 3372 0 0.0
.rodata 77507 77691 184 0.2
.text 556828 557212 384 0.1
lock-ftd LP_CC2652R7 (read only) 671999 672567 568 0.1
(read/write) 169544 169000 -544 -0.3
.bss 71324 71348 24 0.0
.data 3296 3296 0 0.0
.rodata 76351 76535 184 0.2
.text 595168 595552 384 0.1
lock-mtd LP_CC2652R7 (read only) 654283 655139 856 0.1
(read/write) 182948 182116 -832 -0.5
.bss 67012 67036 24 0.0
.data 3296 3296 0 0.0
.rodata 101107 101531 424 0.4
.text 552696 553128 432 0.1
pump-app LP_CC2652R7 (read only) 681055 681055 0 0.0
(read/write) 161320 161320 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 591652 591652 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666631 666631 0 0.0
(read/write) 175880 175880 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581408 581408 0 0.0
shell LP_CC2652R7 (read only) 661838 662406 568 0.1
(read/write) 185040 184496 -544 -0.3
.bss 76572 76596 24 0.0
.data 3376 3376 0 0.0
.rodata 85262 85446 184 0.2
.text 576260 576644 384 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 583742 583742 0 0.0
.app_xip_area 460696 460696 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589654 589998 344 0.1
.app_xip_area 461880 462200 320 0.1
.bss 70360 70384 24 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589458 589458 0 0.0
.app_xip_area 467220 467220 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088960 1088960 0 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953608 953608 0 0.0
BRD4161A+rpc (read/write) 1143300 1143300 0 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 991056 991056 0 0.0
BRD4161A+rs911x (read/write) 974256 974256 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 810444 810444 0 0.0
lock-app BRD4161A+wf200 (read/write) 1129216 1130096 880 0.1
.bss 144376 144400 24 0.0
.data 2056 2056 0 0.0
.text 982764 983620 856 0.1
window-app BRD4161A (read/write) 1082252 1082252 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945388 945388 0 0.0
esp32 all-clusters-app c3devkit (read only) 1023870 1024394 524 0.1
(read/write) 1486602 1487042 440 0.0
.dram0.bss 70312 70336 24 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216248 216672 424 0.2
.flash.text 1023870 1024394 524 0.1
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077319 1077863 544 0.1
(read/write) 488624 489064 440 0.1
.dram0.bss 75824 75840 16 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 247084 424 0.2
.flash.text 1071935 1072479 544 0.1
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643368 643368 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 568876 568876 0 0.0
lock k32w0+release (read/write) 700608 701512 904 0.1
.bss 70160 70184 24 0.0
.data 2052 2052 0 0.0
.text 625668 626548 880 0.1
linux chip-tool-ipv6only arm64 (read only) 9854044 9858172 4128 0.0
(read/write) 676865 676865 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 622200 622200 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 469468 470140 672 0.1
.text 7806564 7810020 3456 0.0
thermostat-no-ble arm64 (read only) 2349308 2349308 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139316 139316 0 0.0
.text 1972480 1972480 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452344 2453224 880 0.0
.bss 214532 214548 16 0.0
.data 5872 5872 0 0.0
.text 1414988 1415868 880 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180071 1180935 864 0.1
bss 143204 143224 20 0.0
rodata 142928 143344 416 0.3
text 815060 815508 448 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159959 1160811 852 0.1
bss 142440 142460 20 0.0
rodata 134456 134876 420 0.3
text 804220 804656 436 0.1
p6 all-clusters-app default (read only) 881544 881528 -16 -0.0
(read/write) 1688300 1689268 968 0.1
.bss 149152 149168 16 0.0
.data 2648 2648 0 0.0
.text 1528112 1529064 952 0.1
all-clusters-minimal-app default (read only) 882272 882248 -24 -0.0
(read/write) 1632324 1633300 976 0.1
.bss 148424 148448 24 0.0
.data 2648 2648 0 0.0
.text 1472864 1473816 952 0.1
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553348 1553348 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402184 1402184 0 0.0
lock-app default (read only) 886096 886072 -24 -0.0
(read/write) 1591012 1591988 976 0.1
.bss 144792 144816 24 0.0
.data 2456 2456 0 0.0
.text 1435376 1436328 952 0.1

@woody-apple woody-apple merged commit b3c0941 into sve Aug 1, 2022
@woody-apple woody-apple deleted the cherry-pick-c902d88fa510511de3e5b5be6a2b04710a8f096f branch August 1, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @Morozov-5F