-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error logging during Darwin controller startup. #21445
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-a2a0dd49a556e239ed61bba2cb1a962f218c9a9a
Jul 30, 2022
Merged
Improve error logging during Darwin controller startup. #21445
woody-apple
merged 1 commit into
sve
from
cherry-pick-a2a0dd49a556e239ed61bba2cb1a962f218c9a9a
Jul 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we are not reporting any details about what error we encountered. We should report those details.
PR #21445: Size comparison from 9be374f to 9b6a150 Increases (3 builds for cc13x2_26x2, esp32, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-a2a0dd49a556e239ed61bba2cb1a962f218c9a9a
branch
July 30, 2022 02:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are not reporting any details about what error we
encountered. We should report those details.
Problem
Not very informative logging.
Change overview
Log more.
Testing
Introduced an error in FabricTable and made sure I got the relevant file/line logged.