-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "./gn_build.sh is_asan=true" work by default on Mac. #21370
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-fb9cd5ce8ca68c1e21e5c33f84cadfd47c21d435
Jul 29, 2022
Merged
Make "./gn_build.sh is_asan=true" work by default on Mac. #21370
woody-apple
merged 1 commit into
sve
from
cherry-pick-fb9cd5ce8ca68c1e21e5c33f84cadfd47c21d435
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boringssl tests don't compile with asan on Mac.
PR #21370: Size comparison from efb3209 to 8507700 Increases (4 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-fb9cd5ce8ca68c1e21e5c33f84cadfd47c21d435
branch
July 29, 2022 05:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boringssl tests don't compile with asan on Mac.
Problem
See above.
Change overview
Only turn on the boringssl tests on mac when is_asan is false.
Testing
Compiled with both is_asan true and false on Mac.