-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Android app - Enable shell commands and add basic support for some of them #21342
Merged
woody-apple
merged 5 commits into
project-chip:master
from
lazarkov:feature/add-shell-and-vendor-id
Jul 29, 2022
Merged
TV Android app - Enable shell commands and add basic support for some of them #21342
woody-apple
merged 5 commits into
project-chip:master
from
lazarkov:feature/add-shell-and-vendor-id
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
robszewczyk,
saurabhst and
selissia
July 28, 2022 10:34
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 28, 2022 10:34
PR #21342: Size comparison from e758eb2 to bf6f0b2 Increases (3 builds for bl602, cc13x2_26x2)
Decreases (4 builds for cc13x2_26x2, nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
lazarkov
force-pushed
the
feature/add-shell-and-vendor-id
branch
from
July 29, 2022 07:06
bf6f0b2
to
e4abc96
Compare
PR #21342: Size comparison from 21b1e5a to e4abc96 Increases (2 builds for esp32, nrfconnect)
Decreases (1 build for bl602)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 29, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
… of them (#21342) * Enable shell commands and add basic support for some of them * Restyle fix * Forgot to add the main file * Minor comment * Restyle fix
woody-apple
added a commit
that referenced
this pull request
Jul 30, 2022
… of them (#21342) (#21446) * Enable shell commands and add basic support for some of them * Restyle fix * Forgot to add the main file * Minor comment * Restyle fix Co-authored-by: Lazar Kovacic <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
… of them (project-chip#21342) * Enable shell commands and add basic support for some of them * Restyle fix * Forgot to add the main file * Minor comment * Restyle fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Manually tested the flow:
cast request 0
cast cluster channel read channel-list 0 1