Clean up the redundant user labels when the list becomes smaller than previous list for a given endpoint #21336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
saurabhst
pullapprove
bot
requested review from
woody-apple,
xylophone21 and
yunhanw-google
|
PR #21336: Size comparison from 19163f8 to 1d55aa2 Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
requested changes
Jul 28, 2022
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
requested changes
Jul 28, 2022
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Outdated
Show resolved
Hide resolved
|
PR #21336: Size comparison from 00b5886 to 82edb88 Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #21336: Size comparison from 00b5886 to 3acd76a Increases (3 builds for mbed, nrfconnect)
Full report (3 builds for mbed, nrfconnect)
|
|
PR #21336: Size comparison from ae2ca6d to a5c854d Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 29, 2022
Damian-Nordic
approved these changes
Jul 29, 2022
|
PR #21336: Size comparison from 0064643 to 166296b Increases above 0.2%:
Increases (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (8 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
… previous list for a given endpoint (#21336) * Clean up unused UserLabel after it is not in use * Conduct user label cleanup in the user label cluster
woody-apple
added a commit
that referenced
this pull request
Jul 29, 2022
… previous list for a given endpoint (#21336) (#21429) * Clean up unused UserLabel after it is not in use * Conduct user label cleanup in the user label cluster Co-authored-by: Yufeng Wang <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
… previous list for a given endpoint (project-chip#21336) * Clean up unused UserLabel after it is not in use * Conduct user label cleanup in the user label cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
DeviceInfoProvider allows the UserLabel list to be set per endpoint
examples/providers/DeviceInfoProviderImpl.cppstores current list size as one key, and all the entries for that endpoint as separate keysThe problems this causes are as follows:
examples/providers/DeviceInfoProviderImpl.cppdoes not delete or move any of the storage: all the storage is left behind.There is no way to delete any of the data on any of the endpoints. As soon as a userlabel is written, the key is persisted until the platform removes all storage.
Fixes DeviceInfoProvider leaks storage #21131
Change overview
Testing
How was this tested? (at least one bullet point required)
Build chip_tool and all-clusters-app
scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false && scripts/examples/gn_build_example.sh examples/chip-tool out/debug/standaloneRun TestUserLabelCluster yaml test
scripts/run_in_build_env.sh "./scripts/tests/run_test_suite.py --chip-tool ./out/debug/standalone/chip-tool --log-level debug --target TestUserLabelCluster run --iterations 1 --all-clusters-app ./out/debug/standalone/chip-all-clusters-app"