-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inet] Fix Get link local address for socket impl #21316
Merged
woody-apple
merged 2 commits into
project-chip:master
from
jepenven-silabs:fix_getlinklocal_socketimpl
Jul 28, 2022
Merged
[Inet] Fix Get link local address for socket impl #21316
woody-apple
merged 2 commits into
project-chip:master
from
jepenven-silabs:fix_getlinklocal_socketimpl
Jul 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
July 28, 2022 01:10
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 28, 2022 01:10
woody-apple
approved these changes
Jul 28, 2022
bzbarsky-apple
approved these changes
Jul 28, 2022
@jepenven-silabs what PR is this dependent on? |
PR #21316: Size comparison from 661cb82 to 138d93e Increases (2 builds for cc13x2_26x2, telink)
Decreases (2 builds for bl602, cc13x2_26x2)
Full report (29 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
|
turon
approved these changes
Jul 28, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Function return
CHIP_NO_ERROR
even if no link local address (fe80::) is present on the interfaceChange overview
return
INET_ERROR_ADDRESS_NOT_FOUND
if no link local address is foundTesting
Manual test on Ubuntu 20.04. Moreover I didn't find any references to this method in the SDK.