Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inet] Fix Get link local address for socket impl #21316

Merged

Conversation

jepenven-silabs
Copy link
Contributor

Problem

Function return CHIP_NO_ERROR even if no link local address (fe80::) is present on the interface

Change overview

return INET_ERROR_ADDRESS_NOT_FOUND if no link local address is found

Testing

Manual test on Ubuntu 20.04. Moreover I didn't find any references to this method in the SDK.

@woody-apple woody-apple enabled auto-merge (squash) July 28, 2022 02:34
@github-actions github-actions bot added the inet label Jul 28, 2022
@woody-apple
Copy link
Contributor

@jepenven-silabs what PR is this dependent on?

@github-actions
Copy link

PR #21316: Size comparison from 661cb82 to 138d93e

Increases (2 builds for cc13x2_26x2, telink)
platform target config section 661cb82 138d93e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668291 668299 8 0.0
.text 579780 579788 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799600 799608 8 0.0
text 567240 567242 2 0.0
Decreases (2 builds for bl602, cc13x2_26x2)
platform target config section 661cb82 138d93e change % change
bl602 lighting-app bl602 .text 1051628 1051624 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183076 183068 -8 -0.0
Full report (29 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
platform target config section 661cb82 138d93e change % change
bl602 lighting-app bl602 (read/write) 1381330 1381330 0 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051628 1051624 -4 -0.0
bl602+rpc (read/write) 1426746 1426746 0 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083292 1083292 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668291 668299 8 0.0
(read/write) 183076 183068 -8 -0.0
.bss 74260 74260 0 0.0
.data 3356 3356 0 0.0
.rodata 88195 88195 0 0.0
.text 579780 579788 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 633875 0 0.0
(read/write) 157828 157828 0 0.0
.bss 73556 73556 0 0.0
.data 3356 3356 0 0.0
.rodata 77411 77411 0 0.0
.text 556140 556140 0 0.0
lock-ftd LP_CC2652R7 (read only) 671447 671447 0 0.0
(read/write) 170112 170112 0 0.0
.bss 71340 71340 0 0.0
.data 3280 3280 0 0.0
.rodata 76263 76263 0 0.0
.text 594704 594704 0 0.0
lock-mtd LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 183692 183692 0 0.0
.bss 67028 67028 0 0.0
.data 3280 3280 0 0.0
.rodata 100875 100875 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 680743 680743 0 0.0
(read/write) 161648 161648 0 0.0
.bss 71404 71404 0 0.0
.data 3280 3280 0 0.0
.rodata 88863 88863 0 0.0
.text 591396 591396 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666479 666479 0 0.0
(read/write) 176048 176048 0 0.0
.bss 71540 71540 0 0.0
.data 3276 3276 0 0.0
.rodata 84679 84679 0 0.0
.text 581320 581320 0 0.0
shell LP_CC2652R7 (read only) 661006 661006 0 0.0
(read/write) 185880 185880 0 0.0
.bss 76580 76580 0 0.0
.data 3360 3360 0 0.0
.rodata 85166 85166 0 0.0
.text 575524 575524 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583206 0 0.0
.app_xip_area 460016 460016 0 0.0
.bss 65648 65648 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589126 589126 0 0.0
.app_xip_area 461208 461208 0 0.0
.bss 70376 70376 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588938 588938 0 0.0
.app_xip_area 466564 466564 0 0.0
.bss 64888 64888 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087832 1087832 0 0.0
.bss 133284 133284 0 0.0
.data 2048 2048 0 0.0
.text 952480 952480 0 0.0
window-app BRD4161A (read/write) 1081308 1081308 0 0.0
.bss 134756 134756 0 0.0
.data 2076 2076 0 0.0
.text 944452 944452 0 0.0
lighting-app BRD4161A+rpc (read/write) 1142124 1142124 0 0.0
.bss 149964 149964 0 0.0
.data 2260 2260 0 0.0
.text 989880 989880 0 0.0
BRD4161A+rs911x (read/write) 952488 952488 0 0.0
.bss 141000 141000 0 0.0
.data 2048 2048 0 0.0
.text 809420 809420 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128296 1128296 0 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981852 981852 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022462 1022462 0 0.0
(read/write) 1486274 1486274 0 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 215936 0 0.0
.flash.text 1022462 1022462 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076107 1076107 0 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246364 0 0.0
.flash.text 1070723 1070723 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642600 642600 0 0.0
.bss 69736 69736 0 0.0
.data 2028 2028 0 0.0
.text 568108 568108 0 0.0
lock k32w0+release (read/write) 699832 699832 0 0.0
.bss 70176 70176 0 0.0
.data 2036 2036 0 0.0
.text 624892 624892 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172691 0 0.0
bss 143140 143140 0 0.0
rodata 141828 141828 0 0.0
text 808808 808808 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152743 0 0.0
bss 142376 142376 0 0.0
rodata 133360 133360 0 0.0
text 798120 798120 0 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686700 1686700 0 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526528 1526528 0 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1630796 1630796 0 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471344 1471344 0 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552220 1552220 0 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401072 1401072 0 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589828 1589828 0 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434208 1434208 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799600 799608 8 0.0
bss 70816 70816 0 0.0
noinit 40416 40416 0 0.0
text 567240 567242 2 0.0
lighting-app tlsr9518adk80d (read/write) 819708 819708 0 0.0
bss 71660 71660 0 0.0
noinit 40416 40416 0 0.0
text 583810 583810 0 0.0

@woody-apple woody-apple merged commit b281903 into project-chip:master Jul 28, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants