-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the configuration for fabric handling into Matter's zcl.json #21273
Merged
woody-apple
merged 3 commits into
project-chip:master
from
tecimovic:add-fabric-handling-config-to-zcl-json
Jul 28, 2022
Merged
Move the configuration for fabric handling into Matter's zcl.json #21273
woody-apple
merged 3 commits into
project-chip:master
from
tecimovic:add-fabric-handling-config-to-zcl-json
Jul 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic was earlier hard-coded inside zap, this commit moves the logic to the zcl.json.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
July 27, 2022 13:15
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 27, 2022 13:15
PR #21273: Size comparison from 750eedf to d19bdbc Increases (7 builds for bl602, cc13x2_26x2, cyw30739, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 27, 2022
tcarmelveilleux
approved these changes
Jul 28, 2022
Damian-Nordic
approved these changes
Jul 28, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…oject-chip#21273) * Move the configuration for fabric handling into Matter's zcl.json This logic was earlier hard-coded inside zap, this commit moves the logic to the zcl.json. * Restyled by prettier-json * Same change to the extensions zcl.json file. Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This logic was earlier hard-coded inside zap, so all zap users picked up the Matter-only logic.
Change overview
This commit moves the control and configuration of the logic to the zcl.json. Note that this commit can be merged regardless of zap version. If zap doesn't get updated yet.