Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Disable SHA512 to save flash #21269

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

I noticed SHA-512 is by default compiled when building nRF Connect firmware although it is not required by Matter nor Thread.

Change overview

Disable SHA-512 to save some flash.

Testing

CI should catch missing function definitions, but also did smoke tests to verify the commissioning still works after this change.

@github-actions
Copy link

github-actions bot commented Jul 27, 2022

PR #21269: Size comparison from 750eedf to 8d7ec40

Increases (3 builds for bl602, cc13x2_26x2, cyw30739)
platform target config section 750eedf 8d7ec40 change % change
bl602 lighting-app bl602+rpc (read/write) 1426866 1426874 8 0.0
.text 1083188 1083192 4 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 666751 666759 8 0.0
.text 581264 581272 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583326 583334 8 0.0
.app_xip_area 460464 460472 8 0.0
Decreases (11 builds for cc13x2_26x2, nrfconnect)
platform target config section 750eedf 8d7ec40 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 175768 175760 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1172719 -4412 -0.4
rodata 142660 141936 -724 -0.5
text 812408 808732 -3676 -0.5
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1152771 -4412 -0.4
rodata 134192 133468 -724 -0.5
text 801716 798036 -3680 -0.5
lighting-app nrf52840dk_nrf52840 (read/write) 1168507 1164103 -4404 -0.4
rodata 124476 123752 -724 -0.6
text 820452 816776 -3676 -0.4
nrf52840dk_nrf52840+rpc (read/write) 1138623 1134231 -4392 -0.4
rodata 116016 115288 -728 -0.6
text 798212 794540 -3672 -0.5
nrf52840dongle_nrf52840 (read/write) 1075119 1070715 -4404 -0.4
rodata 93520 92796 -724 -0.8
text 748648 744972 -3676 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 1072014 1067642 -4372 -0.4
rodata 116892 116168 -724 -0.6
text 732996 729340 -3656 -0.5
lock-app nrf52840dk_nrf52840 (read/write) 1129191 1124783 -4408 -0.4
rodata 142360 141632 -728 -0.5
text 772452 768780 -3672 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 1033010 1028638 -4372 -0.4
rodata 134832 134108 -724 -0.5
text 685068 681412 -3656 -0.5
pump-app nrf52840dk_nrf52840 (read/write) 1080947 1076539 -4408 -0.4
rodata 117828 117100 -728 -0.6
text 749664 745988 -3676 -0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 1068727 1064323 -4404 -0.4
rodata 114584 113860 -724 -0.6
text 740956 737280 -3676 -0.5
Full report (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 750eedf 8d7ec40 change % change
bl602 lighting-app bl602 (read/write) 1381450 1381450 0 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051524 1051524 0 0.0
bl602+rpc (read/write) 1426866 1426874 8 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083192 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668427 0 0.0
(read/write) 182932 182932 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579700 579700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634019 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556060 0 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671567 0 0.0
(read/write) 169984 169984 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594624 0 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653795 0 0.0
(read/write) 183444 183444 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552152 0 0.0
pump-app LP_CC2652R7 (read only) 680999 680999 0 0.0
(read/write) 161384 161384 0 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591340 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666759 8 0.0
(read/write) 175768 175760 -8 -0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581264 581272 8 0.0
shell LP_CC2652R7 (read only) 660894 660894 0 0.0
(read/write) 185984 185984 0 0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583326 583334 8 0.0
.app_xip_area 460464 460472 8 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589254 0 0.0
.app_xip_area 461664 461664 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589082 0 0.0
.app_xip_area 467036 467036 0 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088160 0 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 952816 0 0.0
BRD4161A+rpc (read/write) 1142452 1142452 0 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990216 0 0.0
BRD4161A+rs911x (read/write) 952704 952704 0 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809644 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128256 0 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 981820 0 0.0
window-app BRD4161A (read/write) 1081636 1081636 0 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 944788 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022112 0 0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216264 0 0.0
.flash.text 1022112 1022112 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075771 0 0.0
(read/write) 488608 488608 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246668 0 0.0
.flash.text 1070387 1070387 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641776 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567292 0 0.0
lock k32w0+release (read/write) 699056 699056 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624124 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9835876 9835876 0 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467972 467972 0 0.0
.text 7785604 7785604 0 0.0
thermostat-no-ble arm64 (read only) 2342156 2342156 0 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139588 0 0.0
.text 1965520 1965520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449328 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1411972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1172719 -4412 -0.4
bss 143132 143132 0 0.0
rodata 142660 141936 -724 -0.5
text 812408 808732 -3676 -0.5
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1152771 -4412 -0.4
bss 142368 142368 0 0.0
rodata 134192 133468 -724 -0.5
text 801716 798036 -3680 -0.5
lighting-app nrf52840dk_nrf52840 (read/write) 1168507 1164103 -4404 -0.4
bss 144695 144695 0 0.0
rodata 124476 123752 -724 -0.6
text 820452 816776 -3676 -0.4
nrf52840dk_nrf52840+rpc (read/write) 1138623 1134231 -4392 -0.4
bss 145124 145124 0 0.0
rodata 116016 115288 -728 -0.6
text 798212 794540 -3672 -0.5
nrf52840dongle_nrf52840 (read/write) 1075119 1070715 -4404 -0.4
bss 151926 151926 0 0.0
rodata 93520 92796 -724 -0.8
text 748648 744972 -3676 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 1072014 1067642 -4372 -0.4
bss 141066 141066 0 0.0
rodata 116892 116168 -724 -0.6
text 732996 729340 -3656 -0.5
lock-app nrf52840dk_nrf52840 (read/write) 1129191 1124783 -4408 -0.4
bss 135663 135663 0 0.0
rodata 142360 141632 -728 -0.5
text 772452 768780 -3672 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 1033010 1028638 -4372 -0.4
bss 132066 132066 0 0.0
rodata 134832 134108 -724 -0.5
text 685068 681412 -3656 -0.5
pump-app nrf52840dk_nrf52840 (read/write) 1080947 1076539 -4408 -0.4
bss 134590 134590 0 0.0
rodata 117828 117100 -728 -0.6
text 749664 745988 -3676 -0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 1068727 1064323 -4404 -0.4
bss 134385 134385 0 0.0
rodata 114584 113860 -724 -0.6
text 740956 737280 -3676 -0.5
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687044 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526880 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631148 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471704 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551516 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400376 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589116 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433504 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799660 0 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567188 567188 0 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819760 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583758 583758 0 0.0

@woody-apple woody-apple merged commit aca4b94 into project-chip:master Jul 27, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants