-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to send required events for Door Lock app #21242
Add ability to send required events for Door Lock app #21242
Conversation
PR #21242: Size comparison from 79e8c9e to 2de4794 Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (5 builds for cc13x2_26x2, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use named pipe instead of signal to trigger the events, please refer to #21144 for more information.
We are moving from signal to named pipe because:
- We are running out of available signal to use
- signal can not carry more information other than event number itself
- we overwrite the default behaviors of signal which might cause problem in testing, such as ctrl+c can not terminate the program.
2de4794
to
68769c9
Compare
68769c9
to
5563eff
Compare
PR #21242: Size comparison from 750eedf to 5563eff Increases (20 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
5563eff
to
9bd5be2
Compare
PR #21242: Size comparison from e758eb2 to 9bd5be2 Increases (18 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (4 builds for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…Lock Jammed code and change the door state in the lock app
9bd5be2
to
86482cf
Compare
PR #21242: Size comparison from 0064643 to 86482cf Increases above 0.2%:
Increases (24 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
* [#19807] Add ability to trigger the door lock alarm with Lock Jammed code and change the door state in the lock app * [#19807] Restrict lock operation for disabled users (door lock) * [#19807] Support schedule-restricted users in the lock-app * Address code review feedback: move the lock-app to named pipe * Update auto-generated files
* [#19807] Add ability to trigger the door lock alarm with Lock Jammed code and change the door state in the lock app * [#19807] Restrict lock operation for disabled users (door lock) * [#19807] Support schedule-restricted users in the lock-app * Address code review feedback: move the lock-app to named pipe * Update auto-generated files Co-authored-by: Evgeniy Morozov <[email protected]>
…1242) * [project-chip#19807] Add ability to trigger the door lock alarm with Lock Jammed code and change the door state in the lock app * [project-chip#19807] Restrict lock operation for disabled users (door lock) * [project-chip#19807] Support schedule-restricted users in the lock-app * Address code review feedback: move the lock-app to named pipe * Update auto-generated files
Problem
Change overview
Testing
SetDoorState
command over the named pipe (see README.md) and verify that the door state change event is sent by Lock App.SendDoorLockAlarm
command over the named pipe (see README.md) and verify that the Door Lock Alarm event withLockJammed
type is sent by Lock App.LockOperationError
event is sent by Lock app: