-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Add MTROTAHeaderParser and use it in darwin-framework-tool #21235
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:BDX_UseMTROTAHeaderParser
Jul 27, 2022
Merged
[Darwin] Add MTROTAHeaderParser and use it in darwin-framework-tool #21235
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:BDX_UseMTROTAHeaderParser
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
July 26, 2022 16:34
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 26, 2022 16:34
krypton36
requested changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! One request made and then it is good to go.
PR #21235: Size comparison from d94cbdc to ec82bac Increases (5 builds for bl602, cyw30739, k32w, telink)
Decreases (1 build for esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 26, 2022
Closed
vivien-apple
force-pushed
the
BDX_UseMTROTAHeaderParser
branch
from
July 27, 2022 10:19
ec82bac
to
fbaf27d
Compare
vivien-apple
force-pushed
the
BDX_UseMTROTAHeaderParser
branch
from
July 27, 2022 10:22
fbaf27d
to
565ce7d
Compare
PR #21235: Size comparison from 750eedf to 565ce7d Increases (3 builds for bl602, cc13x2_26x2, cyw30739)
Decreases (1 build for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
approved these changes
Jul 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
…21235) * [Darwin] Add MTROTAHeaderParser * [darwin-framework-tool] Use MTROTAHeaderParser
woody-apple
added a commit
that referenced
this pull request
Jul 28, 2022
…21235) (#21293) * [Darwin] Add MTROTAHeaderParser * [darwin-framework-tool] Use MTROTAHeaderParser Co-authored-by: Vivien Nicolas <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…roject-chip#21235) * [Darwin] Add MTROTAHeaderParser * [darwin-framework-tool] Use MTROTAHeaderParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
darwin-framework-tool
is currently using the SDK directly, aka the C++ version.#fix #20804
Change overview
Testing
I have tested that it moving the code from
darwin-framework-tool
tosrc/darwin/Frameworl/CHIP/
does work.