Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the weak MatterGetAccessPrivilegeForXX functions and add stubs #21220

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Remove the weak MatterGetAccessPrivilegeForXX functions and add stubs #21220

merged 1 commit into from
Jul 28, 2022

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Jul 26, 2022

Problem

#19706
The MatterGetAccessPrivilegeForXX functions in src/app/RequiredPrivilege.cpp sometimes does not override the weak functions in src/app/RequiredPrivilege.cpp.

Change overview

Remove the weak functions and add stubs for tests:helper and chip-im-responder/initiator

Testing

CI

@wqx6
Remove weak MatterGetAccessPrivilegeForXX functions and add stubs for…
a2a3c08 
… test-helper and chip-im-responder/initiator
@wqx6 wqx6 mentioned this pull request Jul 26, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21220: Size comparison from c32f137 to a2a3c08

Increases (6 builds for bl602, cc13x2_26x2, cyw30739, telink)
platform target config section c32f137 a2a3c08 change % change
bl602 lighting-app bl602 (read/write) 1381754 1381762 8 0.0
.text 1051804 1051808 4 0.0
bl602+rpc (read/write) 1427162 1427170 8 0.0
.text 1083460 1083464 4 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 634383 634391 8 0.0
.text 556444 556452 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583634 583642 8 0.0
.app_xip_area 460772 460780 8 0.0
telink light-switch-app tlsr9518adk80d text 567492 567496 4 0.0
lighting-app tlsr9518adk80d text 584046 584048 2 0.0
Decreases (1 build for esp32)
platform target config section c32f137 a2a3c08 change % change
esp32 all-clusters-app c3devkit (read only) 1022416 1022414 -2 -0.0
.flash.text 1022416 1022414 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c32f137 a2a3c08 change % change
bl602 lighting-app bl602 (read/write) 1381754 1381762 8 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051804 1051808 4 0.0
bl602+rpc (read/write) 1427162 1427170 8 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083460 1083464 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668791 668791 0 0.0
(read/write) 182568 182568 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88391 88391 0 0.0
.text 580084 580084 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634383 634391 8 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77615 77615 0 0.0
.text 556444 556452 8 0.0
lock-ftd LP_CC2652R7 (read only) 671907 671907 0 0.0
(read/write) 169644 169644 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76475 76475 0 0.0
.text 594952 594952 0 0.0
lock-mtd LP_CC2652R7 (read only) 654167 654167 0 0.0
(read/write) 183072 183072 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552504 552504 0 0.0
pump-app LP_CC2652R7 (read only) 681579 681579 0 0.0
(read/write) 160804 160804 0 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89219 89219 0 0.0
.text 591876 591876 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667331 667331 0 0.0
(read/write) 175188 175188 0 0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85059 85059 0 0.0
.text 581792 581792 0 0.0
shell LP_CC2652R7 (read only) 661258 661258 0 0.0
(read/write) 185620 185620 0 0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85162 85162 0 0.0
.text 575780 575780 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583634 583642 8 0.0
.app_xip_area 460772 460780 8 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589554 589554 0 0.0
.app_xip_area 461964 461964 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589454 589454 0 0.0
.app_xip_area 467408 467408 0 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088680 1088680 0 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 953336 953336 0 0.0
BRD4161A+rpc (read/write) 1142980 1142980 0 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990744 990744 0 0.0
BRD4161A+rs911x (read/write) 953224 953224 0 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 810164 810164 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128668 1128668 0 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 982232 982232 0 0.0
window-app BRD4161A (read/write) 1082172 1082172 0 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 945324 945324 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022416 1022414 -2 -0.0
(read/write) 1486618 1486618 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216296 216296 0 0.0
.flash.text 1022416 1022414 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075959 1075959 0 0.0
(read/write) 488616 488616 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246676 246676 0 0.0
.flash.text 1070575 1070575 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641876 641876 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567392 567392 0 0.0
lock k32w0+release (read/write) 699180 699180 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624248 624248 0 0.0
linux all-clusters-app debug (read only) 2986169 2986169 0 0.0
(read/write) 155416 155416 0 0.0
.bss 61856 61856 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 267627 267627 0 0.0
.text 2540354 2540354 0 0.0
all-clusters-minimal-app debug (read only) 2829081 2829081 0 0.0
(read/write) 147120 147120 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 267659 267659 0 0.0
.text 2385842 2385842 0 0.0
bridge-app debug+rpc (read only) 2343497 2343497 0 0.0
(read/write) 127024 127024 0 0.0
.bss 50144 50144 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 200008 200008 0 0.0
.text 1981058 1981058 0 0.0
chip-tool debug (read only) 10384369 10384369 0 0.0
(read/write) 631056 631056 0 0.0
.bss 24824 24824 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596568 596568 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 531477 531477 0 0.0
.text 8401412 8401412 0 0.0
chip-tool-ipv6only arm64 (read only) 9808852 9808852 0 0.0
(read/write) 678561 678561 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623904 623904 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466244 466244 0 0.0
.text 7760404 7760404 0 0.0
lighting-app debug+rpc (read only) 2566601 2566601 0 0.0
(read/write) 129992 129992 0 0.0
.bss 49696 49696 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72328 72328 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 215728 215728 0 0.0
.text 2180354 2180354 0 0.0
lock-app debug (read only) 2531625 2531625 0 0.0
(read/write) 124976 124976 0 0.0
.bss 48096 48096 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69304 69304 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 230704 230704 0 0.0
.text 2135202 2135202 0 0.0
ota-provider-app debug (read only) 2335401 2335401 0 0.0
(read/write) 118776 118776 0 0.0
.bss 47744 47744 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63288 63288 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 205688 205688 0 0.0
.text 1966386 1966386 0 0.0
ota-requestor-app debug (read only) 2460809 2460809 0 0.0
(read/write) 126168 126168 0 0.0
.bss 50112 50112 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67960 67960 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209664 209664 0 0.0
.text 2079202 2079202 0 0.0
shell debug (read only) 2569825 2569825 0 0.0
(read/write) 141568 141568 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76888 76888 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 230034 230034 0 0.0
.text 2182114 2182114 0 0.0
thermostat-no-ble arm64 (read only) 2342092 2342092 0 0.0
(read/write) 141345 141345 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75624 75624 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139460 139460 0 0.0
.text 1965728 1965728 0 0.0
tv-app debug (read only) 3116649 3116649 0 0.0
(read/write) 257160 257160 0 0.0
.bss 167160 167160 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78824 78824 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 251400 251400 0 0.0
.text 2676706 2676706 0 0.0
tv-casting-app debug (read only) 5370969 5370969 0 0.0
(read/write) 158432 158432 0 0.0
.bss 51320 51320 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98384 98384 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 335521 335521 0 0.0
.text 4768802 4768802 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449472 2449472 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1412116 1412116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177675 1177675 0 0.0
bss 143132 143132 0 0.0
rodata 142692 142692 0 0.0
text 812924 812924 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157727 1157727 0 0.0
bss 142368 142368 0 0.0
rodata 134224 134224 0 0.0
text 802232 802232 0 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687524 1687524 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1527360 1527360 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631636 1631636 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1472192 1472192 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551708 1551708 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400568 1400568 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589300 1589300 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433688 1433688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799980 799980 0 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567492 567496 4 0.0
lighting-app tlsr9518adk80d (read/write) 820064 820064 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 584046 584048 2 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bzbarsky-apple bzbarsky-apple merged commit ae2ca6d into project-chip:master Jul 28, 2022
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
@wqx6 @web-flow
Remove weak MatterGetAccessPrivilegeForXX functions and add stubs for…
a2fd8e2 
… test-helper and chip-im-responder/initiator (#21220)
woody-apple added a commit that referenced this pull request Jul 29, 2022
@woody-apple @wqx6
Remove weak MatterGetAccessPrivilegeForXX functions and add stubs for…
079a65d 
… test-helper and chip-im-responder/initiator (#21220) (#21387)

Co-authored-by: Wang Qixiang <[email protected]>
@msandstedt msandstedt mentioned this pull request Aug 31, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@wqx6 @isiu-apple
Remove weak MatterGetAccessPrivilegeForXX functions and add stubs for…
f78dc37 
… test-helper and chip-im-responder/initiator (project-chip#21220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chshu chshu chshu approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wqx6 @chshu @bzbarsky-apple