Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webos]: Remove the unused platform implementation of DeviceInfoProvider #21170

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[webos]: Remove the unused platform implementation of DeviceInfoProvider #21170

merged 2 commits into from
Jul 26, 2022

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Jul 25, 2022 •
edited
Loading

Problem

What is being fixed? Examples:

  • Currently, only webos implemented the DeviceInfoProvider class on the platform side (src/platform/webos/DeviceInfoProviderImpl.cpp), but it is almost identical to the default one at examples/providers/DeviceInfoProviderImpl.cpp. From its comments, such as "In Linux Simulation", it looks like this is just the copy and paste from previous Linux implementation before we introduce the common implementation.

  • Its implementation is also always wrong on a real device, such as always place your device in bedroom2/North/2nd floor up"

  • Fixes We should not setup various provider within PlatformMgr on each platform  #17400

Change overview

Remove the unused platform implementation of DeviceInfoProvider

Testing

How was this tested? (at least one bullet point required)

  • Make sure all CI build pass to confirm this implementation is not in use currently.

@github-actions
Copy link

github-actions bot commented Jul 25, 2022 •
edited
Loading

PR #21170: Size comparison from be1d492 to 9dce95a

Increases (2 builds for efr32, esp32)
platform target config section be1d492 9dce95a change % change
efr32 lighting-app BRD4161A+rpc (read/write) 1141948 1141964 16 0.0
.text 989772 989788 16 0.0
esp32 all-clusters-app c3devkit (read only) 1022006 1022008 2 0.0
.flash.text 1022006 1022008 2 0.0
Decreases (1 build for telink)
platform target config section be1d492 9dce95a change % change
telink light-switch-app tlsr9518adk80d text 567214 567212 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section be1d492 9dce95a change % change
bl602 lighting-app bl602 (read/write) 1380786 1380786 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050916 1050916 0 0.0
bl602+rpc (read/write) 1426194 1426194 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082572 1082572 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668463 668463 0 0.0
(read/write) 182880 182880 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88367 88367 0 0.0
.text 579780 579780 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634063 634063 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77591 77591 0 0.0
.text 556148 556148 0 0.0
lock-ftd LP_CC2652R7 (read only) 671603 671603 0 0.0
(read/write) 169916 169916 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76451 76451 0 0.0
.text 594672 594672 0 0.0
lock-mtd LP_CC2652R7 (read only) 653847 653847 0 0.0
(read/write) 183360 183360 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101167 101167 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 681295 681295 0 0.0
(read/write) 161080 161080 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89207 89207 0 0.0
.text 591604 591604 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667039 667039 0 0.0
(read/write) 175456 175456 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 85039 85039 0 0.0
.text 581520 581520 0 0.0
shell LP_CC2652R7 (read only) 660954 660954 0 0.0
(read/write) 185892 185892 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85146 85146 0 0.0
.text 575492 575492 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583282 583282 0 0.0
.app_xip_area 460480 460480 0 0.0
.bss 65596 65596 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589182 589182 0 0.0
.app_xip_area 461652 461652 0 0.0
.bss 70324 70324 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 587734 587734 0 0.0
.app_xip_area 465780 465780 0 0.0
.bss 64804 64804 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087672 1087672 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952384 952384 0 0.0
BRD4161A+rpc (read/write) 1141948 1141964 16 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989772 989788 16 0.0
BRD4161A+rs911x (read/write) 952172 952172 0 0.0
.bss 140928 140928 0 0.0
.data 2048 2048 0 0.0
.text 809176 809176 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128424 1128424 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 982044 982044 0 0.0
window-app BRD4161A (read/write) 1081156 1081156 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944368 944368 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022006 1022008 2 0.0
(read/write) 1486538 1486538 0 0.0
.dram0.bss 70224 70224 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216280 216280 0 0.0
.flash.text 1022006 1022008 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075667 1075667 0 0.0
(read/write) 488544 488544 0 0.0
.dram0.bss 75744 75744 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 246660 0 0.0
.flash.text 1070283 1070283 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641520 641520 0 0.0
.bss 69696 69696 0 0.0
.data 2028 2028 0 0.0
.text 567068 567068 0 0.0
lock k32w0+release (read/write) 698880 698880 0 0.0
.bss 70144 70144 0 0.0
.data 2036 2036 0 0.0
.text 623972 623972 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9793012 9793012 0 0.0
(read/write) 680385 680385 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 625776 625776 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 458644 458644 0 0.0
.text 7747748 7747748 0 0.0
thermostat-no-ble arm64 (read only) 2341916 2341916 0 0.0
(read/write) 141249 141249 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75592 75592 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139572 139572 0 0.0
.text 1965536 1965536 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449240 2449240 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411884 1411884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177259 1177259 0 0.0
bss 143068 143068 0 0.0
rodata 142676 142676 0 0.0
text 812656 812656 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157311 1157311 0 0.0
bss 142304 142304 0 0.0
rodata 134208 134208 0 0.0
text 801968 801968 0 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686780 1686780 0 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526680 1526680 0 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630876 1630876 0 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471496 1471496 0 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550972 1550972 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399896 1399896 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588564 1588564 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1433016 1433016 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799620 799620 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567214 567212 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 819688 819688 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583752 583752 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) July 25, 2022 18:30
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21170: Size comparison from 2987329 to 8ac580b

Increases (1 build for cc13x2_26x2)
platform target config section 2987329 8ac580b change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 661250 661258 8 0.0
.text 575772 575780 8 0.0
Decreases (4 builds for cc13x2_26x2, esp32, nrfconnect)
platform target config section 2987329 8ac580b change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 634391 634383 -8 -0.0
.text 556452 556444 -8 -0.0
shell LP_CC2652R7 (read/write) 185628 185620 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1022416 1022414 -2 -0.0
.flash.text 1022416 1022414 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 802232 802228 -4 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2987329 8ac580b change % change
bl602 lighting-app bl602 (read/write) 1381762 1381762 0 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051808 1051808 0 0.0
bl602+rpc (read/write) 1427170 1427170 0 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083464 1083464 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668791 668791 0 0.0
(read/write) 182568 182568 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88391 88391 0 0.0
.text 580084 580084 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634391 634383 -8 -0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77615 77615 0 0.0
.text 556452 556444 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 671907 671907 0 0.0
(read/write) 169644 169644 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76475 76475 0 0.0
.text 594952 594952 0 0.0
lock-mtd LP_CC2652R7 (read only) 654167 654167 0 0.0
(read/write) 183072 183072 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552504 552504 0 0.0
pump-app LP_CC2652R7 (read only) 681579 681579 0 0.0
(read/write) 160804 160804 0 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89219 89219 0 0.0
.text 591876 591876 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667331 667331 0 0.0
(read/write) 175188 175188 0 0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85059 85059 0 0.0
.text 581792 581792 0 0.0
shell LP_CC2652R7 (read only) 661250 661258 8 0.0
(read/write) 185628 185620 -8 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85162 85162 0 0.0
.text 575772 575780 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583642 583642 0 0.0
.app_xip_area 460780 460780 0 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589554 589554 0 0.0
.app_xip_area 461964 461964 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588078 588078 0 0.0
.app_xip_area 466064 466064 0 0.0
.bss 64864 64864 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088680 1088680 0 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 953336 953336 0 0.0
BRD4161A+rpc (read/write) 1142980 1142980 0 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990744 990744 0 0.0
BRD4161A+rs911x (read/write) 953224 953224 0 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 810164 810164 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128668 1128668 0 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 982232 982232 0 0.0
window-app BRD4161A (read/write) 1082172 1082172 0 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 945324 945324 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022416 1022414 -2 -0.0
(read/write) 1486618 1486618 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216296 216296 0 0.0
.flash.text 1022416 1022414 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075959 1075959 0 0.0
(read/write) 488616 488616 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246676 246676 0 0.0
.flash.text 1070575 1070575 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641876 641876 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567392 567392 0 0.0
lock k32w0+release (read/write) 699180 699180 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624248 624248 0 0.0
linux all-clusters-app debug (read only) 2986169 2986169 0 0.0
(read/write) 155416 155416 0 0.0
.bss 61856 61856 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 267627 267627 0 0.0
.text 2540354 2540354 0 0.0
all-clusters-minimal-app debug (read only) 2829081 2829081 0 0.0
(read/write) 147120 147120 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 267659 267659 0 0.0
.text 2385842 2385842 0 0.0
bridge-app debug+rpc (read only) 2343497 2343497 0 0.0
(read/write) 127024 127024 0 0.0
.bss 50144 50144 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 200008 200008 0 0.0
.text 1981058 1981058 0 0.0
chip-tool debug (read only) 10384193 10384193 0 0.0
(read/write) 631056 631056 0 0.0
.bss 24824 24824 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596568 596568 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 531477 531477 0 0.0
.text 8401236 8401236 0 0.0
chip-tool-ipv6only arm64 (read only) 9808692 9808692 0 0.0
(read/write) 678561 678561 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623904 623904 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466244 466244 0 0.0
.text 7760244 7760244 0 0.0
lighting-app debug+rpc (read only) 2566601 2566601 0 0.0
(read/write) 129992 129992 0 0.0
.bss 49696 49696 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72328 72328 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 215728 215728 0 0.0
.text 2180354 2180354 0 0.0
lock-app debug (read only) 2531625 2531625 0 0.0
(read/write) 124976 124976 0 0.0
.bss 48096 48096 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69304 69304 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 230704 230704 0 0.0
.text 2135202 2135202 0 0.0
ota-provider-app debug (read only) 2335401 2335401 0 0.0
(read/write) 118776 118776 0 0.0
.bss 47744 47744 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63288 63288 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 205688 205688 0 0.0
.text 1966386 1966386 0 0.0
ota-requestor-app debug (read only) 2453601 2453601 0 0.0
(read/write) 125680 125680 0 0.0
.bss 50080 50080 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67512 67512 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 209248 209248 0 0.0
.text 2072626 2072626 0 0.0
shell debug (read only) 2569825 2569825 0 0.0
(read/write) 141568 141568 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76888 76888 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 230034 230034 0 0.0
.text 2182114 2182114 0 0.0
thermostat-no-ble arm64 (read only) 2342092 2342092 0 0.0
(read/write) 141345 141345 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75624 75624 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139460 139460 0 0.0
.text 1965728 1965728 0 0.0
tv-app debug (read only) 3116649 3116649 0 0.0
(read/write) 257160 257160 0 0.0
.bss 167160 167160 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78824 78824 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 251400 251400 0 0.0
.text 2676706 2676706 0 0.0
tv-casting-app debug (read only) 5370969 5370969 0 0.0
(read/write) 158432 158432 0 0.0
.bss 51320 51320 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98384 98384 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 335521 335521 0 0.0
.text 4768802 4768802 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449472 2449472 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1412116 1412116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177675 1177675 0 0.0
bss 143132 143132 0 0.0
rodata 142692 142692 0 0.0
text 812924 812924 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157727 1157727 0 0.0
bss 142368 142368 0 0.0
rodata 134224 134224 0 0.0
text 802232 802228 -4 -0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687524 1687524 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1527360 1527360 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631636 1631636 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1472192 1472192 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551708 1551708 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400568 1400568 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589300 1589300 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433688 1433688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799980 799980 0 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567494 567494 0 0.0
lighting-app tlsr9518adk80d (read/write) 820064 820064 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 584046 584046 0 0.0

@woody-apple woody-apple merged commit 925cff6 into project-chip:master Jul 26, 2022
github-actions bot pushed a commit that referenced this pull request Jul 26, 2022
@yufengwangca @web-flow
[webos]: Remove the unused platform implementation of DeviceInfoProvi…
90f2e1c 
…der (#21170)
woody-apple added a commit that referenced this pull request Jul 27, 2022
@woody-apple @yufengwangca
[webos]: Remove the unused platform implementation of DeviceInfoProvi…
8d7ab71 
…der (#21170) (#21222)

Co-authored-by: Yufeng Wang <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yufengwangca @isiu-apple
[webos]: Remove the unused platform implementation of DeviceInfoProvi…
e2620b6 
…der (project-chip#21170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should not setup various provider within PlatformMgr on each platform
3 participants
@yufengwangca @woody-apple @Damian-Nordic