Add #if CHIP_HAVE_CONFIG around *BuildConfig headers #21169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#if CHIP_HAVE_CONFIG_H\n\1\n#endif/g" {} +
Manually for a few instances of CHIPDeviceBuildConfig.h and
CHIPAdditionalDataPayloadBuildConfig.h
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
Maybe we should create <app/AppConfig.h> ? e.g. see src/lib/core/CHIPConfig.h |
mspang
approved these changes
Jul 25, 2022
|
PR #21169: Size comparison from be1d492 to 0c96370 Decreases (2 builds for telink)
Full report (14 builds for bl602, cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
Reverted #if CHIP_HAVE_CONFIG and replaced includes:
find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#include <app\/AppConfig\.h>/g" {} +
|
Thank you for the suggestion. Updated the change to reflect this. |
woody-apple
approved these changes
Jul 25, 2022
|
PR #21169: Size comparison from be1d492 to e826724 Increases (2 builds for efr32, esp32)
Decreases (3 builds for bl602, cyw30739, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
* Add #if CHIP_HAVE_CONFIG around *BuildConfig headers
find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#if CHIP_HAVE_CONFIG_H\n\1\n#endif/g" {} +
Manually for a few instances of CHIPDeviceBuildConfig.h and
CHIPAdditionalDataPayloadBuildConfig.h
* Add AppConfig.h and move build config check in there
Reverted #if CHIP_HAVE_CONFIG and replaced includes:
find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#include <app\/AppConfig\.h>/g" {} +
* Restyled by gn
Co-authored-by: Restyled.io <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 26, 2022
* Add #if CHIP_HAVE_CONFIG around *BuildConfig headers
find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#if CHIP_HAVE_CONFIG_H\n\1\n#endif/g" {} +
Manually for a few instances of CHIPDeviceBuildConfig.h and
CHIPAdditionalDataPayloadBuildConfig.h
* Add AppConfig.h and move build config check in there
Reverted #if CHIP_HAVE_CONFIG and replaced includes:
find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#include <app\/AppConfig\.h>/g" {} +
* Restyled by gn
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Daniel Nicoara <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
) * Add #if CHIP_HAVE_CONFIG around *BuildConfig headers find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#if CHIP_HAVE_CONFIG_H\n\1\n#endif/g" {} + Manually for a few instances of CHIPDeviceBuildConfig.h and CHIPAdditionalDataPayloadBuildConfig.h * Add AppConfig.h and move build config check in there Reverted #if CHIP_HAVE_CONFIG and replaced includes: find ./ -name "*.h" -o -name "*.cpp" -exec sed -i "s/\(#include <app\/AppBuildConfig\.h>\)/#include <app\/AppConfig\.h>/g" {} + * Restyled by gn Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find ./ -name ".h" -o -name ".cpp" -exec sed -i "s/(#include <app/AppBuildConfig.h>)/#if CHIP_HAVE_CONFIG_H\n\1\n#endif/g" {} +
Manually for a few instances of CHIPDeviceBuildConfig.h and
CHIPAdditionalDataPayloadBuildConfig.h