[Ameba] Implement light-switch-app, matter shell and add binding to apps #21153

pankore · 2022-07-25T10:18:06Z

Problem

Binding functionality is missing in Ameba apps.
Shell is not implemented for Ameba.
No light-switch-app.
Outdated readme.

Change overview

Implement matter shell for Ameba.
Implement Ameba light-switch-app.
Added shell and BindingHandler to all-clusters-app, light-switch-app.
Cleanup cmake files.
Update readme.

Testing

Tested matter shell commands.
Tested binding commands

- Implement ameba matter shell - Add BindingHandler

- Also removed unnecessary macros from chip_main.cmake of all the apps

- all-clusters-app - lighting-app - light-switch-app - ota-requestor-app

github-actions · 2022-07-25T10:45:58Z

PR #21153: Size comparison from 2557f51 to bfd1144

Increases (1 build for cc13x2_26x2)

platform	target	config	section	`2557f51`	`bfd1144`	change	% change
cc13x2_26x2	all-clusters-minimal-app	LP_CC2652R7	(read only)	634055	634063	8	0.0
			.text	556140	556148	8	0.0

Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`2557f51`	`bfd1144`	change
bl602	lighting-app	bl602	(read/write)	`1380786`	`1380786`	0
			.bss	117474	117474	0
			.data	4480	4480	0
			.text	1050916	1050916	0
		bl602+rpc	(read/write)	1426194	1426194	0
			.bss	124922	124922	0
			.data	4600	4600	0
			.text	`1082572`	`1082572`	0
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	668463	668463	0
			(read/write)	182880	182880	0
			.bss	74236	74236	0
			.data	3356	3356	0
			.rodata	88367	88367	0
			.text	579780	579780	0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	634055	634063	8
			(read/write)	157804	157804	0
			.bss	73532	73532	0
			.data	3356	3356	0
			.rodata	77591	77591	0
			.text	556140	556148	8
	lock-ftd	LP_CC2652R7	(read only)	671603	671603	0
			(read/write)	169916	169916	0
			.bss	71300	71300	0
			.data	3280	3280	0
			.rodata	76451	76451	0
			.text	594672	594672	0
	lock-mtd	LP_CC2652R7	(read only)	653847	653847	0
			(read/write)	183360	183360	0
			.bss	66988	66988	0
			.data	3280	3280	0
			.rodata	101167	101167	0
			.text	552200	552200	0
	pump-app	LP_CC2652R7	(read only)	681295	681295	0
			(read/write)	161080	161080	0
			.bss	71388	71388	0
			.data	3280	3280	0
			.rodata	89207	89207	0
			.text	591604	591604	0
	pump-controller-app	LP_CC2652R7	(read only)	667039	667039	0
			(read/write)	175456	175456	0
			.bss	71508	71508	0
			.data	3276	3276	0
			.rodata	85039	85039	0
			.text	581520	581520	0
	shell	LP_CC2652R7	(read only)	660954	660954	0
			(read/write)	185892	185892	0
			.bss	76540	76540	0
			.data	3360	3360	0
			.rodata	85146	85146	0
			.text	575492	575492	0
cyw30739	light	cyw930739m2evb_01	(read/write)	582042	582042	0
			.app_xip_area	460432	460432	0
			.bss	64404	64404	0
			.data	716	716	0
			.rodata	0	0	0
			.text	112	112	0
	lock	cyw930739m2evb_01	(read/write)	587942	587942	0
			.app_xip_area	461604	461604	0
			.bss	69132	69132	0
			.data	720	720	0
			.rodata	0	0	0
			.text	112	112	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	586494	586494	0
			.app_xip_area	465732	465732	0
			.bss	63612	63612	0
			.data	660	660	0
			.rodata	0	0	0
			.text	112	112	0
efr32	lighting-app	BRD4161A	(read/write)	1087672	1087672	0
			.bss	133220	133220	0
			.data	2048	2048	0
			.text	952384	952384	0
		BRD4161A+rpc	(read/write)	1141964	1141964	0
			.bss	149892	149892	0
			.data	2260	2260	0
			.text	989788	989788	0
		BRD4161A+rs911x	(read/write)	952172	952172	0
			.bss	140928	140928	0
			.data	2048	2048	0
			.text	809176	809176	0
	lock-app	BRD4161A+wf200	(read/write)	1128424	1128424	0
			.bss	144304	144304	0
			.data	2056	2056	0
			.text	982044	982044	0
	window-app	BRD4161A	(read/write)	1081156	1081156	0
			.bss	134692	134692	0
			.data	2076	2076	0
			.text	944368	944368	0
esp32	all-clusters-app	c3devkit	(read only)	1022010	1022010	0
			(read/write)	1486554	1486554	0
			.dram0.bss	70232	70232	0
			.dram0.data	14600	14600	0
			.flash.rodata	216280	216280	0
			.flash.text	1022010	1022010	0
			.iram0.text	62902	62902	0
		m5stack	(read only)	1075799	1075799	0
			(read/write)	488552	488552	0
			.dram0.bss	75752	75752	0
			.dram0.data	34144	34144	0
			.flash.rodata	246660	246660	0
			.flash.text	1070415	1070415	0
			.iram0.text	123267	123267	0
k32w	light	k32w0+release	(read/write)	641520	641520	0
			.bss	69696	69696	0
			.data	2028	2028	0
			.text	567068	567068	0
	lock	k32w0+release	(read/write)	698880	698880	0
			.bss	70144	70144	0
			.data	2036	2036	0
			.text	623972	623972	0
linux	chip-tool-ipv6only	arm64	(read only)	9793452	9793452	0
			(read/write)	680401	680401	0
			.bss	32833	32833	0
			.data	3272	3272	0
			.data.rel.ro	625776	625776	0
			.dynamic	560	560	0
			.got	13560	13560	0
			.init	24	24	0
			.init_array	192	192	0
			.rodata	458556	458556	0
			.text	7748244	7748244	0
	thermostat-no-ble	arm64	(read only)	2341916	2341916	0
			(read/write)	141249	141249	0
			.bss	55233	55233	0
			.data	1672	1672	0
			.data.rel.ro	75592	75592	0
			.dynamic	560	560	0
			.got	4984	4984	0
			.init	24	24	0
			.init_array	400	400	0
			.rodata	139572	139572	0
			.text	1965536	1965536	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2449240	2449240	0
			.bss	214444	214444	0
			.data	5872	5872	0
			.text	`1411884`	`1411884`	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1177259	1177259	0
			bss	143068	143068	0
			rodata	142676	142676	0
			text	812656	812656	0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1157311	1157311	0
			bss	142304	142304	0
			rodata	134208	134208	0
			text	801968	801968	0
p6	all-clusters-app	default	(read only)	881632	881632	0
			(read/write)	`1686780`	`1686780`	0
			.bss	149064	149064	0
			.data	2648	2648	0
			.text	1526680	1526680	0
	all-clusters-minimal-app	default	(read only)	882352	882352	0
			(read/write)	`1630876`	`1630876`	0
			.bss	148344	148344	0
			.data	2648	2648	0
			.text	1471496	1471496	0
	light-app	default	(read only)	890656	890656	0
			(read/write)	1550972	1550972	0
			.bss	140248	140248	0
			.data	2440	2440	0
			.text	1399896	1399896	0
	lock-app	default	(read only)	886184	886184	0
			(read/write)	`1588564`	`1588564`	0
			.bss	144704	144704	0
			.data	2456	2456	0
			.text	`1433016`	`1433016`	0
telink	light-switch-app	tlsr9518adk80d	(read/write)	799620	799620	0
			bss	70744	70744	0
			noinit	40416	40416	0
			text	567212	567212	0
	lighting-app	tlsr9518adk80d	(read/write)	819688	819688	0
			bss	71588	71588	0
			noinit	40416	40416	0
			text	583752	583752	0

- Compile BindingHandler even when matter_enable_shell is disabled

…pps (#21153) * [Bind] Add binding cluster to ameba all-clusters-app - Implement ameba matter shell - Add BindingHandler * [Switch] Implement ameba light-switch-app - Also removed unnecessary macros from chip_main.cmake of all the apps * [README] Update README for Ameba examples - all-clusters-app - lighting-app - light-switch-app - ota-requestor-app * Restyled by clang-format * Restyled by gn * Restyled by prettier-markdown * Restyled by prettier-markdown * [Build] Fix compile error - Compile BindingHandler even when matter_enable_shell is disabled * [README] Fix mispelled word Co-authored-by: Restyled.io <[email protected]>

…pps (#21153) (#21303) * [Bind] Add binding cluster to ameba all-clusters-app - Implement ameba matter shell - Add BindingHandler * [Switch] Implement ameba light-switch-app - Also removed unnecessary macros from chip_main.cmake of all the apps * [README] Update README for Ameba examples - all-clusters-app - lighting-app - light-switch-app - ota-requestor-app * Restyled by clang-format * Restyled by gn * Restyled by prettier-markdown * Restyled by prettier-markdown * [Build] Fix compile error - Compile BindingHandler even when matter_enable_shell is disabled * [README] Fix mispelled word Co-authored-by: Restyled.io <[email protected]> Co-authored-by: pankore <[email protected]> Co-authored-by: Restyled.io <[email protected]>

…pps (project-chip#21153) * [Bind] Add binding cluster to ameba all-clusters-app - Implement ameba matter shell - Add BindingHandler * [Switch] Implement ameba light-switch-app - Also removed unnecessary macros from chip_main.cmake of all the apps * [README] Update README for Ameba examples - all-clusters-app - lighting-app - light-switch-app - ota-requestor-app * Restyled by clang-format * Restyled by gn * Restyled by prettier-markdown * Restyled by prettier-markdown * [Build] Fix compile error - Compile BindingHandler even when matter_enable_shell is disabled * [README] Fix mispelled word Co-authored-by: Restyled.io <[email protected]>

pankore and others added 4 commits July 23, 2022 05:24

[Bind] Add binding cluster to ameba all-clusters-app

dcf02a9

- Implement ameba matter shell - Add BindingHandler

[Switch] Implement ameba light-switch-app

856494f

- Also removed unnecessary macros from chip_main.cmake of all the apps

[README] Update README for Ameba examples

cd9a860

- all-clusters-app - lighting-app - light-switch-app - ota-requestor-app

Restyled by clang-format

87b4f43

pullapprove bot requested review from tehampson, turon, vijs, vivien-apple, wbschiller, woody-apple, xylophone21, yufengwangca and yunhanw-google July 25, 2022 10:18

Restyled by gn

2171366

pullapprove bot added the review - pending label Jul 25, 2022

github-actions bot added config examples lib platform shell labels Jul 25, 2022

Restyled by prettier-markdown

4b2f479

restyled-io bot mentioned this pull request Jul 25, 2022

Restyle [Ameba] Implement light-switch-app, matter shell and add binding to apps #21154

Closed

Restyled by prettier-markdown

bfd1144

woody-apple enabled auto-merge (squash) July 25, 2022 18:35

woody-apple added the fast track label Jul 25, 2022

[Build] Fix compile error

aafb403

- Compile BindingHandler even when matter_enable_shell is disabled

auto-merge was automatically disabled July 26, 2022 01:42
Head branch was pushed to by a user without write access

[README] Fix mispelled word

1d27303

woody-apple merged commit 6a3c36c into project-chip:master Jul 27, 2022

pankore deleted the binding-cluster branch September 15, 2022 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ameba] Implement light-switch-app, matter shell and add binding to apps #21153

[Ameba] Implement light-switch-app, matter shell and add binding to apps #21153

pankore commented Jul 25, 2022

github-actions bot commented Jul 25, 2022 •

edited

Loading

[Ameba] Implement light-switch-app, matter shell and add binding to apps #21153

[Ameba] Implement light-switch-app, matter shell and add binding to apps #21153

Conversation

pankore commented Jul 25, 2022

Problem

Change overview

Testing

github-actions bot commented Jul 25, 2022 • edited Loading

github-actions bot commented Jul 25, 2022 •

edited

Loading