Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdns: set authoritative bit for mDNS replies #21108

Merged
merged 1 commit into from
Jul 25, 2022
Merged

mdns: set authoritative bit for mDNS replies #21108

merged 1 commit into from
Jul 25, 2022

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jul 22, 2022 •
edited
Loading

Problem

According to RFC 6762 the AA bit must be set in multicast messages. The minimal mDNS implementation does not follow the spec.

Change overview

Always set the AA flags in minimal mDNS. This bit is harmless and is also always set in avahi.

The PR also fixes the wrong truncated flag value.

Testing

Manually tested with wireshark sniffing.

@github-actions github-actions bot added the lib label Jul 22, 2022
@github-actions
Copy link

github-actions bot commented Jul 22, 2022 •
edited
Loading

PR #21108: Size comparison from 0e08265 to 563f15f

Increases (23 builds for bl602, cc13x2_26x2, efr32, esp32, linux, p6)
platform target config section 0e08265 563f15f change % change
bl602 lighting-app bl602 (read/write) 1380794 1380802 8 0.0
.text 1050932 1050936 4 0.0
bl602+rpc (read/write) 1426202 1426210 8 0.0
.text 1082588 1082592 4 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 169932 169940 8 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 972716 972732 16 0.0
.text 808984 809000 16 0.0
esp32 all-clusters-app c3devkit (read only) 1021928 1021932 4 0.0
.flash.text 1021928 1021932 4 0.0
m5stack (read only) 1075691 1075695 4 0.0
.flash.text 1070307 1070311 4 0.0
linux all-clusters-app debug (read only) 2981177 2981225 48 0.0
.text 2537298 2537346 48 0.0
all-clusters-minimal-app debug (read only) 2827073 2827105 32 0.0
.text 2385010 2385042 32 0.0
bridge-app debug+rpc (read only) 2341777 2341825 48 0.0
.text 1980226 1980274 48 0.0
chip-tool debug (read only) 10349249 10349297 48 0.0
.text 8373844 8373892 48 0.0
chip-tool-ipv6only arm64 (read only) 9778876 9778924 48 0.0
.text 7736900 7736948 48 0.0
lighting-app debug+rpc (read only) 2564897 2564945 48 0.0
.text 2179602 2179650 48 0.0
lock-app debug (read only) 2529921 2529969 48 0.0
.text 2134386 2134434 48 0.0
ota-provider-app debug (read only) 2333505 2333553 48 0.0
.text 1965570 1965618 48 0.0
ota-requestor-app debug (read only) 2451961 2452009 48 0.0
.text 2071906 2071954 48 0.0
shell debug (read only) 2567785 2567833 48 0.0
.text 2181186 2181234 48 0.0
thermostat-no-ble arm64 (read only) 2341532 2341580 48 0.0
.text 1965248 1965296 48 0.0
tv-app debug (read only) 3115553 3115601 48 0.0
.text 2676690 2676738 48 0.0
tv-casting-app debug (read only) 5369265 5369313 48 0.0
.text 4768114 4768162 48 0.0
p6 all-clusters-app default (read/write) 1686436 1686452 16 0.0
.text 1526336 1526352 16 0.0
all-clusters-minimal-app default (read/write) 1630540 1630572 32 0.0
.text 1471160 1471192 32 0.0
light-app default (read/write) 1550780 1550812 32 0.0
.text 1399704 1399736 32 0.0
lock-app default (read/write) 1588372 1588404 32 0.0
.text 1432824 1432856 32 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 0e08265 563f15f change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 671587 671579 -8 -0.0
.text 594664 594656 -8 -0.0
telink lighting-app tlsr9518adk80d text 583732 583730 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e08265 563f15f change % change
bl602 lighting-app bl602 (read/write) 1380794 1380802 8 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050932 1050936 4 0.0
bl602+rpc (read/write) 1426202 1426210 8 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082592 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668383 668383 0 0.0
(read/write) 182960 182960 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88327 88327 0 0.0
.text 579740 579740 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633983 633983 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 556108 556108 0 0.0
lock-ftd LP_CC2652R7 (read only) 671587 671579 -8 -0.0
(read/write) 169932 169940 8 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594664 594656 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 653871 653871 0 0.0
(read/write) 183336 183336 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552208 552208 0 0.0
pump-app LP_CC2652R7 (read only) 681087 681087 0 0.0
(read/write) 161288 161288 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89039 89039 0 0.0
.text 591564 591564 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666863 666863 0 0.0
(read/write) 175632 175632 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84895 84895 0 0.0
.text 581488 581488 0 0.0
shell LP_CC2652R7 (read only) 660858 660858 0 0.0
(read/write) 185988 185988 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85098 85098 0 0.0
.text 575444 575444 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582082 582082 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587998 587998 0 0.0
.app_xip_area 461660 461660 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 586286 586286 0 0.0
.app_xip_area 465524 465524 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087488 1087488 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952200 952200 0 0.0
BRD4161A+rpc (read/write) 1141780 1141780 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989604 989604 0 0.0
BRD4161A+rs911x (read/write) 972716 972732 16 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808984 809000 16 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128224 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981844 981844 0 0.0
window-app BRD4161A (read/write) 1080980 1080980 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944192 944192 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021928 1021932 4 0.0
(read/write) 1486290 1486290 0 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216016 216016 0 0.0
.flash.text 1021928 1021932 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075691 1075695 4 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246420 246420 0 0.0
.flash.text 1070307 1070311 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660816 660816 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583356 583356 0 0.0
lock k32w061+release (read/write) 687820 687820 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609876 609876 0 0.0
linux all-clusters-app debug (read only) 2981177 2981225 48 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265739 265739 0 0.0
.text 2537298 2537346 48 0.0
all-clusters-minimal-app debug (read only) 2827073 2827105 32 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266603 0 0.0
.text 2385010 2385042 32 0.0
bridge-app debug+rpc (read only) 2341777 2341825 48 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199240 199240 0 0.0
.text 1980226 1980274 48 0.0
chip-tool debug (read only) 10349249 10349297 48 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521813 521813 0 0.0
.text 8373844 8373892 48 0.0
chip-tool-ipv6only arm64 (read only) 9778876 9778924 48 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457580 457580 0 0.0
.text 7736900 7736948 48 0.0
lighting-app debug+rpc (read only) 2564897 2564945 48 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214896 214896 0 0.0
.text 2179602 2179650 48 0.0
lock-app debug (read only) 2529921 2529969 48 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 229936 0 0.0
.text 2134386 2134434 48 0.0
ota-provider-app debug (read only) 2333505 2333553 48 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204728 0 0.0
.text 1965570 1965618 48 0.0
ota-requestor-app debug (read only) 2451961 2452009 48 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208448 0 0.0
.text 2071906 2071954 48 0.0
shell debug (read only) 2567785 2567833 48 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229042 229042 0 0.0
.text 2181186 2181234 48 0.0
thermostat-no-ble arm64 (read only) 2341532 2341580 48 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139444 139444 0 0.0
.text 1965248 1965296 48 0.0
tv-app debug (read only) 3115553 3115601 48 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250440 250440 0 0.0
.text 2676690 2676738 48 0.0
tv-casting-app debug (read only) 5369265 5369313 48 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334625 334625 0 0.0
.text 4768114 4768162 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449032 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176927 1176927 0 0.0
bss 143068 143068 0 0.0
rodata 142440 142440 0 0.0
text 812548 812548 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156979 1156979 0 0.0
bss 142304 142304 0 0.0
rodata 133972 133972 0 0.0
text 801864 801864 0 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686436 1686452 16 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526336 1526352 16 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630540 1630572 32 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471160 1471192 32 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550780 1550812 32 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399704 1399736 32 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588372 1588404 32 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432824 1432856 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799468 799468 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567186 567186 0 0.0
lighting-app tlsr9518adk80d (read/write) 819516 819516 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583732 583730 -2 -0.0

@gjc13
mdns: set authoritative bit for mDNS replies
ef91d96 
According to RFC 6762 this bit must be set in multicast messages and is
harmless in unicast messages. The PR also fixes the wrong truncated flag
value.
@gjc13 gjc13 force-pushed the minmdns-reply-aa branch from 563f15f to ef91d96 Compare July 25, 2022 04:14
@github-actions
Copy link

github-actions bot commented Jul 25, 2022 •
edited
Loading

PR #21108: Size comparison from 2557f51 to ef91d96

Increases (13 builds for bl602, cc13x2_26x2, efr32, esp32, linux, p6, telink)
platform target config section 2557f51 ef91d96 change % change
bl602 lighting-app bl602+rpc (read/write) 1426194 1426202 8 0.0
.text 1082572 1082576 4 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 634055 634063 8 0.0
.text 556140 556148 8 0.0
shell LP_CC2652R7 (read/write) 185892 185900 8 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 952172 952188 16 0.0
.text 809176 809192 16 0.0
esp32 all-clusters-app c3devkit (read only) 1022010 1022016 6 0.0
.flash.text 1022010 1022016 6 0.0
m5stack (read only) 1075799 1075803 4 0.0
.flash.text 1070415 1070419 4 0.0
linux chip-tool-ipv6only arm64 (read only) 9793452 9793484 32 0.0
.text 7748244 7748276 32 0.0
thermostat-no-ble arm64 (read only) 2341916 2341964 48 0.0
.text 1965536 1965584 48 0.0
p6 all-clusters-app default (read/write) 1686780 1686812 32 0.0
.text 1526680 1526712 32 0.0
all-clusters-minimal-app default (read/write) 1630876 1630908 32 0.0
.text 1471496 1471528 32 0.0
light-app default (read/write) 1550972 1551004 32 0.0
.text 1399896 1399928 32 0.0
lock-app default (read/write) 1588564 1588596 32 0.0
.text 1433016 1433048 32 0.0
telink light-switch-app tlsr9518adk80d text 567212 567214 2 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 2557f51 ef91d96 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 660954 660946 -8 -0.0
.text 575492 575484 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2557f51 ef91d96 change % change
bl602 lighting-app bl602 (read/write) 1380786 1380786 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050916 1050916 0 0.0
bl602+rpc (read/write) 1426194 1426202 8 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082572 1082576 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668463 668463 0 0.0
(read/write) 182880 182880 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88367 88367 0 0.0
.text 579780 579780 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634055 634063 8 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77591 77591 0 0.0
.text 556140 556148 8 0.0
lock-ftd LP_CC2652R7 (read only) 671603 671603 0 0.0
(read/write) 169916 169916 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76451 76451 0 0.0
.text 594672 594672 0 0.0
lock-mtd LP_CC2652R7 (read only) 653847 653847 0 0.0
(read/write) 183360 183360 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101167 101167 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 681295 681295 0 0.0
(read/write) 161080 161080 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89207 89207 0 0.0
.text 591604 591604 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667039 667039 0 0.0
(read/write) 175456 175456 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 85039 85039 0 0.0
.text 581520 581520 0 0.0
shell LP_CC2652R7 (read only) 660954 660946 -8 -0.0
(read/write) 185892 185900 8 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85146 85146 0 0.0
.text 575492 575484 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582042 582042 0 0.0
.app_xip_area 460432 460432 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587942 587942 0 0.0
.app_xip_area 461604 461604 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 586494 586494 0 0.0
.app_xip_area 465732 465732 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087672 1087672 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952384 952384 0 0.0
BRD4161A+rpc (read/write) 1141964 1141964 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989788 989788 0 0.0
BRD4161A+rs911x (read/write) 952172 952188 16 0.0
.bss 140928 140928 0 0.0
.data 2048 2048 0 0.0
.text 809176 809192 16 0.0
lock-app BRD4161A+wf200 (read/write) 1128424 1128424 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 982044 982044 0 0.0
window-app BRD4161A (read/write) 1081156 1081156 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944368 944368 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022010 1022016 6 0.0
(read/write) 1486554 1486554 0 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216280 216280 0 0.0
.flash.text 1022010 1022016 6 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075799 1075803 4 0.0
(read/write) 488552 488552 0 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 246660 0 0.0
.flash.text 1070415 1070419 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641520 641520 0 0.0
.bss 69696 69696 0 0.0
.data 2028 2028 0 0.0
.text 567068 567068 0 0.0
lock k32w0+release (read/write) 698880 698880 0 0.0
.bss 70144 70144 0 0.0
.data 2036 2036 0 0.0
.text 623972 623972 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9793452 9793484 32 0.0
(read/write) 680401 680401 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 625776 625776 0 0.0
.dynamic 560 560 0 0.0
.got 13560 13560 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 458556 458556 0 0.0
.text 7748244 7748276 32 0.0
thermostat-no-ble arm64 (read only) 2341916 2341964 48 0.0
(read/write) 141249 141249 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75592 75592 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139572 139572 0 0.0
.text 1965536 1965584 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449240 2449240 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411884 1411884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177259 1177259 0 0.0
bss 143068 143068 0 0.0
rodata 142676 142676 0 0.0
text 812656 812656 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157311 1157311 0 0.0
bss 142304 142304 0 0.0
rodata 134208 134208 0 0.0
text 801968 801968 0 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686780 1686812 32 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526680 1526712 32 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630876 1630908 32 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471496 1471528 32 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550972 1551004 32 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399896 1399928 32 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588564 1588596 32 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1433016 1433048 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799620 799620 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567212 567214 2 0.0
lighting-app tlsr9518adk80d (read/write) 819688 819688 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583752 583752 0 0.0

@woody-apple woody-apple added the spec Mismatch between spec and implementation label Jul 25, 2022
@pullapprove pullapprove bot added review - approved and removed spec Mismatch between spec and implementation review - pending labels Jul 25, 2022
@woody-apple woody-apple merged commit c2b060b into project-chip:master Jul 25, 2022
@woody-apple woody-apple added the spec Mismatch between spec and implementation label Jul 25, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@gjc13 @isiu-apple
mdns: set authoritative bit for mDNS replies (project-chip#21108)
de442aa 
According to RFC 6762 this bit must be set in multicast messages and is
harmless in unicast messages. The PR also fixes the wrong truncated flag
value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjc13 @andy31415 @woody-apple