Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telink]: Update every image to 0.5.89 #21104

Merged

Conversation

s07641069
Copy link
Contributor

@s07641069 s07641069 commented Jul 22, 2022

Problem

Telink adaptation for using docker image 0.5.88 with Zephyr v3.1.99 (see 21102 and log_strdup).

Change overview

Use docker image 0.5.89

Testing

Tested manually with chip-tool.
Steps:

Run: $ chip-tool pairing ble-thread <...>
Wait till success
Run: $ chip-tool accesscontrol write acl <...>
Wait till success
Run: $ chip-tool binding write binding <...>
Wait till success
Press manually switch button
Check if end device perform command

@github-actions
Copy link

github-actions bot commented Jul 22, 2022

PR #21104: Size comparison from c3e71f2 to 2c6db1b

Increases (1 build for cyw30739)
platform target config section c3e71f2 2c6db1b change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 587990 587998 8 0.0
.app_xip_area 461652 461660 8 0.0
Full report (5 builds for bl602, cyw30739)
platform target config section c3e71f2 2c6db1b change % change
bl602 lighting-app bl602 (read/write) 1380794 1380794 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050932 1050932 0 0.0
bl602+rpc (read/write) 1426202 1426202 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082588 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582082 582082 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587990 587998 8 0.0
.app_xip_area 461652 461660 8 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 586286 586286 0 0.0
.app_xip_area 465524 465524 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0

@s07641069
Copy link
Contributor Author

Blocked by 21102

@andy31415
Copy link
Contributor

Building 0.5.88 now, however I believe K32W has some issues on vscode image compilation so we may need .89 version as a fix.

@s07641069 s07641069 force-pushed the telink_update_docker_0.5.88 branch from 2c6db1b to 2583392 Compare July 22, 2022 16:24
@s07641069 s07641069 changed the title [Telink]: Update every image to 0.5.88 [Telink]: Update every image to 0.5.89 Jul 22, 2022
@s07641069 s07641069 force-pushed the telink_update_docker_0.5.88 branch from 2583392 to 6f82c5b Compare July 22, 2022 17:28
@github-actions
Copy link

github-actions bot commented Jul 22, 2022

PR #21104: Size comparison from 9b2c889 to af070f1

Increases above 0.2%:

platform target config section 9b2c889 af070f1 change % change
telink light-switch-app tlsr9518adk80d (read/write) 799620 804484 4864 0.6
noinit 40416 43488 3072 7.6
lighting-app tlsr9518adk80d (read/write) 819668 824556 4888 0.6
noinit 40416 43488 3072 7.6
Increases (6 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 9b2c889 af070f1 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 633975 633983 8 0.0
.text 556092 556100 8 0.0
nrfconnect lighting-app nrf5340dk_nrf5340_cpuapp (read/write) 1072010 1072026 16 0.0
text 733060 733064 4 0.0
lock-app nrf52840dk_nrf52840 text 772520 772524 4 0.0
nrf5340dk_nrf5340_cpuapp text 685132 685136 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799620 804484 4864 0.6
bss 70744 70912 168 0.2
noinit 40416 43488 3072 7.6
text 567212 568506 1294 0.2
lighting-app tlsr9518adk80d (read/write) 819668 824556 4888 0.6
bss 71588 71756 168 0.2
noinit 40416 43488 3072 7.6
text 583756 585076 1320 0.2
Decreases (2 builds for esp32, nrfconnect)
platform target config section 9b2c889 af070f1 change % change
esp32 all-clusters-app c3devkit (read only) 1021958 1021956 -2 -0.0
.flash.text 1021958 1021956 -2 -0.0
nrfconnect pump-controller-app nrf52840dk_nrf52840 text 741212 741208 -4 -0.0
Full report (51 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9b2c889 af070f1 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380794 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050944 1050944 0 0.0
bl602+rpc (read/write) 1426202 1426202 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082600 1082600 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668383 668383 0 0.0
(read/write) 182960 182960 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88335 88335 0 0.0
.text 579732 579732 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633975 633983 8 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77559 77559 0 0.0
.text 556092 556100 8 0.0
lock-ftd LP_CC2652R7 (read only) 671603 671603 0 0.0
(read/write) 169916 169916 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76451 76451 0 0.0
.text 594672 594672 0 0.0
lock-mtd LP_CC2652R7 (read only) 653847 653847 0 0.0
(read/write) 183360 183360 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101167 101167 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 681271 681271 0 0.0
(read/write) 161104 161104 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89183 89183 0 0.0
.text 591604 591604 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667039 667039 0 0.0
(read/write) 175456 175456 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 85039 85039 0 0.0
.text 581520 581520 0 0.0
shell LP_CC2652R7 (read only) 660866 660866 0 0.0
(read/write) 185980 185980 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85106 85106 0 0.0
.text 575444 575444 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582042 582042 0 0.0
.app_xip_area 460432 460432 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587942 587942 0 0.0
.app_xip_area 461604 461604 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 586494 586494 0 0.0
.app_xip_area 465732 465732 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087680 1087680 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952392 952392 0 0.0
BRD4161A+rpc (read/write) 1141972 1141972 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989796 989796 0 0.0
BRD4161A+rs911x (read/write) 972916 972916 0 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 809184 809184 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128424 1128424 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 982044 982044 0 0.0
window-app BRD4161A (read/write) 1081156 1081156 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944368 944368 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021958 1021956 -2 -0.0
(read/write) 1486434 1486434 0 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216160 216160 0 0.0
.flash.text 1021958 1021956 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075723 1075723 0 0.0
(read/write) 488448 488448 0 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246556 246556 0 0.0
.flash.text 1070339 1070339 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641520 641520 0 0.0
.bss 69696 69696 0 0.0
.data 2028 2028 0 0.0
.text 567068 567068 0 0.0
lock k32w0+release (read/write) 698880 698880 0 0.0
.bss 70144 70144 0 0.0
.data 2036 2036 0 0.0
.text 623972 623972 0 0.0
linux all-clusters-app debug (read only) 2981689 2981689 0 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265867 265867 0 0.0
.text 2537682 2537682 0 0.0
all-clusters-minimal-app debug (read only) 2827585 2827585 0 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266731 266731 0 0.0
.text 2385394 2385394 0 0.0
bridge-app debug+rpc (read only) 2342289 2342289 0 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199368 199368 0 0.0
.text 1980610 1980610 0 0.0
chip-tool debug (read only) 10349889 10349889 0 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 522005 522005 0 0.0
.text 8374292 8374292 0 0.0
chip-tool-ipv6only arm64 (read only) 9779324 9779324 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457724 457724 0 0.0
.text 7737204 7737204 0 0.0
lighting-app debug+rpc (read only) 2565441 2565441 0 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 215056 215056 0 0.0
.text 2179986 2179986 0 0.0
lock-app debug (read only) 2530433 2530433 0 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 230064 230064 0 0.0
.text 2134770 2134770 0 0.0
ota-provider-app debug (read only) 2334081 2334081 0 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204920 204920 0 0.0
.text 1965954 1965954 0 0.0
ota-requestor-app debug (read only) 2452505 2452505 0 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208608 208608 0 0.0
.text 2072290 2072290 0 0.0
shell debug (read only) 2568297 2568297 0 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229170 229170 0 0.0
.text 2181570 2181570 0 0.0
thermostat-no-ble arm64 (read only) 2341916 2341916 0 0.0
(read/write) 141249 141249 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75592 75592 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139572 139572 0 0.0
.text 1965536 1965536 0 0.0
tv-app debug (read only) 3116033 3116033 0 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250568 250568 0 0.0
.text 2677042 2677042 0 0.0
tv-casting-app debug (read only) 5369777 5369777 0 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334753 334753 0 0.0
.text 4768498 4768498 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449240 2449240 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411884 1411884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177091 1177091 0 0.0
bss 143068 143068 0 0.0
rodata 142572 142572 0 0.0
text 812588 812588 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157143 1157143 0 0.0
bss 142304 142304 0 0.0
rodata 134104 134104 0 0.0
text 801900 801900 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1168439 1168439 0 0.0
bss 144631 144631 0 0.0
rodata 124472 124472 0 0.0
text 820520 820520 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1138699 1138699 0 0.0
bss 145060 145060 0 0.0
rodata 116012 116012 0 0.0
text 798284 798284 0 0.0
nrf52840dongle_nrf52840 (read/write) 1074931 1074931 0 0.0
bss 151862 151862 0 0.0
rodata 93492 93492 0 0.0
text 748496 748496 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1072010 1072026 16 0.0
bss 141002 141002 0 0.0
rodata 116888 116888 0 0.0
text 733060 733064 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1129271 1129271 0 0.0
bss 135599 135599 0 0.0
rodata 142376 142376 0 0.0
text 772520 772524 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1033030 1033030 0 0.0
bss 132002 132002 0 0.0
rodata 134852 134852 0 0.0
text 685132 685136 4 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1081051 1081051 0 0.0
bss 134526 134526 0 0.0
rodata 117820 117820 0 0.0
text 749916 749916 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1069003 1069003 0 0.0
bss 134321 134321 0 0.0
rodata 114604 114604 0 0.0
text 741212 741208 -4 -0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686628 1686628 0 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526528 1526528 0 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630732 1630732 0 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471352 1471352 0 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550972 1550972 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399896 1399896 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588564 1588564 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1433016 1433016 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799620 804484 4864 0.6
bss 70744 70912 168 0.2
noinit 40416 43488 3072 7.6
text 567212 568506 1294 0.2
lighting-app tlsr9518adk80d (read/write) 819668 824556 4888 0.6
bss 71588 71756 168 0.2
noinit 40416 43488 3072 7.6
text 583756 585076 1320 0.2

@s07641069
Copy link
Contributor Author

s07641069 commented Jul 25, 2022

Hi @andy31415 and @Damian-Nordic
Could you process this pull request ?

@woody-apple
Copy link
Contributor

@s07641069 Sorry, can you please update this? Looks like this has conflicted with main.

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@s07641069 s07641069 force-pushed the telink_update_docker_0.5.88 branch from af070f1 to b8d09dc Compare July 27, 2022 16:39
@s07641069
Copy link
Contributor Author

Needs rebase

@woody-apple rebase done

@s07641069
Copy link
Contributor Author

Needs rebase

@woody-apple rebase done and tests passed. In case If new rebase needed due to new commit - let me know. Thx!

@s07641069 s07641069 requested a review from woody-apple July 28, 2022 10:19
@s07641069
Copy link
Contributor Author

Hi @woody-apple
Could you process this pull request ?

@Damian-Nordic Damian-Nordic merged commit 59edd2f into project-chip:master Jul 29, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
* [Telink]: Update every image to 0.5.88

* [Telink]: Update every image to 0.5.89
@s07641069 s07641069 deleted the telink_update_docker_0.5.88 branch October 31, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants