Move CommandSender/Handler and WriteClient/Handler over to ExchangeHolder
#21081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
but safer, ExchangeHolder way of EC management.
mrjerryjohns
force-pushed
the
more-exchange-holder
branch
from
5f854f2 to
eb7a6e4
Compare
|
PR #21081: Size comparison from b263270 to eb7a6e4 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (11 builds for cc13x2_26x2, linux, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
approved these changes
Jul 21, 2022
mrjerryjohns
commented
Jul 22, 2022
|
PR #21081: Size comparison from b263270 to fbde0de Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (12 builds for cc13x2_26x2, linux, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 25, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
…older` (#21081) * Move CommandSender/Handler and WriteClient/Handler over to using the new but safer, ExchangeHolder way of EC management. * Update src/app/CommandHandler.h
woody-apple
added a commit
that referenced
this pull request
Jul 26, 2022
…older` (#21081) (#21189) * Move CommandSender/Handler and WriteClient/Handler over to using the new but safer, ExchangeHolder way of EC management. * Update src/app/CommandHandler.h Co-authored-by: Jerry Johns <[email protected]>
This was referenced Aug 3, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…older` (project-chip#21081) * Move CommandSender/Handler and WriteClient/Handler over to using the new but safer, ExchangeHolder way of EC management. * Update src/app/CommandHandler.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the last 4 objects in the IM space over to the new but safer
ExchangeHolderway of EC management. This removes a fair bit of the custom EC logic that existed and cleans up the state in the file.Testing:
Ran the existing unit tests as well as relying on CI to run a bunch of Python and YAML tests to validate behavior.