Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve discovery logging a bit. #21079

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Improve discovery logging a bit. #21079

merged 1 commit into from
Jul 21, 2022

Conversation

woody-apple
Copy link
Contributor

  1. In shared "platform" discovery code, log when we discovered an operational id
    or a commissionable instance and what the TXT records were.
  2. In Darwin code, do Discovery, not DeviceLayer logging and improve some of the
    log messages.

The intent is to make it a little clearer on failure where in the pipeline
things stop propagating information.

Problem

Can't tell whether we never got "all" addresses or whether consumer just ignored the result.

Change overview

Log when we plan to notify the consumer.

Testing

Ran chip-tool, saw the updated logs.

@bzbarsky-apple @web-flow
Improve discovery logging a bit. (#21056)
5f36d2c 
1) In shared "platform" discovery code, log when we discovered an operational id
   or a commissionable instance and what the TXT records were.
2) In Darwin code, do Discovery, not DeviceLayer logging and improve some of the
   log messages.

The intent is to make it a little clearer on failure where in the pipeline
things stop propagating information.
@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21079: Size comparison from c03e213 to 5f36d2c

Increases above 0.2%:

platform target config section c03e213 5f36d2c change % change
cc13x2_26x2 pump-app LP_CC2652R7 .rodata 88811 89039 228 0.3
pump-controller-app LP_CC2652R7 .rodata 84667 84895 228 0.3
Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, telink)
platform target config section c03e213 5f36d2c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668151 668183 32 0.0
.text 579524 579556 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633759 633791 32 0.0
.text 555884 555916 32 0.0
lock-ftd LP_CC2652R7 (read only) 671251 671291 40 0.0
.text 594328 594368 40 0.0
lock-mtd LP_CC2652R7 (read only) 653535 653575 40 0.0
.text 551872 551912 40 0.0
pump-app LP_CC2652R7 (read only) 680267 680775 508 0.1
.rodata 88811 89039 228 0.3
.text 590972 591252 280 0.0
pump-controller-app LP_CC2652R7 (read only) 666043 666551 508 0.1
.rodata 84667 84895 228 0.3
.text 580896 581176 280 0.0
shell LP_CC2652R7 (read only) 660626 660666 40 0.0
.text 575220 575260 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581746 581778 32 0.0
.app_xip_area 460280 460312 32 0.0
lock cyw930739m2evb_01 (read/write) 587646 587678 32 0.0
.app_xip_area 461452 461484 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585118 585974 856 0.1
.app_xip_area 464500 465356 856 0.2
efr32 lighting-app BRD4161A (read/write) 1086680 1087424 744 0.1
.text 951392 952136 744 0.1
BRD4161A+rpc (read/write) 1141004 1141748 744 0.1
.text 988828 989572 744 0.1
window-app BRD4161A (read/write) 1080156 1080900 744 0.1
.text 943368 944112 744 0.1
esp32 all-clusters-app c3devkit (read only) 1022024 1022026 2 0.0
.flash.text 1022024 1022026 2 0.0
k32w light k32w061+release (read/write) 660464 660496 32 0.0
.text 583004 583036 32 0.0
lock k32w061+release (read/write) 687468 687500 32 0.0
.text 609524 609556 32 0.0
linux chip-tool debug (read only) 10350497 10350657 160 0.0
.rodata 521525 521621 96 0.0
.text 8375380 8375444 64 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9774188 80 0.0
.rodata 457340 457372 32 0.0
.text 7732372 7732420 48 0.0
tv-casting-app debug (read only) 5368473 5368569 96 0.0
.rodata 334561 334593 32 0.0
.text 4767410 4767474 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176415 1176947 532 0.0
rodata 142200 142428 228 0.2
text 812280 812580 300 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156479 1157011 532 0.0
rodata 133744 133972 228 0.2
text 801592 801892 300 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798796 799404 608 0.1
text 566766 567128 362 0.1
lighting-app tlsr9518adk80d (read/write) 818844 819452 608 0.1
text 583308 583670 362 0.1
Decreases (6 builds for cc13x2_26x2)
platform target config section c03e213 5f36d2c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183192 183160 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 170268 170228 -40 -0.0
lock-mtd LP_CC2652R7 (read/write) 183672 183632 -40 -0.0
pump-app LP_CC2652R7 (read/write) 162108 161600 -508 -0.3
pump-controller-app LP_CC2652R7 (read/write) 176452 175944 -508 -0.3
shell LP_CC2652R7 (read/write) 186220 186180 -40 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c03e213 5f36d2c change % change
bl602 lighting-app bl602 (read/write) 1380538 1380538 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050676 1050676 0 0.0
bl602+rpc (read/write) 1425978 1425978 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082360 1082360 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668151 668183 32 0.0
(read/write) 183192 183160 -32 -0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88311 0 0.0
.text 579524 579556 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633759 633791 32 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555884 555916 32 0.0
lock-ftd LP_CC2652R7 (read only) 671251 671291 40 0.0
(read/write) 170268 170228 -40 -0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594328 594368 40 0.0
lock-mtd LP_CC2652R7 (read only) 653535 653575 40 0.0
(read/write) 183672 183632 -40 -0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 551872 551912 40 0.0
pump-app LP_CC2652R7 (read only) 680267 680775 508 0.1
(read/write) 162108 161600 -508 -0.3
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 89039 228 0.3
.text 590972 591252 280 0.0
pump-controller-app LP_CC2652R7 (read only) 666043 666551 508 0.1
(read/write) 176452 175944 -508 -0.3
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84895 228 0.3
.text 580896 581176 280 0.0
shell LP_CC2652R7 (read only) 660626 660666 40 0.0
(read/write) 186220 186180 -40 -0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575220 575260 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581746 581778 32 0.0
.app_xip_area 460280 460312 32 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587646 587678 32 0.0
.app_xip_area 461452 461484 32 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585118 585974 856 0.1
.app_xip_area 464500 465356 856 0.2
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086680 1087424 744 0.1
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951392 952136 744 0.1
BRD4161A+rpc (read/write) 1141004 1141748 744 0.1
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988828 989572 744 0.1
BRD4161A+rs911x (read/write) 972604 972604 0 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808872 808872 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1127960 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981580 981580 0 0.0
window-app BRD4161A (read/write) 1080156 1080900 744 0.1
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943368 944112 744 0.1
esp32 all-clusters-app c3devkit (read only) 1022024 1022026 2 0.0
(read/write) 1486282 1486282 0 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216008 0 0.0
.flash.text 1022024 1022026 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075743 1075743 0 0.0
(read/write) 488304 488304 0 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070359 1070359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660464 660496 32 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583004 583036 32 0.0
lock k32w061+release (read/write) 687468 687500 32 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609524 609556 32 0.0
linux all-clusters-app debug (read only) 2980481 2980481 0 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265707 265707 0 0.0
.text 2536658 2536658 0 0.0
all-clusters-minimal-app debug (read only) 2826433 2826433 0 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266603 0 0.0
.text 2384370 2384370 0 0.0
bridge-app debug+rpc (read only) 2341065 2341065 0 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199208 199208 0 0.0
.text 1979570 1979570 0 0.0
chip-tool debug (read only) 10350497 10350657 160 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521525 521621 96 0.0
.text 8375380 8375444 64 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9774188 80 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457372 32 0.0
.text 7732372 7732420 48 0.0
lighting-app debug+rpc (read only) 2564289 2564289 0 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214832 214832 0 0.0
.text 2179058 2179058 0 0.0
lock-app debug (read only) 2529281 2529281 0 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 229936 0 0.0
.text 2133746 2133746 0 0.0
ota-provider-app debug (read only) 2332865 2332865 0 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204728 0 0.0
.text 1964930 1964930 0 0.0
ota-requestor-app debug (read only) 2451321 2451321 0 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208448 0 0.0
.text 2071266 2071266 0 0.0
shell debug (read only) 2567105 2567105 0 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229010 229010 0 0.0
.text 2180562 2180562 0 0.0
thermostat-no-ble arm64 (read only) 2340996 2340996 0 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139420 0 0.0
.text 1964768 1964768 0 0.0
tv-app debug (read only) 3114857 3114857 0 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250408 250408 0 0.0
.text 2676050 2676050 0 0.0
tv-casting-app debug (read only) 5368473 5368569 96 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334561 334593 32 0.0
.text 4767410 4767474 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448968 2448968 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411612 1411612 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176415 1176947 532 0.0
bss 143068 143068 0 0.0
rodata 142200 142428 228 0.2
text 812280 812580 300 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156479 1157011 532 0.0
bss 142304 142304 0 0.0
rodata 133744 133972 228 0.2
text 801592 801892 300 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686556 1686556 0 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526456 1526456 0 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630684 1630684 0 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471304 1471304 0 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550716 1550716 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399640 1399640 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588308 1588308 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432760 1432760 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798796 799404 608 0.1
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566766 567128 362 0.1
lighting-app tlsr9518adk80d (read/write) 818844 819452 608 0.1
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583308 583670 362 0.1

@woody-apple woody-apple merged commit a4bad86 into sve Jul 21, 2022
@woody-apple woody-apple deleted the cherry-pick-4ce818ebb9a65d395838ab563854240f70950113 branch July 21, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @bzbarsky-apple