Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric scoped commands in idl generation #21050

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Fabric scoped commands in idl generation #21050

merged 2 commits into from
Jul 21, 2022

Conversation

andy31415
Copy link
Contributor

Problem

#21022 added fabric scope command to xml and codegen.
Would like to see this data in more human-friendly format as well as make use of it if needed in codegen based on idl (java codegen does this)

Change overview

Minimal change for if fabric scoped add "fabric" tag to the command

Testing

Visual inspection, change is trivial.
Ran ./scripts/idl/matter_idl_parser.py examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter and a few other files to test that parsing succeeds.

@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21050: Size comparison from 6d54807 to c5fbefa

Increases (1 build for esp32)
platform target config section 6d54807 c5fbefa change % change
esp32 all-clusters-app c3devkit (read only) 1021960 1021964 4 0.0
.flash.text 1021960 1021964 4 0.0
Decreases (2 builds for telink)
platform target config section 6d54807 c5fbefa change % change
telink light-switch-app tlsr9518adk80d (read/write) 798860 798852 -8 -0.0
text 566826 566822 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818908 818900 -8 -0.0
text 583370 583368 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6d54807 c5fbefa change % change
bl602 lighting-app bl602 (read/write) 1380914 1380914 0 0.0
.bss 117482 117482 0 0.0
.data 4480 4480 0 0.0
.text 1051032 1051032 0 0.0
bl602+rpc (read/write) 1426322 1426322 0 0.0
.bss 124930 124930 0 0.0
.data 4600 4600 0 0.0
.text 1082688 1082688 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668327 0 0.0
(read/write) 183016 183016 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88311 0 0.0
.text 579700 579700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633943 633943 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 556068 556068 0 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671555 0 0.0
(read/write) 169964 169964 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594632 594632 0 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653839 0 0.0
(read/write) 183368 183368 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552176 552176 0 0.0
pump-app LP_CC2652R7 (read only) 680579 680579 0 0.0
(read/write) 161796 161796 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 591284 591284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666355 0 0.0
(read/write) 176140 176140 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84667 0 0.0
.text 581208 581208 0 0.0
shell LP_CC2652R7 (read only) 660810 660810 0 0.0
(read/write) 186036 186036 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582050 0 0.0
.app_xip_area 460440 460440 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 587966 0 0.0
.app_xip_area 461628 461628 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585430 0 0.0
.app_xip_area 464668 464668 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086760 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951472 0 0.0
BRD4161A+rpc (read/write) 1141036 1141036 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 988860 0 0.0
BRD4161A+rs911x (read/write) 972876 972876 0 0.0
.bss 161672 161672 0 0.0
.data 2048 2048 0 0.0
.text 809136 809136 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128248 1128248 0 0.0
.bss 144312 144312 0 0.0
.data 2056 2056 0 0.0
.text 981860 981860 0 0.0
window-app BRD4161A (read/write) 1080236 1080236 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943448 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021960 1021964 4 0.0
(read/write) 1486298 1486298 0 0.0
.dram0.bss 70248 70248 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216008 0 0.0
.flash.text 1021960 1021964 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075743 1075743 0 0.0
(read/write) 488320 488320 0 0.0
.dram0.bss 75768 75768 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070359 1070359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660784 660784 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583324 583324 0 0.0
lock k32w061+release (read/write) 687788 687788 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609844 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9774108 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457340 0 0.0
.text 7732372 7732372 0 0.0
thermostat-no-ble arm64 (read only) 2341508 2341508 0 0.0
(read/write) 141297 141297 0 0.0
.bss 55265 55265 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139420 0 0.0
.text 1965280 1965280 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449032 0 0.0
.bss 214460 214460 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176383 0 0.0
bss 143068 143068 0 0.0
rodata 142200 142200 0 0.0
text 812248 812248 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156447 0 0.0
bss 142304 142304 0 0.0
rodata 133744 133744 0 0.0
text 801564 801564 0 0.0
p6 all-clusters-app default (read only) 881616 881616 0 0.0
(read/write) 1686652 1686652 0 0.0
.bss 149080 149080 0 0.0
.data 2648 2648 0 0.0
.text 1526536 1526536 0 0.0
all-clusters-minimal-app default (read only) 882336 882336 0 0.0
(read/write) 1630780 1630780 0 0.0
.bss 148360 148360 0 0.0
.data 2648 2648 0 0.0
.text 1471384 1471384 0 0.0
light-app default (read only) 890640 890640 0 0.0
(read/write) 1551004 1551004 0 0.0
.bss 140264 140264 0 0.0
.data 2440 2440 0 0.0
.text 1399912 1399912 0 0.0
lock-app default (read only) 886168 886168 0 0.0
(read/write) 1588596 1588596 0 0.0
.bss 144720 144720 0 0.0
.data 2456 2456 0 0.0
.text 1433032 1433032 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798860 798852 -8 -0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566826 566822 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818908 818900 -8 -0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583370 583368 -2 -0.0

@andy31415 andy31415 merged commit 33aecf8 into project-chip:master Jul 21, 2022
github-actions bot pushed a commit that referenced this pull request Jul 21, 2022
@andy31415 @web-flow
Fabric scoped commands in idl generation (#21050)
daf743c 
* Detect fabric-scoped commands and flag them in matter idl

* zap regen
woody-apple added a commit that referenced this pull request Jul 21, 2022
@woody-apple @andy31415
Fabric scoped commands in idl generation (#21050) (#21053)
a8b89c5 
* Detect fabric-scoped commands and flag them in matter idl

* zap regen

Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@andy31415 @isiu-apple
Fabric scoped commands in idl generation (project-chip#21050)
879521f 
* Detect fabric-scoped commands and flag them in matter idl

* zap regen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @tcarmelveilleux @bzbarsky-apple