Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark fabric-scoped commands in the XML and use that in codegen. #21047

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Mark fabric-scoped commands in the XML and use that in codegen. #21047

merged 1 commit into from
Jul 21, 2022

Conversation

woody-apple
Copy link
Contributor

Fixes #20811

Problem

Hardcoding which commands are fabric-scoped. This does not allow non-standard things to be fabric-scoped.

Change overview

Use XML data for this instead.

Testing

Looked at generated code.

@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21047: Size comparison from d24168c to 2d36a53

Increases (31 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section d24168c 2d36a53 change % change
bl602 lighting-app bl602 (read/write) 1379506 1379538 32 0.0
.text 1050148 1050176 28 0.0
bl602+rpc (read/write) 1424946 1424970 24 0.0
.text 1081836 1081860 24 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667919 667927 8 0.0
.text 579284 579292 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633511 633527 16 0.0
.text 555636 555652 16 0.0
lock-ftd LP_CC2652R7 (read only) 671011 671019 8 0.0
.text 594088 594096 8 0.0
lock-mtd LP_CC2652R7 (read only) 653295 653311 16 0.0
.text 551624 551640 16 0.0
pump-app LP_CC2652R7 (read only) 680019 680027 8 0.0
.text 590724 590732 8 0.0
pump-controller-app LP_CC2652R7 (read only) 665795 665803 8 0.0
.text 580640 580648 8 0.0
shell LP_CC2652R7 (read only) 660386 660394 8 0.0
.text 574980 574988 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581330 581354 24 0.0
.app_xip_area 460024 460048 24 0.0
lock cyw930739m2evb_01 (read/write) 587246 587254 8 0.0
.app_xip_area 461212 461220 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584694 584702 8 0.0
.app_xip_area 464236 464244 8 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1085952 16 0.0
.text 950808 950824 16 0.0
BRD4161A+rpc (read/write) 1140260 1140276 16 0.0
.text 988244 988260 16 0.0
BRD4161A+rs911x (read/write) 972052 972068 16 0.0
.text 808472 808488 16 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127576 16 0.0
.text 981332 981348 16 0.0
window-app BRD4161A (read/write) 1079428 1079444 16 0.0
.text 942800 942816 16 0.0
esp32 all-clusters-app c3devkit (read only) 1021768 1021784 16 0.0
.flash.text 1021768 1021784 16 0.0
m5stack (read only) 1075515 1075539 24 0.0
.flash.text 1070131 1070155 24 0.0
k32w light k32w061+release (read/write) 660104 660120 16 0.0
.text 582772 582788 16 0.0
lock k32w061+release (read/write) 687084 687100 16 0.0
.text 609268 609284 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9771188 9773148 1960 0.0
.rodata 456884 457196 312 0.1
.text 7730084 7731732 1648 0.0
thermostat-no-ble arm64 (read only) 2338060 2340036 1976 0.1
.rodata 138964 139276 312 0.2
.text 1962448 1964112 1664 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176051 16 0.0
text 812024 812036 12 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156115 16 0.0
text 801336 801348 12 0.0
p6 all-clusters-app default (read/write) 1685700 1685716 16 0.0
.text 1526096 1526112 16 0.0
all-clusters-minimal-app default (read/write) 1629828 1629844 16 0.0
.text 1470944 1470960 16 0.0
light-app default (read/write) 1549828 1549844 16 0.0
.text 1399248 1399264 16 0.0
lock-app default (read/write) 1587420 1587436 16 0.0
.text 1432368 1432384 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798388 798412 24 0.0
text 566528 566550 22 0.0
lighting-app tlsr9518adk80d (read/write) 818436 818460 24 0.0
text 583072 583094 22 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section d24168c 2d36a53 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183328 183320 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 170412 170404 -8 -0.0
lock-mtd LP_CC2652R7 (read/write) 183816 183800 -16 -0.0
pump-app LP_CC2652R7 (read/write) 162260 162252 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 176604 176596 -8 -0.0
shell LP_CC2652R7 (read/write) 186364 186356 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d24168c 2d36a53 change % change
bl602 lighting-app bl602 (read/write) 1379506 1379538 32 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050148 1050176 28 0.0
bl602+rpc (read/write) 1424946 1424970 24 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081836 1081860 24 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667919 667927 8 0.0
(read/write) 183328 183320 -8 -0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579284 579292 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633511 633527 16 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555636 555652 16 0.0
lock-ftd LP_CC2652R7 (read only) 671011 671019 8 0.0
(read/write) 170412 170404 -8 -0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594088 594096 8 0.0
lock-mtd LP_CC2652R7 (read only) 653295 653311 16 0.0
(read/write) 183816 183800 -16 -0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551624 551640 16 0.0
pump-app LP_CC2652R7 (read only) 680019 680027 8 0.0
(read/write) 162260 162252 -8 -0.0
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590724 590732 8 0.0
pump-controller-app LP_CC2652R7 (read only) 665795 665803 8 0.0
(read/write) 176604 176596 -8 -0.0
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580640 580648 8 0.0
shell LP_CC2652R7 (read only) 660386 660394 8 0.0
(read/write) 186364 186356 -8 -0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 574980 574988 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581330 581354 24 0.0
.app_xip_area 460024 460048 24 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587246 587254 8 0.0
.app_xip_area 461212 461220 8 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584694 584702 8 0.0
.app_xip_area 464236 464244 8 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1085952 16 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950808 950824 16 0.0
BRD4161A+rpc (read/write) 1140260 1140276 16 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988244 988260 16 0.0
BRD4161A+rs911x (read/write) 972052 972068 16 0.0
.bss 161512 161512 0 0.0
.data 2048 2048 0 0.0
.text 808472 808488 16 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127576 16 0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981332 981348 16 0.0
window-app BRD4161A (read/write) 1079428 1079444 16 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942800 942816 16 0.0
esp32 all-clusters-app c3devkit (read only) 1021768 1021784 16 0.0
(read/write) 1486130 1486130 0 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 216000 0 0.0
.flash.text 1021768 1021784 16 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075515 1075539 24 0.0
(read/write) 488160 488160 0 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070131 1070155 24 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660104 660120 16 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582772 582788 16 0.0
lock k32w061+release (read/write) 687084 687100 16 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609268 609284 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9771188 9773148 1960 0.0
(read/write) 679361 679361 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624760 624760 0 0.0
.dynamic 560 560 0 0.0
.got 13544 13544 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 456884 457196 312 0.1
.text 7730084 7731732 1648 0.0
thermostat-no-ble arm64 (read only) 2338060 2340036 1976 0.1
(read/write) 141233 141233 0 0.0
.bss 55265 55265 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75552 75552 0 0.0
.dynamic 560 560 0 0.0
.got 4976 4976 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 138964 139276 312 0.2
.text 1962448 1964112 1664 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448752 2448752 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411396 1411396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176051 16 0.0
bss 142908 142908 0 0.0
rodata 142204 142204 0 0.0
text 812024 812036 12 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156115 16 0.0
bss 142144 142144 0 0.0
rodata 133748 133748 0 0.0
text 801336 801348 12 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685700 1685716 16 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1526096 1526112 16 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629828 1629844 16 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470944 1470960 16 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549828 1549844 16 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399248 1399264 16 0.0
lock-app default (read only) 886680 886680 0 0.0
(read/write) 1587420 1587436 16 0.0
.bss 144208 144208 0 0.0
.data 2456 2456 0 0.0
.text 1432368 1432384 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798388 798412 24 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566528 566550 22 0.0
lighting-app tlsr9518adk80d (read/write) 818436 818460 24 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583072 583094 22 0.0

@andy31415 andy31415 merged commit 9293e3a into sve Jul 21, 2022
@andy31415 andy31415 deleted the cherry-pick-6d5480788b783c6cf80bdb019476971b5c5c8fb0 branch July 21, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woody-apple @andy31415 @bzbarsky-apple