Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include non-fabric-associated pending roots in the RootCertificates attribute. #21016

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Include non-fabric-associated pending roots in the RootCertificates attribute. #21016

merged 2 commits into from
Jul 20, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #20791

Also moves a function that was supposed to be private from public to private.

@bzbarsky-apple
Include non-fabric-associated pending roots in the RootCertificates a…
48b4908 
…ttribute.

Fixes project-chip#20791

Also moves a function that was supposed to be private from public to private.
@github-actions github-actions bot added the app label Jul 20, 2022
@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #21016: Size comparison from 4a56906 to dbc9858

Increases (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section 4a56906 dbc9858 change % change
bl602 lighting-app bl602 (read/write) 1379514 1379770 256 0.0
.text 1050152 1050408 256 0.0
bl602+rpc (read/write) 1424922 1425178 256 0.0
.text 1081808 1082064 256 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183128 183152 24 0.0
lock-ftd LP_CC2652R7 (read only) 671227 671315 88 0.0
.text 594304 594392 88 0.0
lock-mtd LP_CC2652R7 (read only) 653503 653607 104 0.0
.text 551832 551936 104 0.0
pump-app LP_CC2652R7 (read only) 680227 680323 96 0.0
.text 590932 591028 96 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666099 96 0.0
.text 580848 580944 96 0.0
shell LP_CC2652R7 (read/write) 186156 186180 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581642 96 0.0
.app_xip_area 460096 460192 96 0.0
lock cyw930739m2evb_01 (read/write) 587462 587558 96 0.0
.app_xip_area 461284 461380 96 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 585014 104 0.0
.app_xip_area 464308 464412 104 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1086016 80 0.0
.text 950808 950888 80 0.0
BRD4161A+rpc (read/write) 1140212 1140292 80 0.0
.text 988196 988276 80 0.0
BRD4161A+rs911x (read/write) 972052 972116 64 0.0
.text 808472 808536 64 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127656 96 0.0
.text 981332 981428 96 0.0
window-app BRD4161A (read/write) 1079428 1079508 80 0.0
.text 942800 942880 80 0.0
k32w light k32w061+release (read/write) 660328 660424 96 0.0
.text 582996 583092 96 0.0
lock k32w061+release (read/write) 687308 687404 96 0.0
.text 609492 609588 96 0.0
linux all-clusters-app debug (read only) 2977953 2978593 640 0.0
.text 2535202 2535842 640 0.0
all-clusters-minimal-app debug (read only) 2823905 2824545 640 0.0
.text 2382914 2383554 640 0.0
bridge-app debug+rpc (read only) 2324017 2324657 640 0.0
.text 1963810 1964450 640 0.0
lighting-app debug+rpc (read only) 2561761 2562401 640 0.0
.text 2177506 2178146 640 0.0
lock-app debug (read only) 2526657 2527281 624 0.0
.text 2132194 2132818 624 0.0
ota-provider-app debug (read only) 2330241 2330865 624 0.0
.text 1963378 1964002 624 0.0
ota-requestor-app debug (read only) 2448825 2449465 640 0.0
.text 2069810 2070450 640 0.0
shell debug (read only) 2564465 2565105 640 0.0
.text 2178994 2179634 640 0.0
thermostat-no-ble arm64 (read only) 2604004 2604484 480 0.0
.text 2197968 2198448 480 0.0
tv-app debug (read only) 3112297 3112921 624 0.0
.text 2674530 2675154 624 0.0
tv-casting-app debug (read only) 5365833 5366473 640 0.0
.text 4765874 4766514 640 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448688 2448816 128 0.0
.text 1411332 1411460 128 0.0
p6 light-app default (read/write) 1549828 1549892 64 0.0
.text 1399248 1399312 64 0.0
lock-app default (read/write) 1587420 1587500 80 0.0
.text 1432368 1432448 80 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798388 798452 64 0.0
text 566528 566588 60 0.0
lighting-app tlsr9518adk80d (read/write) 818436 818500 64 0.0
text 583072 583132 60 0.0
Decreases (13 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 4a56906 dbc9858 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668095 -24 -0.0
.text 579484 579460 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633695 -24 -0.0
.text 555844 555820 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 170196 170108 -88 -0.1
lock-mtd LP_CC2652R7 (read/write) 183608 183504 -104 -0.1
pump-app LP_CC2652R7 (read/write) 162052 161956 -96 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176396 176300 -96 -0.1
shell LP_CC2652R7 (read only) 660594 660570 -24 -0.0
.text 575188 575164 -24 -0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021670 -96 -0.0
.flash.text 1021766 1021670 -96 -0.0
m5stack (read only) 1075515 1075463 -52 -0.0
.flash.text 1070131 1070079 -52 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176003 -32 -0.0
text 812024 811988 -36 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156067 -32 -0.0
text 801336 801304 -32 -0.0
p6 all-clusters-app default (read/write) 1685700 1685572 -128 -0.0
.text 1526096 1525968 -128 -0.0
all-clusters-minimal-app default (read/write) 1629828 1629684 -144 -0.0
.text 1470944 1470800 -144 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4a56906 dbc9858 change % change
bl602 lighting-app bl602 (read/write) 1379514 1379770 256 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050152 1050408 256 0.0
bl602+rpc (read/write) 1424922 1425178 256 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1082064 256 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668095 -24 -0.0
(read/write) 183128 183152 24 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579484 579460 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633695 -24 -0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555844 555820 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 671227 671315 88 0.0
(read/write) 170196 170108 -88 -0.1
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594304 594392 88 0.0
lock-mtd LP_CC2652R7 (read only) 653503 653607 104 0.0
(read/write) 183608 183504 -104 -0.1
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551832 551936 104 0.0
pump-app LP_CC2652R7 (read only) 680227 680323 96 0.0
(read/write) 162052 161956 -96 -0.1
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590932 591028 96 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666099 96 0.0
(read/write) 176396 176300 -96 -0.1
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580848 580944 96 0.0
shell LP_CC2652R7 (read only) 660594 660570 -24 -0.0
(read/write) 186156 186180 24 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575188 575164 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581642 96 0.0
.app_xip_area 460096 460192 96 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587558 96 0.0
.app_xip_area 461284 461380 96 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 585014 104 0.0
.app_xip_area 464308 464412 104 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1086016 80 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950808 950888 80 0.0
BRD4161A+rpc (read/write) 1140212 1140292 80 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988196 988276 80 0.0
BRD4161A+rs911x (read/write) 972052 972116 64 0.0
.bss 161512 161512 0 0.0
.data 2048 2048 0 0.0
.text 808472 808536 64 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127656 96 0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981332 981428 96 0.0
window-app BRD4161A (read/write) 1079428 1079508 80 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942800 942880 80 0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021670 -96 -0.0
(read/write) 1486130 1486130 0 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 216000 0 0.0
.flash.text 1021766 1021670 -96 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075515 1075463 -52 -0.0
(read/write) 488160 488160 0 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070131 1070079 -52 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660328 660424 96 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 583092 96 0.0
lock k32w061+release (read/write) 687308 687404 96 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609588 96 0.0
linux all-clusters-app debug (read only) 2977953 2978593 640 0.0
(read/write) 155312 155312 0 0.0
.bss 61824 61824 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85160 85160 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 264779 264779 0 0.0
.text 2535202 2535842 640 0.0
all-clusters-minimal-app debug (read only) 2823905 2824545 640 0.0
(read/write) 146984 146984 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77720 77720 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 265675 265675 0 0.0
.text 2382914 2383554 640 0.0
bridge-app debug+rpc (read only) 2324017 2324657 640 0.0
(read/write) 125768 125768 0 0.0
.bss 49088 49088 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67096 67096 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 198184 198184 0 0.0
.text 1963810 1964450 640 0.0
chip-tool debug (read only) 10335705 10335705 0 0.0
(read/write) 630888 630888 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596472 596472 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 517045 517045 0 0.0
.text 8367444 8367444 0 0.0
chip-tool-ipv6only arm64 (read only) 10072828 10072828 0 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481100 481100 0 0.0
.text 8008404 8008404 0 0.0
lighting-app debug+rpc (read only) 2561761 2562401 640 0.0
(read/write) 129856 129856 0 0.0
.bss 49664 49664 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214000 214000 0 0.0
.text 2177506 2178146 640 0.0
lock-app debug (read only) 2526657 2527281 624 0.0
(read/write) 124808 124808 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69208 69208 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229008 229008 0 0.0
.text 2132194 2132818 624 0.0
ota-provider-app debug (read only) 2330241 2330865 624 0.0
(read/write) 118608 118608 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63192 63192 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 203800 203800 0 0.0
.text 1963378 1964002 624 0.0
ota-requestor-app debug (read only) 2448825 2449465 640 0.0
(read/write) 125544 125544 0 0.0
.bss 50048 50048 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67416 67416 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 207552 207552 0 0.0
.text 2069810 2070450 640 0.0
shell debug (read only) 2564465 2565105 640 0.0
(read/write) 141336 141336 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 228082 228082 0 0.0
.text 2178994 2179634 640 0.0
thermostat-no-ble arm64 (read only) 2604004 2604484 480 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83368 0 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165740 165740 0 0.0
.text 2197968 2198448 480 0.0
tv-app debug (read only) 3112297 3112921 624 0.0
(read/write) 256960 256960 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 249512 249512 0 0.0
.text 2674530 2675154 624 0.0
tv-casting-app debug (read only) 5365833 5366473 640 0.0
(read/write) 158264 158264 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98288 98288 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 333601 333601 0 0.0
.text 4765874 4766514 640 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448816 128 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411460 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176003 -32 -0.0
bss 142908 142908 0 0.0
rodata 142204 142204 0 0.0
text 812024 811988 -36 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156067 -32 -0.0
bss 142144 142144 0 0.0
rodata 133748 133748 0 0.0
text 801336 801304 -32 -0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685700 1685572 -128 -0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1526096 1525968 -128 -0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629828 1629684 -144 -0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470944 1470800 -144 -0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549828 1549892 64 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399248 1399312 64 0.0
lock-app default (read only) 886680 886680 0 0.0
(read/write) 1587420 1587500 80 0.0
.bss 144208 144208 0 0.0
.data 2456 2456 0 0.0
.text 1432368 1432448 80 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798388 798452 64 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566528 566588 60 0.0
lighting-app tlsr9518adk80d (read/write) 818436 818500 64 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583072 583132 60 0.0

@woody-apple woody-apple enabled auto-merge (squash) July 20, 2022 23:30
@woody-apple woody-apple merged commit 5132358 into project-chip:master Jul 20, 2022
@bzbarsky-apple bzbarsky-apple deleted the trusted-root-iteration branch July 21, 2022 01:27
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Include non-fabric-associated pending roots in the RootCertificates a…
7723c09 
…ttribute. (project-chip#21016)

* Include non-fabric-associated pending roots in the RootCertificates attribute.

Fixes project-chip#20791

Also moves a function that was supposed to be private from public to private.

* Add unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TC-CGEN-2.2]--AddTrustedRootCertificate command Fails to add TrustedRootCertificate
3 participants
@bzbarsky-apple @tcarmelveilleux @woody-apple