Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit localization cluster constraints #21003

Merged
merged 12 commits into from
Jul 21, 2022
Merged

Unit localization cluster constraints #21003

merged 12 commits into from
Jul 21, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Jul 20, 2022 •
edited
Loading

Problem

Unit localization cluster does not validate the temperature unit.
Fixes #20879

Change overview

  • set min/max values for the unit localization
  • add unit tests

Testing

CI should run tests. Also ran locally:

./scripts/tests/run_test_suite.py --target Test_TC_LUNIT_3_1 --chip-tool ./out/linux-x64-chip-tool/chip-tool run --all-clusters-app ./out/linux-x64-all-clusters/chip-all-clusters-app --tv-app none --lock-app none --ota-provider-app none --ota-requestor-app none

@pullapprove pullapprove bot requested a review from yufengwangca July 20, 2022 16:30
@woody-apple woody-apple enabled auto-merge (squash) July 20, 2022 16:30
@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #21003: Size comparison from 0ad4506 to 4fcc957

Increases (5 builds for linux, p6, telink)
platform target config section 0ad4506 4fcc9577 change % change
linux chip-tool-ipv6only arm64 (read only) 10072828 10077580 4752 0.0
.rodata 481100 481516 416 0.1
.text 8008404 8012740 4336 0.1
thermostat-no-ble arm64 (read only) 2604004 2604276 272 0.0
.data.rel.ro 83368 83376 8 0.0
.text 2197968 2198192 224 0.0
p6 all-clusters-app default (read/write) 1685564 1685596 32 0.0
.text 1525960 1525992 32 0.0
all-clusters-minimal-app default (read/write) 1629692 1629708 16 0.0
.text 1470808 1470824 16 0.0
telink lighting-app tlsr9518adk80d text 583074 583076 2 0.0
Decreases (1 build for telink)
platform target config section 0ad4506 4fcc9577 change % change
telink light-switch-app tlsr9518adk80d text 566532 566530 -2 -0.0
Full report (16 builds for bl602, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 0ad4506 4fcc9577 change % change
bl602 lighting-app bl602 (read/write) 1379514 1379514 0 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050152 1050152 0 0.0
bl602+rpc (read/write) 1424922 1424922 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1081808 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581546 0 0.0
.app_xip_area 460096 460096 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587462 0 0.0
.app_xip_area 461284 461284 0 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584910 0 0.0
.app_xip_area 464308 464308 0 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 660328 660328 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 582996 0 0.0
lock k32w061+release (read/write) 687308 687308 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609492 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10072828 10077580 4752 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481100 481516 416 0.1
.text 8008404 8012740 4336 0.1
thermostat-no-ble arm64 (read only) 2604004 2604276 272 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83376 8 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165740 165740 0 0.0
.text 2197968 2198192 224 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448688 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411332 0 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685564 1685596 32 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525960 1525992 32 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629692 1629708 16 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470808 1470824 16 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549692 1549692 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399112 1399112 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576684 1576684 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1426232 1426232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798396 798396 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566532 566530 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 818444 818444 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583074 583076 2 0.0

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #21003: Size comparison from 0ad4506 to b0b1ca2

Increases (9 builds for cc13x2_26x2, linux, nrfconnect, p6)
platform target config section 0ad4506 b0b1ca2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668135 16 0.0
.text 579484 579500 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633759 40 0.0
.rodata 77551 77559 8 0.0
.text 555844 555876 32 0.0
shell LP_CC2652R7 (read only) 660594 660634 40 0.0
.rodata 85090 85098 8 0.0
.text 575188 575220 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10072828 10077580 4752 0.0
.rodata 481100 481516 416 0.1
.text 8008404 8012740 4336 0.1
thermostat-no-ble arm64 (read only) 2604004 2604276 272 0.0
.data.rel.ro 83368 83376 8 0.0
.text 2197968 2198192 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176055 20 0.0
rodata 142204 142208 4 0.0
text 812024 812044 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156119 20 0.0
rodata 133748 133752 4 0.0
text 801336 801356 20 0.0
p6 all-clusters-app default (read/write) 1685564 1685596 32 0.0
.text 1525960 1525992 32 0.0
all-clusters-minimal-app default (read/write) 1629692 1629708 16 0.0
.text 1470808 1470824 16 0.0
Decreases (4 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 0ad4506 b0b1ca2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183128 183112 -16 -0.0
shell LP_CC2652R7 (read/write) 186156 186116 -40 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 587462 587454 -8 -0.0
.app_xip_area 461284 461276 -8 -0.0
telink light-switch-app tlsr9518adk80d text 566532 566530 -2 -0.0
Full report (25 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0ad4506 b0b1ca2 change % change
bl602 lighting-app bl602 (read/write) 1379514 1379514 0 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050152 1050152 0 0.0
bl602+rpc (read/write) 1424922 1424922 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1081808 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668135 16 0.0
(read/write) 183128 183112 -16 -0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579484 579500 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633759 40 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77559 8 0.0
.text 555844 555876 32 0.0
lock-ftd LP_CC2652R7 (read only) 671227 671227 0 0.0
(read/write) 170196 170196 0 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594304 594304 0 0.0
lock-mtd LP_CC2652R7 (read only) 653503 653503 0 0.0
(read/write) 183608 183608 0 0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551832 551832 0 0.0
pump-app LP_CC2652R7 (read only) 680227 680227 0 0.0
(read/write) 162052 162052 0 0.0
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590932 590932 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666003 0 0.0
(read/write) 176396 176396 0 0.0
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580848 580848 0 0.0
shell LP_CC2652R7 (read only) 660594 660634 40 0.0
(read/write) 186156 186116 -40 -0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85098 8 0.0
.text 575188 575220 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581546 0 0.0
.app_xip_area 460096 460096 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587454 -8 -0.0
.app_xip_area 461284 461276 -8 -0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584910 0 0.0
.app_xip_area 464308 464308 0 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 660328 660328 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 582996 0 0.0
lock k32w061+release (read/write) 687308 687308 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609492 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10072828 10077580 4752 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481100 481516 416 0.1
.text 8008404 8012740 4336 0.1
thermostat-no-ble arm64 (read only) 2604004 2604276 272 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83376 8 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165740 165740 0 0.0
.text 2197968 2198192 224 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448688 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176055 20 0.0
bss 142908 142908 0 0.0
rodata 142204 142208 4 0.0
text 812024 812044 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156119 20 0.0
bss 142144 142144 0 0.0
rodata 133748 133752 4 0.0
text 801336 801356 20 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685564 1685596 32 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525960 1525992 32 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629692 1629708 16 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470808 1470824 16 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549692 1549692 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399112 1399112 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576684 1576684 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1426232 1426232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798396 798396 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566532 566530 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 818444 818444 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583074 583074 0 0.0

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #21003: Size comparison from 0ad4506 to be78e1f

Increases above 0.2%:

platform target config section 0ad4506 be78e1f change % change
efr32 lighting-app BRD4161A+rs911x (read/write) 951316 972052 20736 2.2
.bss 140776 161512 20736 14.7
Increases (20 builds for cc13x2_26x2, efr32, esp32, linux, nrfconnect, p6)
platform target config section 0ad4506 be78e1f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668135 16 0.0
.text 579484 579500 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633759 40 0.0
.rodata 77551 77559 8 0.0
.text 555844 555876 32 0.0
shell LP_CC2652R7 (read only) 660594 660634 40 0.0
.rodata 85090 85098 8 0.0
.text 575188 575220 32 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 951316 972052 20736 2.2
.bss 140776 161512 20736 14.7
window-app BRD4161A (read/write) 1079428 1079452 24 0.0
.text 942800 942824 24 0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021792 26 0.0
.dram0.bss 70088 70096 8 0.0
.flash.text 1021766 1021792 26 0.0
m5stack (read only) 1075515 1075535 20 0.0
(read/write) 488160 488176 16 0.0
.flash.rodata 246412 246428 16 0.0
.flash.text 1070131 1070151 20 0.0
linux all-clusters-app debug (read only) 2977953 2978177 224 0.0
.text 2535202 2535378 176 0.0
all-clusters-minimal-app debug (read only) 2823905 2824129 224 0.0
.text 2382914 2383090 176 0.0
bridge-app debug+rpc (read only) 2324017 2324241 224 0.0
(read/write) 125768 125800 32 0.0
.data.rel.ro 67096 67112 16 0.0
.text 1963810 1963986 176 0.0
chip-tool debug (read only) 10335705 10341129 5424 0.1
.rodata 517045 517461 416 0.1
.text 8367444 8372452 5008 0.1
chip-tool-ipv6only arm64 (read only) 10072828 10077580 4752 0.0
.rodata 481100 481516 416 0.1
.text 8008404 8012740 4336 0.1
shell debug (read only) 2564465 2564673 208 0.0
.text 2178994 2179154 160 0.0
thermostat-no-ble arm64 (read only) 2604004 2604276 272 0.0
.data.rel.ro 83368 83376 8 0.0
.text 2197968 2198192 224 0.0
tv-app debug (read only) 3112297 3112505 208 0.0
.text 2674530 2674690 160 0.0
tv-casting-app debug (read only) 5365833 5366041 208 0.0
.text 4765874 4766034 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176055 20 0.0
rodata 142204 142208 4 0.0
text 812024 812044 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156119 20 0.0
rodata 133748 133752 4 0.0
text 801336 801356 20 0.0
p6 all-clusters-app default (read/write) 1685564 1685596 32 0.0
.text 1525960 1525992 32 0.0
all-clusters-minimal-app default (read/write) 1629692 1629708 16 0.0
.text 1470808 1470824 16 0.0
Decreases (6 builds for bl602, cc13x2_26x2, telink)
platform target config section 0ad4506 be78e1f change % change
bl602 lighting-app bl602 (read/write) 1379514 1379506 -8 -0.0
.text 1050152 1050148 -4 -0.0
bl602+rpc (read/write) 1424922 1424914 -8 -0.0
.text 1081808 1081804 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183128 183112 -16 -0.0
shell LP_CC2652R7 (read/write) 186156 186116 -40 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 798396 798388 -8 -0.0
text 566532 566528 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818444 818436 -8 -0.0
text 583074 583072 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0ad4506 be78e1f change % change
bl602 lighting-app bl602 (read/write) 1379514 1379506 -8 -0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050152 1050148 -4 -0.0
bl602+rpc (read/write) 1424922 1424914 -8 -0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1081804 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668135 16 0.0
(read/write) 183128 183112 -16 -0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579484 579500 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633759 40 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77559 8 0.0
.text 555844 555876 32 0.0
lock-ftd LP_CC2652R7 (read only) 671227 671227 0 0.0
(read/write) 170196 170196 0 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594304 594304 0 0.0
lock-mtd LP_CC2652R7 (read only) 653503 653503 0 0.0
(read/write) 183608 183608 0 0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551832 551832 0 0.0
pump-app LP_CC2652R7 (read only) 680227 680227 0 0.0
(read/write) 162052 162052 0 0.0
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590932 590932 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666003 0 0.0
(read/write) 176396 176396 0 0.0
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580848 580848 0 0.0
shell LP_CC2652R7 (read only) 660594 660634 40 0.0
(read/write) 186156 186116 -40 -0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85098 8 0.0
.text 575188 575220 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581546 0 0.0
.app_xip_area 460096 460096 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587462 0 0.0
.app_xip_area 461284 461284 0 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584910 0 0.0
.app_xip_area 464308 464308 0 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1085936 0 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950808 950808 0 0.0
BRD4161A+rpc (read/write) 1140212 1140212 0 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988196 988196 0 0.0
BRD4161A+rs911x (read/write) 951316 972052 20736 2.2
.bss 140776 161512 20736 14.7
.data 2048 2048 0 0.0
.text 808472 808472 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127560 1127560 0 0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981332 981332 0 0.0
window-app BRD4161A (read/write) 1079428 1079452 24 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942800 942824 24 0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021792 26 0.0
(read/write) 1486130 1486130 0 0.0
.dram0.bss 70088 70096 8 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 216000 0 0.0
.flash.text 1021766 1021792 26 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075515 1075535 20 0.0
(read/write) 488160 488176 16 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246428 16 0.0
.flash.text 1070131 1070151 20 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660328 660328 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 582996 0 0.0
lock k32w061+release (read/write) 687308 687308 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609492 0 0.0
linux all-clusters-app debug (read only) 2977953 2978177 224 0.0
(read/write) 155312 155312 0 0.0
.bss 61824 61824 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85160 85160 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 264779 264779 0 0.0
.text 2535202 2535378 176 0.0
all-clusters-minimal-app debug (read only) 2823905 2824129 224 0.0
(read/write) 146984 146984 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77720 77720 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 265675 265675 0 0.0
.text 2382914 2383090 176 0.0
bridge-app debug+rpc (read only) 2324017 2324241 224 0.0
(read/write) 125768 125800 32 0.0
.bss 49088 49088 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67096 67112 16 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 198184 198184 0 0.0
.text 1963810 1963986 176 0.0
chip-tool debug (read only) 10335705 10341129 5424 0.1
(read/write) 630888 630888 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596472 596472 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 517045 517461 416 0.1
.text 8367444 8372452 5008 0.1
chip-tool-ipv6only arm64 (read only) 10072828 10077580 4752 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481100 481516 416 0.1
.text 8008404 8012740 4336 0.1
lighting-app debug+rpc (read only) 2561761 2561761 0 0.0
(read/write) 129856 129856 0 0.0
.bss 49664 49664 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214000 214000 0 0.0
.text 2177506 2177506 0 0.0
lock-app debug (read only) 2526657 2526657 0 0.0
(read/write) 124808 124808 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69208 69208 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229008 229008 0 0.0
.text 2132194 2132194 0 0.0
ota-provider-app debug (read only) 2330241 2330241 0 0.0
(read/write) 118608 118608 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63192 63192 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 203800 203800 0 0.0
.text 1963378 1963378 0 0.0
ota-requestor-app debug (read only) 2448825 2448825 0 0.0
(read/write) 125544 125544 0 0.0
.bss 50048 50048 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67416 67416 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 207552 207552 0 0.0
.text 2069810 2069810 0 0.0
shell debug (read only) 2564465 2564673 208 0.0
(read/write) 141336 141336 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 228082 228082 0 0.0
.text 2178994 2179154 160 0.0
thermostat-no-ble arm64 (read only) 2604004 2604276 272 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83376 8 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165740 165740 0 0.0
.text 2197968 2198192 224 0.0
tv-app debug (read only) 3112297 3112505 208 0.0
(read/write) 256960 256960 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 249512 249512 0 0.0
.text 2674530 2674690 160 0.0
tv-casting-app debug (read only) 5365833 5366041 208 0.0
(read/write) 158264 158264 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98288 98288 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 333601 333601 0 0.0
.text 4765874 4766034 160 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448688 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176055 20 0.0
bss 142908 142908 0 0.0
rodata 142204 142208 4 0.0
text 812024 812044 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156119 20 0.0
bss 142144 142144 0 0.0
rodata 133748 133752 4 0.0
text 801336 801356 20 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685564 1685596 32 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525960 1525992 32 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629692 1629708 16 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470808 1470824 16 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549692 1549692 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399112 1399112 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576684 1576684 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1426232 1426232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798396 798388 -8 -0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566532 566528 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818444 818436 -8 -0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583074 583072 -2 -0.0

@github-actions github-actions bot removed the examples label Jul 21, 2022
@andy31415 andy31415 dismissed bzbarsky-apple’s stale review July 21, 2022 13:29

Changes applied and seem to work.

@andy31415 andy31415 requested a review from bzbarsky-apple July 21, 2022 13:29
@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21003: Size comparison from 6d54807 to e4d842d

Increases (9 builds for bl602, cc13x2_26x2, esp32, linux, nrfconnect, p6)
platform target config section 6d54807 e4d842d change % change
bl602 lighting-app bl602+rpc .text 1082688 1082692 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668343 16 0.0
.rodata 88311 88327 16 0.0
shell LP_CC2652R7 .rodata 85090 85098 8 0.0
esp32 all-clusters-app c3devkit (read/write) 1486298 1486306 8 0.0
.flash.rodata 216008 216016 8 0.0
m5stack (read/write) 488320 488328 8 0.0
.flash.rodata 246412 246420 8 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9778940 4832 0.0
.rodata 457340 457788 448 0.1
.text 7732372 7736756 4384 0.1
thermostat-no-ble arm64 (read only) 2341508 2341564 56 0.0
.rodata 139420 139444 24 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176395 12 0.0
rodata 142200 142212 12 0.0
p6 all-clusters-app default (read/write) 1686652 1686660 8 0.0
.text 1526536 1526544 8 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 6d54807 e4d842d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183016 183000 -16 -0.0
shell LP_CC2652R7 .text 575404 575396 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6d54807 e4d842d change % change
bl602 lighting-app bl602 (read/write) 1380914 1380914 0 0.0
.bss 117482 117482 0 0.0
.data 4480 4480 0 0.0
.text 1051032 1051032 0 0.0
bl602+rpc (read/write) 1426322 1426322 0 0.0
.bss 124930 124930 0 0.0
.data 4600 4600 0 0.0
.text 1082688 1082692 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668343 16 0.0
(read/write) 183016 183000 -16 -0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88327 16 0.0
.text 579700 579700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633943 633943 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 556068 556068 0 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671555 0 0.0
(read/write) 169964 169964 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594632 594632 0 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653839 0 0.0
(read/write) 183368 183368 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552176 552176 0 0.0
pump-app LP_CC2652R7 (read only) 680579 680579 0 0.0
(read/write) 161796 161796 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 591284 591284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666355 0 0.0
(read/write) 176140 176140 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84667 0 0.0
.text 581208 581208 0 0.0
shell LP_CC2652R7 (read only) 660810 660810 0 0.0
(read/write) 186036 186036 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85098 8 0.0
.text 575404 575396 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582050 0 0.0
.app_xip_area 460440 460440 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 587966 0 0.0
.app_xip_area 461628 461628 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585430 0 0.0
.app_xip_area 464668 464668 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086760 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951472 0 0.0
BRD4161A+rpc (read/write) 1141036 1141036 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 988860 0 0.0
BRD4161A+rs911x (read/write) 972876 972876 0 0.0
.bss 161672 161672 0 0.0
.data 2048 2048 0 0.0
.text 809136 809136 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128248 1128248 0 0.0
.bss 144312 144312 0 0.0
.data 2056 2056 0 0.0
.text 981860 981860 0 0.0
window-app BRD4161A (read/write) 1080236 1080236 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943448 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021960 1021960 0 0.0
(read/write) 1486298 1486306 8 0.0
.dram0.bss 70248 70248 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216016 8 0.0
.flash.text 1021960 1021960 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075743 1075743 0 0.0
(read/write) 488320 488328 8 0.0
.dram0.bss 75768 75768 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246420 8 0.0
.flash.text 1070359 1070359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660784 660784 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583324 583324 0 0.0
lock k32w061+release (read/write) 687788 687788 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609844 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9778940 4832 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457788 448 0.1
.text 7732372 7736756 4384 0.1
thermostat-no-ble arm64 (read only) 2341508 2341564 56 0.0
(read/write) 141297 141297 0 0.0
.bss 55265 55265 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139444 24 0.0
.text 1965280 1965280 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449032 0 0.0
.bss 214460 214460 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176395 12 0.0
bss 143068 143068 0 0.0
rodata 142200 142212 12 0.0
text 812248 812248 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156447 0 0.0
bss 142304 142304 0 0.0
rodata 133744 133744 0 0.0
text 801564 801564 0 0.0
p6 all-clusters-app default (read only) 881616 881616 0 0.0
(read/write) 1686652 1686660 8 0.0
.bss 149080 149080 0 0.0
.data 2648 2648 0 0.0
.text 1526536 1526544 8 0.0
all-clusters-minimal-app default (read only) 882336 882336 0 0.0
(read/write) 1630780 1630780 0 0.0
.bss 148360 148360 0 0.0
.data 2648 2648 0 0.0
.text 1471384 1471384 0 0.0
light-app default (read only) 890640 890640 0 0.0
(read/write) 1551004 1551004 0 0.0
.bss 140264 140264 0 0.0
.data 2440 2440 0 0.0
.text 1399912 1399912 0 0.0
lock-app default (read only) 886168 886168 0 0.0
(read/write) 1588596 1588596 0 0.0
.bss 144720 144720 0 0.0
.data 2456 2456 0 0.0
.text 1433032 1433032 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798860 798860 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566826 566826 0 0.0
lighting-app tlsr9518adk80d (read/write) 818908 818908 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583370 583370 0 0.0

@woody-apple woody-apple merged commit b263270 into project-chip:master Jul 21, 2022
github-actions bot pushed a commit that referenced this pull request Jul 21, 2022
@andy31415 @web-flow
Unit localization cluster constraints (#21003)
a80a628 
* Attempt to automate unit localization test case

* Restyle

* Update name of attribute to the correct value

* ZAP regen (tests)

* Add pre-attribute support and source file for unit localization

* zap regen

* Make the localization compile
woody-apple added a commit that referenced this pull request Jul 21, 2022
@woody-apple @andy31415
Unit localization cluster constraints (#21003) (#21080)
c66bc77 
* Attempt to automate unit localization test case

* Restyle

* Update name of attribute to the correct value

* ZAP regen (tests)

* Add pre-attribute support and source file for unit localization

* zap regen

* Make the localization compile

Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@andy31415 @isiu-apple
Unit localization cluster constraints (project-chip#21003)
f12ed21 
* Attempt to automate unit localization test case

* Restyle

* Update name of attribute to the correct value

* ZAP regen (tests)

* Add pre-attribute support and source file for unit localization

* zap regen

* Make the localization compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@turon turon turon approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
5 participants
@andy31415 @turon @mrjerryjohns @woody-apple @bzbarsky-apple