In DefaultOTARequestorDriver::GetMaxDownloadBlockSize(), return maxDownloadBlockSize instead of 1024 #20947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd {submodule path}
git reset --hard origin/master
cd -
git clean -n
git add {submodule path}
git commit
git submodule update --init --recursive
…adBlockSize instead of 1024.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
|
Two submodules under third_party are part of this PR. Please remove them. |
Yup, done. |
selissia
approved these changes
Jul 19, 2022
|
PR #20947: Size comparison from 4cdecc9 to b34af44 Increases (3 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
woody-apple
approved these changes
Jul 19, 2022
carol-apple
approved these changes
Jul 19, 2022
bzbarsky-apple
approved these changes
Jul 19, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
…wnloadBlockSize instead of 1024 (#20947) * Fix uncommitted path error. * Resolve uncommited path error. cd {submodule path} git reset --hard origin/master cd - git clean -n git add {submodule path} git commit git submodule update --init --recursive * In DefaultOTARequestorDriver::GetMaxDownloadBlock(), return maxDownloadBlockSize instead of 1024. * Revert "Fix uncommitted path error." This reverts commit abec715. * Revert "Resolve uncommited path error." This reverts commit b2f63c7.
woody-apple
added a commit
that referenced
this pull request
Jul 20, 2022
…wnloadBlockSize instead of 1024 (#20947) (#20971) * Fix uncommitted path error. * Resolve uncommited path error. cd {submodule path} git reset --hard origin/master cd - git clean -n git add {submodule path} git commit git submodule update --init --recursive * In DefaultOTARequestorDriver::GetMaxDownloadBlock(), return maxDownloadBlockSize instead of 1024. * Revert "Fix uncommitted path error." This reverts commit abec715. * Revert "Resolve uncommited path error." This reverts commit b2f63c7. Co-authored-by: Irene Siu (Apple) <[email protected]>
isiu-apple
added a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…wnloadBlockSize instead of 1024 (project-chip#20947) * Fix uncommitted path error. * Resolve uncommited path error. cd {submodule path} git reset --hard origin/master cd - git clean -n git add {submodule path} git commit git submodule update --init --recursive * In DefaultOTARequestorDriver::GetMaxDownloadBlock(), return maxDownloadBlockSize instead of 1024. * Revert "Fix uncommitted path error." This reverts commit abec715. * Revert "Resolve uncommited path error." This reverts commit b2f63c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DefaultOTARequestorDriver::GetMaxDownloadBlockSize()was hardcoded to always return1024.Fixes: #20898
Change overview
Update
DefaultOTARequestorDriver::GetMaxDownloadBlockSize()to returnmaxDownloadBlockSize.Testing
Verified OTA Query image successfully transfers an image.