-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add an option to continue running tests even after a test… #20928
Merged
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_TestFailureContinue
Jul 19, 2022
Merged
[chip-tool] Add an option to continue running tests even after a test… #20928
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_TestFailureContinue
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
July 19, 2022 11:04
pullapprove
bot
requested review from
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 19, 2022 11:04
Damian-Nordic
approved these changes
Jul 19, 2022
PR #20928: Size comparison from fcd6594 to aa5831c Increases (3 builds for esp32, linux)
Decreases (1 build for telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
force-pushed
the
YAML_TestFailureContinue
branch
from
July 19, 2022 14:35
aa5831c
to
81a5cf3
Compare
PR #20928: Size comparison from fcd6594 to 81a5cf3 Increases (5 builds for bl602, cc13x2_26x2, linux, telink)
Decreases (3 builds for cc13x2_26x2, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 19, 2022
woody-apple
added a commit
that referenced
this pull request
Jul 19, 2022
… failure (#20928) (#20945) Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… failure
Problem
It may be sometimes useful to continue running tests even after a test failure. This is in order to know which tests are failing from the test suite, instead of only seeing the first error.
Change overview
continueOnFailure
optional argument to the test runnerTesting
It was tested running the
Test_TC_OO_1
test suite:This one stops on the first error.
This one continues and accumulates errors if any.