Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align matter-devices xml file with spec for on-off light device type #20920

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Align matter-devices xml file with spec for on-off light device type #20920

merged 1 commit into from
Jul 20, 2022

Conversation

PSONALl
Copy link
Contributor

@PSONALl PSONALl commented Jul 19, 2022 •
edited
Loading

Problem

Change overview

  • Aligns xml files with spec for on-off light device types

Testing

  • no testing required

@boring-cyborg boring-cyborg bot added the app label Jul 19, 2022
@PSONALl PSONALl changed the title Align matter-devices xml file with spec Align matter-devices xml file with spec for on-off light device type Jul 19, 2022
@github-actions
Copy link

github-actions bot commented Jul 19, 2022 •
edited
Loading

PR #20920: Size comparison from ea78432 to 8fc1c7c

Increases (2 builds for esp32, nrfconnect)
platform target config section ea78432 8fc1c7c change % change
esp32 all-clusters-app c3devkit (read only) 1021762 1021764 2 0.0
.flash.text 1021762 1021764 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812632 812636 4 0.0
Decreases (5 builds for bl602, cc13x2_26x2, telink)
platform target config section ea78432 8fc1c7c change % change
bl602 lighting-app bl602 .text 1050420 1050416 -4 -0.0
bl602+rpc .text 1082076 1082072 -4 -0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 634223 634215 -8 -0.0
.text 556348 556340 -8 -0.0
telink light-switch-app tlsr9518adk80d text 566814 566810 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818740 818732 -8 -0.0
text 583346 583344 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ea78432 8fc1c7c change % change
bl602 lighting-app bl602 (read/write) 1379762 1379762 0 0.0
.bss 116962 116962 0 0.0
.data 4480 4480 0 0.0
.text 1050420 1050416 -4 -0.0
bl602+rpc (read/write) 1425170 1425170 0 0.0
.bss 124410 124410 0 0.0
.data 4600 4600 0 0.0
.text 1082076 1082072 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668599 668599 0 0.0
(read/write) 182640 182640 0 0.0
.bss 74132 74132 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579964 579964 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634223 634215 -8 -0.0
(read/write) 157700 157700 0 0.0
.bss 73428 73428 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 556348 556340 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 671811 671811 0 0.0
(read/write) 169604 169604 0 0.0
.bss 71196 71196 0 0.0
.data 3280 3280 0 0.0
.rodata 76451 76451 0 0.0
.text 594880 594880 0 0.0
lock-mtd LP_CC2652R7 (read only) 654095 654095 0 0.0
(read/write) 183008 183008 0 0.0
.bss 66884 66884 0 0.0
.data 3280 3280 0 0.0
.rodata 101199 101199 0 0.0
.text 552416 552416 0 0.0
pump-app LP_CC2652R7 (read only) 680795 680795 0 0.0
(read/write) 161468 161468 0 0.0
.bss 71276 71276 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 591500 591500 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666587 666587 0 0.0
(read/write) 175796 175796 0 0.0
.bss 71396 71396 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 581432 581432 0 0.0
shell LP_CC2652R7 (read only) 661098 661098 0 0.0
(read/write) 185644 185644 0 0.0
.bss 76436 76436 0 0.0
.data 3360 3360 0 0.0
.rodata 85098 85098 0 0.0
.text 575684 575684 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582142 582142 0 0.0
.app_xip_area 460704 460704 0 0.0
.bss 64232 64232 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588058 588058 0 0.0
.app_xip_area 461892 461892 0 0.0
.bss 68960 68960 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585474 585474 0 0.0
.app_xip_area 464884 464884 0 0.0
.bss 63440 63440 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1084792 1084792 0 0.0
.bss 133044 133044 0 0.0
.data 2048 2048 0 0.0
.text 949680 949680 0 0.0
BRD4161A+rpc (read/write) 1139084 1139084 0 0.0
.bss 149724 149724 0 0.0
.data 2260 2260 0 0.0
.text 987076 987076 0 0.0
BRD4161A+rs911x (read/write) 950160 950160 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 807324 807324 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128004 1128004 0 0.0
.bss 144136 144136 0 0.0
.data 2056 2056 0 0.0
.text 981792 981792 0 0.0
window-app BRD4161A (read/write) 1078284 1078284 0 0.0
.bss 134516 134516 0 0.0
.data 2076 2076 0 0.0
.text 941672 941672 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021762 1021764 2 0.0
(read/write) 1486026 1486026 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215912 215912 0 0.0
.flash.text 1021762 1021764 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075507 1075507 0 0.0
(read/write) 488064 488064 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246324 246324 0 0.0
.flash.text 1070123 1070123 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660924 660924 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 583592 583592 0 0.0
lock k32w061+release (read/write) 687908 687908 0 0.0
.bss 70004 70004 0 0.0
.data 2004 2004 0 0.0
.text 610100 610100 0 0.0
linux all-clusters-app debug (read only) 2973161 2973161 0 0.0
(read/write) 155016 155016 0 0.0
.bss 61664 61664 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 85048 85048 0 0.0
.dynamic 608 608 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 264733 264733 0 0.0
.text 2530834 2530834 0 0.0
all-clusters-minimal-app debug (read only) 2819721 2819721 0 0.0
(read/write) 146688 146688 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265661 265661 0 0.0
.text 2379122 2379122 0 0.0
bridge-app debug+rpc (read only) 2320009 2320009 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198240 198240 0 0.0
.text 1960130 1960130 0 0.0
chip-tool debug (read only) 10295393 10295393 0 0.0
(read/write) 629504 629504 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 595152 595152 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 515765 515765 0 0.0
.text 8331604 8331604 0 0.0
chip-tool-ipv6only arm64 (read only) 10036380 10036380 0 0.0
(read/write) 694577 694577 0 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 630768 630768 0 0.0
.dynamic 528 528 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 479820 479820 0 0.0
.text 7976596 7976596 0 0.0
lighting-app debug+rpc (read only) 2557785 2557785 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214088 214088 0 0.0
.text 2173826 2173826 0 0.0
lock-app debug (read only) 2522617 2522617 0 0.0
(read/write) 124512 124512 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 229064 229064 0 0.0
.text 2128482 2128482 0 0.0
ota-provider-app debug (read only) 2326209 2326209 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203832 203832 0 0.0
.text 1959698 1959698 0 0.0
ota-requestor-app debug (read only) 2443817 2443817 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207584 207584 0 0.0
.text 2065154 2065154 0 0.0
shell debug (read only) 2560065 2560065 0 0.0
(read/write) 141104 141104 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228114 228114 0 0.0
.text 2174946 2174946 0 0.0
thermostat-no-ble arm64 (read only) 2600676 2600676 0 0.0
(read/write) 158257 158257 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83216 83216 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165748 165748 0 0.0
.text 2195184 2195184 0 0.0
tv-app debug (read only) 3108121 3108121 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249504 249504 0 0.0
.text 2670818 2670818 0 0.0
tv-casting-app debug (read only) 5356241 5356241 0 0.0
(read/write) 157664 157664 0 0.0
.bss 51016 51016 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 97928 97928 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 332841 332841 0 0.0
.text 4758002 4758002 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449128 2449128 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1411772 1411772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176643 1176643 0 0.0
bss 142900 142900 0 0.0
rodata 142204 142204 0 0.0
text 812632 812636 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156675 1156675 0 0.0
bss 142136 142136 0 0.0
rodata 133748 133748 0 0.0
text 801920 801920 0 0.0
p6 all-clusters-app default (read only) 882136 882136 0 0.0
(read/write) 1685036 1685036 0 0.0
.bss 148560 148560 0 0.0
.data 2648 2648 0 0.0
.text 1525440 1525440 0 0.0
all-clusters-minimal-app default (read only) 882856 882856 0 0.0
(read/write) 1629180 1629180 0 0.0
.bss 147840 147840 0 0.0
.data 2648 2648 0 0.0
.text 1470304 1470304 0 0.0
light-app default (read only) 891160 891160 0 0.0
(read/write) 1549220 1549220 0 0.0
.bss 139744 139744 0 0.0
.data 2440 2440 0 0.0
.text 1398648 1398648 0 0.0
lock-app default (read only) 891288 891288 0 0.0
(read/write) 1576220 1576220 0 0.0
.bss 139600 139600 0 0.0
.data 2456 2456 0 0.0
.text 1425776 1425776 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798700 798700 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 566814 566810 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818740 818732 -8 -0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 583346 583344 -2 -0.0

@dhrishi
Copy link
Contributor

dhrishi commented Jul 19, 2022

@PSONALl Please check the CI failure for ZAP / ZAP templates generation

@dhrishi
Copy link
Contributor

dhrishi commented Jul 19, 2022

@bzbarsky-apple @tcarmelveilleux PTAL

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #20920: Size comparison from 889b3b6 to 0ba90fa

Increases (9 builds for bl602, cc13x2_26x2, efr32, esp32)
platform target config section 889b3b6 0ba90fa change % change
bl602 lighting-app bl602 (read/write) 1379506 1379514 8 0.0
.text 1050148 1050152 4 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 633711 633719 8 0.0
.text 555836 555844 8 0.0
lock-ftd LP_CC2652R7 (read/write) 170196 170204 8 0.0
efr32 lighting-app BRD4161A (read/write) 1085824 1085936 112 0.0
.text 950696 950808 112 0.0
BRD4161A+rpc (read/write) 1140100 1140212 112 0.0
.text 988084 988196 112 0.0
BRD4161A+rs911x (read/write) 951024 951136 112 0.0
.text 808180 808292 112 0.0
lock-app BRD4161A+wf200 (read/write) 1127392 1127500 108 0.0
.text 981164 981272 108 0.0
window-app BRD4161A (read/write) 1079316 1079428 112 0.0
.text 942688 942800 112 0.0
esp32 all-clusters-app c3devkit (read only) 1021572 1021574 2 0.0
.flash.text 1021572 1021574 2 0.0
Decreases (5 builds for cc13x2_26x2, cyw30739, nrfconnect)
platform target config section 889b3b6 0ba90fa change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 671227 671219 -8 -0.0
.text 594304 594296 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 587462 587454 -8 -0.0
.app_xip_area 461284 461276 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584902 -8 -0.0
.app_xip_area 464308 464300 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812024 812020 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 801340 801336 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 889b3b6 0ba90fa change % change
bl602 lighting-app bl602 (read/write) 1379506 1379514 8 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050148 1050152 4 0.0
bl602+rpc (read/write) 1424922 1424922 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1081808 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668119 0 0.0
(read/write) 183128 183128 0 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579484 579484 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633711 633719 8 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555836 555844 8 0.0
lock-ftd LP_CC2652R7 (read only) 671227 671219 -8 -0.0
(read/write) 170196 170204 8 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594304 594296 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 653503 653503 0 0.0
(read/write) 183608 183608 0 0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551832 551832 0 0.0
pump-app LP_CC2652R7 (read only) 680227 680227 0 0.0
(read/write) 162052 162052 0 0.0
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590932 590932 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666003 0 0.0
(read/write) 176396 176396 0 0.0
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580848 580848 0 0.0
shell LP_CC2652R7 (read only) 660594 660594 0 0.0
(read/write) 186156 186156 0 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575188 575188 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581546 0 0.0
.app_xip_area 460096 460096 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587454 -8 -0.0
.app_xip_area 461284 461276 -8 -0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584902 -8 -0.0
.app_xip_area 464308 464300 -8 -0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085824 1085936 112 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950696 950808 112 0.0
BRD4161A+rpc (read/write) 1140100 1140212 112 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988084 988196 112 0.0
BRD4161A+rs911x (read/write) 951024 951136 112 0.0
.bss 140776 140776 0 0.0
.data 2048 2048 0 0.0
.text 808180 808292 112 0.0
lock-app BRD4161A+wf200 (read/write) 1127392 1127500 108 0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981164 981272 108 0.0
window-app BRD4161A (read/write) 1079316 1079428 112 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942688 942800 112 0.0
esp32 all-clusters-app c3devkit (read only) 1021572 1021574 2 0.0
(read/write) 1486106 1486106 0 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215976 215976 0 0.0
.flash.text 1021572 1021574 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075395 1075395 0 0.0
(read/write) 488144 488144 0 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246396 246396 0 0.0
.flash.text 1070011 1070011 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660328 660328 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 582996 0 0.0
lock k32w061+release (read/write) 687308 687308 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609492 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10072556 10072556 0 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481084 481084 0 0.0
.text 8008148 8008148 0 0.0
thermostat-no-ble arm64 (read only) 2603684 2603684 0 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83368 0 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165724 165724 0 0.0
.text 2197664 2197664 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448544 2448544 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411188 1411188 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176035 0 0.0
bss 142908 142908 0 0.0
rodata 142204 142204 0 0.0
text 812024 812020 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156099 0 0.0
bss 142144 142144 0 0.0
rodata 133748 133748 0 0.0
text 801340 801336 -4 -0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685404 1685404 0 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525800 1525800 0 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629516 1629516 0 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470632 1470632 0 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549516 1549516 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1398936 1398936 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576516 1576516 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1426064 1426064 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798396 798396 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566530 566530 0 0.0
lighting-app tlsr9518adk80d (read/write) 818444 818444 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583074 583074 0 0.0

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

PR #20920: Size comparison from a9b4d58 to ecb71bd

Increases (1 build for esp32)
platform target config section a9b4d58 ecb71bd change % change
esp32 all-clusters-app c3devkit (read only) 1021766 1021770 4 0.0
.flash.text 1021766 1021770 4 0.0
Decreases (5 builds for bl602, nrfconnect, telink)
platform target config section a9b4d58 ecb71bd change % change
bl602 lighting-app bl602 (read/write) 1379514 1379506 -8 -0.0
.text 1050152 1050148 -4 -0.0
bl602+rpc (read/write) 1424922 1424914 -8 -0.0
.text 1081808 1081804 -4 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 801336 801332 -4 -0.0
telink light-switch-app tlsr9518adk80d text 566532 566530 -2 -0.0
lighting-app tlsr9518adk80d text 583076 583074 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a9b4d58 ecb71bd change % change
bl602 lighting-app bl602 (read/write) 1379514 1379506 -8 -0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050152 1050148 -4 -0.0
bl602+rpc (read/write) 1424922 1424914 -8 -0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081808 1081804 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668119 668119 0 0.0
(read/write) 183128 183128 0 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579484 579484 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633719 633719 0 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555844 555844 0 0.0
lock-ftd LP_CC2652R7 (read only) 671227 671227 0 0.0
(read/write) 170196 170196 0 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594304 594304 0 0.0
lock-mtd LP_CC2652R7 (read only) 653503 653503 0 0.0
(read/write) 183608 183608 0 0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551832 551832 0 0.0
pump-app LP_CC2652R7 (read only) 680227 680227 0 0.0
(read/write) 162052 162052 0 0.0
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590932 590932 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666003 666003 0 0.0
(read/write) 176396 176396 0 0.0
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580848 580848 0 0.0
shell LP_CC2652R7 (read only) 660594 660594 0 0.0
(read/write) 186156 186156 0 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575188 575188 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581546 581546 0 0.0
.app_xip_area 460096 460096 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587462 587462 0 0.0
.app_xip_area 461284 461284 0 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584910 584910 0 0.0
.app_xip_area 464308 464308 0 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085936 1085936 0 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950808 950808 0 0.0
BRD4161A+rpc (read/write) 1140212 1140212 0 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988196 988196 0 0.0
BRD4161A+rs911x (read/write) 951316 951316 0 0.0
.bss 140776 140776 0 0.0
.data 2048 2048 0 0.0
.text 808472 808472 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127648 1127648 0 0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981420 981420 0 0.0
window-app BRD4161A (read/write) 1079428 1079428 0 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942800 942800 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021766 1021770 4 0.0
(read/write) 1486130 1486130 0 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 216000 0 0.0
.flash.text 1021766 1021770 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075515 1075515 0 0.0
(read/write) 488160 488160 0 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070131 1070131 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660328 660328 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 582996 582996 0 0.0
lock k32w061+release (read/write) 687308 687308 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609492 609492 0 0.0
linux all-clusters-app debug (read only) 2977297 2977297 0 0.0
(read/write) 155312 155312 0 0.0
.bss 61824 61824 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85160 85160 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 264683 264683 0 0.0
.text 2534642 2534642 0 0.0
all-clusters-minimal-app debug (read only) 2823905 2823905 0 0.0
(read/write) 146984 146984 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77720 77720 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 265675 265675 0 0.0
.text 2382914 2382914 0 0.0
bridge-app debug+rpc (read only) 2324017 2324017 0 0.0
(read/write) 125768 125768 0 0.0
.bss 49088 49088 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67096 67096 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 198184 198184 0 0.0
.text 1963810 1963810 0 0.0
chip-tool debug (read only) 10335705 10335705 0 0.0
(read/write) 630888 630888 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596472 596472 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 517045 517045 0 0.0
.text 8367444 8367444 0 0.0
chip-tool-ipv6only arm64 (read only) 10072828 10072828 0 0.0
(read/write) 696097 696097 0 0.0
.bss 43073 43073 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 632128 632128 0 0.0
.dynamic 528 528 0 0.0
.got 13672 13672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481100 481100 0 0.0
.text 8008404 8008404 0 0.0
lighting-app debug+rpc (read only) 2561761 2561761 0 0.0
(read/write) 129856 129856 0 0.0
.bss 49664 49664 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214000 214000 0 0.0
.text 2177506 2177506 0 0.0
lock-app debug (read only) 2526657 2526657 0 0.0
(read/write) 124808 124808 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69208 69208 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229008 229008 0 0.0
.text 2132194 2132194 0 0.0
ota-provider-app debug (read only) 2330241 2330241 0 0.0
(read/write) 118608 118608 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63192 63192 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 203800 203800 0 0.0
.text 1963378 1963378 0 0.0
ota-requestor-app debug (read only) 2448825 2448825 0 0.0
(read/write) 125544 125544 0 0.0
.bss 50048 50048 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67416 67416 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 207552 207552 0 0.0
.text 2069810 2069810 0 0.0
shell debug (read only) 2564465 2564465 0 0.0
(read/write) 141336 141336 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 228082 228082 0 0.0
.text 2178994 2178994 0 0.0
thermostat-no-ble arm64 (read only) 2604004 2604004 0 0.0
(read/write) 158641 158641 0 0.0
.bss 65441 65441 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83368 0 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165740 165740 0 0.0
.text 2197968 2197968 0 0.0
tv-app debug (read only) 3112297 3112297 0 0.0
(read/write) 256960 256960 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 249512 249512 0 0.0
.text 2674530 2674530 0 0.0
tv-casting-app debug (read only) 5365833 5365833 0 0.0
(read/write) 158264 158264 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98288 98288 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 333601 333601 0 0.0
.text 4765874 4765874 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448688 2448688 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411332 1411332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176035 1176035 0 0.0
bss 142908 142908 0 0.0
rodata 142204 142204 0 0.0
text 812024 812024 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156099 1156099 0 0.0
bss 142144 142144 0 0.0
rodata 133748 133748 0 0.0
text 801336 801332 -4 -0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685564 1685564 0 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525960 1525960 0 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629692 1629692 0 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470808 1470808 0 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549692 1549692 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399112 1399112 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576684 1576684 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1426232 1426232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798396 798396 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566532 566530 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 818444 818444 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583076 583074 -2 -0.0

@PSONALl
Copy link
Contributor Author

PSONALl commented Jul 20, 2022

File loading time: 174ms
{
commandRef: 100,
fieldIdentifier: 1,
label: 'DayOfWeekForSequence',
name: 'DayOfWeekForSequence',
type: 'DayOfWeek',
code: undefined,
isArray: false,
presentIf: null,
isNullable: false,
isOptional: false,
introducedInRef: null,
removedInRef: null,
countArg: null,
caption: 'Command argument of type DayOfWeek',
isBitmap: true
}
⇝
⇝ /__w/connectedhomeip/connectedhomeip/src/app/zap-templates/common/ClustersHelper.js:463
throw new Error(item.type + ' not found.');
^
Error: DayOfWeek not found.
at enhancedItem (/__w/connectedhomeip/connectedhomeip/src/app/zap-templates/common/ClustersHelper.js:463:9)
at /__w/connectedhomeip/connectedhomeip/src/app/zap-templates/common/ClustersHelper.js:487:7
at Array.forEach ()
at /__w/connectedhomeip/connectedhomeip/src/app/zap-templates/common/ClustersHelper.js:486:23
at Array.forEach ()
at enhancedCommands (/__w/connectedhomeip/connectedhomeip/src/app/zap-templates/common/ClustersHelper.js:485:12)
at Object.Clusters.init (/__w/connectedhomeip/connectedhomeip/src/app/zap-templates/common/ClustersHelper.js:727:20)

building of zap failed with this error, but I haven't made any changes in this file @woody-apple @bzbarsky-apple any idea about this?

@bzbarsky-apple
Copy link
Contributor

building of zap failed with this error

It's a random failure, though I have only seen it with a different enum... @tecimovic @vivien-apple

@bzbarsky-apple bzbarsky-apple merged commit 893ac17 into project-chip:master Jul 20, 2022
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@PSONALl @web-flow
Align xml files with spec (#20920)
5227bd2
woody-apple added a commit that referenced this pull request Jul 20, 2022
@woody-apple @PSONALl
Align xml files with spec (#20920) (#21024)
43bdf46 
Co-authored-by: PSONALl <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@PSONALl @isiu-apple
Align xml files with spec (project-chip#20920)
c22de5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved sve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PSONALl @dhrishi @bzbarsky-apple @woody-apple