-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PeerId
-> ScopedNodeId
where applicable.
#20896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of places were still using PeerId when they shouldn't be.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple and
gjc13
July 18, 2022 23:17
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 18, 2022 23:17
mrjerryjohns
changed the title
Replace PeerId -> ScopedNodeId where applicable.
Replace Jul 18, 2022
PeerId
-> ScopedNodeId
where applicable.
PR #20896: Size comparison from 8800678 to a2b4b18 Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, linux)
Decreases (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
reviewed
Jul 19, 2022
PR #20896: Size comparison from 2987329 to cf6ea89 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20896: Size comparison from 2987329 to f713a51 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Jul 26, 2022
tehampson
approved these changes
Jul 26, 2022
msandstedt
approved these changes
Jul 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Replace PeerId -> ScopedNodeId where applicable. Lots of places were still using PeerId when they shouldn't be. * Review feedback and build fixes * Darwin build fix
woody-apple
added a commit
that referenced
this pull request
Jul 27, 2022
* Replace PeerId -> ScopedNodeId where applicable. Lots of places were still using PeerId when they shouldn't be. * Review feedback and build fixes * Darwin build fix Co-authored-by: Jerry Johns <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of places were still using
PeerId
when they should be usingScopedNodeId
, since the former is really only meant to be used with mDNS, and nothing else.