-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unified BUILD selection #20884
Merged
woody-apple
merged 1 commit into
project-chip:master
from
mspang:for-chip/cleanup-unified
Jul 19, 2022
Merged
Clean up unified BUILD selection #20884
woody-apple
merged 1 commit into
project-chip:master
from
mspang:for-chip/cleanup-unified
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver and
robszewczyk
July 18, 2022 18:52
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 18, 2022 18:52
Use a single conditional to select builds and maintain a running lists of targets to build, and targets to test.
mspang
force-pushed
the
for-chip/cleanup-unified
branch
from
July 18, 2022 18:56
9dbfff0
to
d60155a
Compare
PR #20884: Size comparison from 953abf5 to d60155a Increases (1 build for telink)
Decreases (3 builds for k32w, nrfconnect, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 19, 2022
Fast tracking build changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Every new variant in the unified build introduces two conditionals,
which is duplicative.
Change overview
Use a single conditional to select builds and maintain a running lists
of targets to build, and targets to test.
Testing
gn_build.sh