-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the CI test timeout back down to 120 seconds. #20870
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:lower-test-timeout-again
Jul 18, 2022
Merged
Drop the CI test timeout back down to 120 seconds. #20870
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:lower-test-timeout-again
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
July 18, 2022 16:18
pullapprove
bot
requested review from
woody-apple,
mrjerryjohns,
xylophone21,
msandstedt,
yufengwangca,
robszewczyk,
yunhanw-google,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple and
wbschiller
July 18, 2022 16:18
andy31415
approved these changes
Jul 18, 2022
PR #20870: Size comparison from e4cfa0a to 1663c61 Increases (2 builds for cyw30739, telink)
Decreases (2 builds for linux, telink)
Full report (16 builds for bl602, cyw30739, k32w, linux, mbed, p6, telink)
|
Multi-minute YAML tests should not be running per-push in CI.
bzbarsky-apple
force-pushed
the
lower-test-timeout-again
branch
from
July 18, 2022 16:52
1663c61
to
bd36a6e
Compare
PR #20870: Size comparison from 21490a2 to bd36a6e Increases (1 build for esp32)
Decreases (5 builds for bl602, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
Multi-minute YAML tests should not be running per-push in CI.
woody-apple
added a commit
that referenced
this pull request
Jul 18, 2022
Multi-minute YAML tests should not be running per-push in CI. Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-minute YAML tests should not be running per-push in CI.
Problem
People just silently changed the "do not add slow tests" timeout so they could add a slow test.
Change overview
Put the timeout back where it was, move the slow test to the "do not run in CI" bucket.
Testing
Should pass CI.