Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QPG] Initialize OTA Requestor 3 seconds after Thread attach #20860

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[QPG] Initialize OTA Requestor 3 seconds after Thread attach #20860

merged 1 commit into from
Jul 18, 2022

Conversation

tima-q
Copy link
Contributor

@tima-q tima-q commented Jul 18, 2022

Problem

OTA Requestor is not able to send it's NotifyApplied message if the Thread attachment has not been done

Change overview

Delaying OTA Requestor init untill Thread network is attached + IP connectivity is reached

Testing

  • TC-SU-2.6
  • chip-tool, ota-provider + QPG lighting app
  • Execute OTA flow
  • Check NotifyApplied is received by provider

@tima-q tima-q added platform qpg QPG6xxx platform labels Jul 18, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 18, 2022
Closed
@tima-q tima-q force-pushed the qpg/ota_requestor_init branch from 4be1a79 to 4655f1b Compare July 18, 2022 09:00
@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

PR #20860: Size comparison from aa9457e to 4655f1b

Increases (1 build for esp32)
platform target config section aa9457e 4655f1b change % change
esp32 all-clusters-app c3devkit (read only) 1021568 1021570 2 0.0
.flash.text 1021568 1021570 2 0.0
Decreases (1 build for nrfconnect)
platform target config section aa9457e 4655f1b change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156507 1156491 -16 -0.0
text 801780 801776 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section aa9457e 4655f1b change % change
bl602 lighting-app bl602 (read/write) 1383418 1383418 0 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1053500 1053500 0 0.0
bl602+rpc (read/write) 1428850 1428850 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1085184 1085184 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668199 668199 0 0.0
(read/write) 183040 183040 0 0.0
.bss 74132 74132 0 0.0
.data 3356 3356 0 0.0
.rodata 88271 88271 0 0.0
.text 579612 579612 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633831 633831 0 0.0
(read/write) 157700 157700 0 0.0
.bss 73428 73428 0 0.0
.data 3356 3356 0 0.0
.rodata 77511 77511 0 0.0
.text 555996 555996 0 0.0
lock-ftd LP_CC2652R7 (read only) 671403 671403 0 0.0
(read/write) 170012 170012 0 0.0
.bss 71196 71196 0 0.0
.data 3280 3280 0 0.0
.rodata 76411 76411 0 0.0
.text 594512 594512 0 0.0
lock-mtd LP_CC2652R7 (read only) 653663 653663 0 0.0
(read/write) 183440 183440 0 0.0
.bss 66884 66884 0 0.0
.data 3280 3280 0 0.0
.rodata 101151 101151 0 0.0
.text 552032 552032 0 0.0
pump-app LP_CC2652R7 (read only) 680379 680379 0 0.0
(read/write) 161884 161884 0 0.0
.bss 71276 71276 0 0.0
.data 3280 3280 0 0.0
.rodata 88771 88771 0 0.0
.text 591124 591124 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666179 666179 0 0.0
(read/write) 176204 176204 0 0.0
.bss 71396 71396 0 0.0
.data 3276 3276 0 0.0
.rodata 84627 84627 0 0.0
.text 581072 581072 0 0.0
shell LP_CC2652R7 (read only) 660682 660682 0 0.0
(read/write) 186060 186060 0 0.0
.bss 76436 76436 0 0.0
.data 3360 3360 0 0.0
.rodata 85058 85058 0 0.0
.text 575308 575308 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581774 581774 0 0.0
.app_xip_area 460480 460480 0 0.0
.bss 64232 64232 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587690 587690 0 0.0
.app_xip_area 461668 461668 0 0.0
.bss 68960 68960 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585050 585050 0 0.0
.app_xip_area 464604 464604 0 0.0
.bss 63440 63440 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1084640 1084640 0 0.0
.bss 133044 133044 0 0.0
.data 2048 2048 0 0.0
.text 949528 949528 0 0.0
BRD4161A+rpc (read/write) 1138972 1138972 0 0.0
.bss 149724 149724 0 0.0
.data 2260 2260 0 0.0
.text 986964 986964 0 0.0
BRD4161A+rs911x (read/write) 950008 950008 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 807172 807172 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127788 1127788 0 0.0
.bss 144136 144136 0 0.0
.data 2056 2056 0 0.0
.text 981576 981576 0 0.0
window-app BRD4161A (read/write) 1078132 1078132 0 0.0
.bss 134516 134516 0 0.0
.data 2076 2076 0 0.0
.text 941520 941520 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021568 1021570 2 0.0
(read/write) 1485978 1485978 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215864 215864 0 0.0
.flash.text 1021568 1021570 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075299 1075299 0 0.0
(read/write) 488024 488024 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246284 246284 0 0.0
.flash.text 1069915 1069915 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660524 660524 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 583192 583192 0 0.0
lock k32w061+release (read/write) 687460 687460 0 0.0
.bss 70004 70004 0 0.0
.data 2004 2004 0 0.0
.text 609652 609652 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10020668 10020668 0 0.0
(read/write) 693617 693617 0 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 629816 629816 0 0.0
.dynamic 528 528 0 0.0
.got 13616 13616 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 478236 478236 0 0.0
.text 7964724 7964724 0 0.0
thermostat-no-ble arm64 (read only) 2599428 2599428 0 0.0
(read/write) 158257 158257 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83216 83216 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165700 165700 0 0.0
.text 2193984 2193984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448952 2448952 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1411596 1411596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176443 1176443 0 0.0
bss 142900 142900 0 0.0
rodata 142164 142164 0 0.0
text 812472 812472 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156507 1156491 -16 -0.0
bss 142136 142136 0 0.0
rodata 133708 133708 0 0.0
text 801780 801776 -4 -0.0
p6 all-clusters-app default (read/write) 2568432 2568432 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1526696 1526696 0 0.0
all-clusters-minimal-app default (read/write) 2513312 2513312 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1471576 1471576 0 0.0
light-app default (read/write) 2443296 2443296 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1401560 1401560 0 0.0
lock-app default (read/write) 2470384 2470384 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1428648 1428648 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798456 798456 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 566614 566614 0 0.0
lighting-app tlsr9518adk80d (read/write) 818496 818496 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 583146 583146 0 0.0

@andy31415 andy31415 merged commit 21490a2 into project-chip:master Jul 18, 2022
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
@tima-q @lucicop @web-flow
Initialize OTA Requestor 3 seconds after Thread attach (#20860)
d0bb7a6 
Restyled by clang-format

Co-authored-by: lucicop <[email protected]>
andy31415 pushed a commit that referenced this pull request Jul 18, 2022
@woody-apple @tima-q @lucicop
Initialize OTA Requestor 3 seconds after Thread attach (#20860) (#20871)
e9aaac0 
Restyled by clang-format

Co-authored-by: lucicop <[email protected]>

Co-authored-by: Timothy Maes <[email protected]>
Co-authored-by: lucicop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track platform qpg QPG6xxx platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tima-q @andy31415 @lucicop