-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ISO8601 delimiters for displaying the manufacturing date. #20857
Merged
woody-apple
merged 1 commit into
project-chip:master
from
markus-becker-tridonic-com:manufacturing-display-iso
Jul 19, 2022
Merged
Use ISO8601 delimiters for displaying the manufacturing date. #20857
woody-apple
merged 1 commit into
project-chip:master
from
markus-becker-tridonic-com:manufacturing-display-iso
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang,
rgoliver and
saurabhst
July 18, 2022 08:18
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 18, 2022 08:18
PR #20857: Size comparison from aa9457e to 1d2254c Increases (2 builds for k32w, telink)
Decreases (1 build for nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Jul 18, 2022
msandstedt
approved these changes
Jul 18, 2022
woody-apple
approved these changes
Jul 19, 2022
woody-apple
force-pushed
the
manufacturing-display-iso
branch
from
July 19, 2022 02:30
1d2254c
to
9f68acb
Compare
PR #20857: Size comparison from 143adf6 to 9f68acb Increases (3 builds for cc13x2_26x2, cyw30739, nrfconnect)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
added a commit
that referenced
this pull request
Jul 19, 2022
#20916) Co-authored-by: Markus Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spec uses ISO8601 for dates.
The / delimiter is not a regular delimiter for ISO8601.
Change overview
Change / for - in displaying the manufacturing date.
Testing
Not tested, 2 char change.