Fabric-scoping support in IDL parsing #20819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scoped, moved to earley parser instead of lalr. Potentially somewhat slower, but likely still fast enough
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
tcarmelveilleux
approved these changes
Jul 15, 2022
|
PR #20819: Size comparison from c50bacc to 0c33bb6 Increases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 16, 2022
|
PR #20819: Size comparison from e4cfa0a to 0c4e17b Increases (2 builds for cyw30739, esp32)
Decreases (2 builds for bl602, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Add fabric scope support in IDL for commands * Add support for fabric scoped attributes. Due to ambiguity of fabric_scoped, moved to earley parser instead of lalr. Potentially somewhat slower, but likely still fast enough * Switch back to lalr parser because it is much faster * Doc updates and one more test * Fix command id in examples * Use common keyword of fabric after updating grammar a bit * Fix extra rule * Restyle
woody-apple
added a commit
that referenced
this pull request
Jul 18, 2022
* Add fabric scope support in IDL for commands * Add support for fabric scoped attributes. Due to ambiguity of fabric_scoped, moved to earley parser instead of lalr. Potentially somewhat slower, but likely still fast enough * Switch back to lalr parser because it is much faster * Doc updates and one more test * Fix command id in examples * Use common keyword of fabric after updating grammar a bit * Fix extra rule * Restyle Co-authored-by: Andrei Litvin <[email protected]>
| @@ -94,6 +94,10 @@ server cluster AccessControl = 31 { | |||
| // These defaults can be modified to any of view/operate/manage/administer roles. | |||
| attribute access(read: manage, write: administer) int32u customAcl = 3; | |||
|
|
|||
| // Attributes may be fabric-scoped as well by tagging them as `fabric`. | |||
| fabric readonly attribute int16u myFabricAttr = 22; | |||
There was a problem hiding this comment.
This is wrong. Attributes cannot be fabric-scoped at all...
There was a problem hiding this comment.
Is there some spec description of this? Access description seems to lump them all together and I did find some (but very few) attributes which seemed to have F in the access column in my copy of the spec:
There was a problem hiding this comment.
Offline conversation results:
- fabric scoped on attributes is only for "lists of structures"
- the structures themselves will be tagged as "fabric scoped" as this pulls in a fabric index attribute into them
So followup changes should be:
- remove fabric scoped from attributes
- tag structs as fabric scoped (assuming zap knows about this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need fabric scope support
Change overview
fabric attributefabric commandkept lalr parsing because it is fast, so this means:
fabric readonly attributeis ok, butreadonly fabric attributeis not.fabric timed commandis ok, buttimed fabric commandis notBasically
fabricmust come first.Testing
Unit tests