Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ScanNetworks step to CHIPDeviceController #20766

Merged
merged 30 commits into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
36bb9b3
DRAFT: add ScanNetworks step to CHIPDeviceController
chrisdecenzo Jul 14, 2022
0aec701
Add android hooks and callbacks for network scan
chrisdecenzo Jul 15, 2022
2ec5b41
Add controller parameters for failsafe timeout, and scans
chrisdecenzo Jul 15, 2022
f01e003
Add callback for ReadCommissioningInfo
chrisdecenzo Jul 15, 2022
9e9a142
straggler file
chrisdecenzo Jul 15, 2022
bd09776
address comments
chrisdecenzo Jul 15, 2022
1b263df
fix android build
chrisdecenzo Jul 15, 2022
0a982eb
DRAFT: add ScanNetworks step to CHIPDeviceController
chrisdecenzo Jul 14, 2022
bfcb784
Add android hooks and callbacks for network scan
chrisdecenzo Jul 15, 2022
cfd3351
Add controller parameters for failsafe timeout, and scans
chrisdecenzo Jul 15, 2022
4bcd7c4
Add callback for ReadCommissioningInfo
chrisdecenzo Jul 15, 2022
756ac8f
straggler file
chrisdecenzo Jul 15, 2022
ac0327f
address comments
chrisdecenzo Jul 15, 2022
b7b58b3
fix android build
chrisdecenzo Jul 15, 2022
4a4b93b
Restyle DRAFT: add ScanNetworks step to CHIPDeviceController (#20808)
restyled-io[bot] Jul 16, 2022
d61ae0d
fix CI
chrisdecenzo Jul 18, 2022
406e727
merge with latest, fix conflicts
chrisdecenzo Jul 18, 2022
2452d0f
fix kotlin build issue
chrisdecenzo Jul 18, 2022
946d0f0
fix java method signature lookup
chrisdecenzo Jul 18, 2022
f06a4f2
fix cirq tests, add name for ScanNetworks step
chrisdecenzo Jul 19, 2022
f1b5c64
attempt to fix cirq tests
chrisdecenzo Jul 20, 2022
3ae3de4
Address comments
chrisdecenzo Jul 26, 2022
8776a7e
Address comments
chrisdecenzo Jul 26, 2022
2282310
sync to master
chrisdecenzo Jul 26, 2022
f158c8e
fix stragglers, restyle
chrisdecenzo Jul 26, 2022
2a5e0a3
address feedback
chrisdecenzo Jul 28, 2022
90cf820
address feedback
chrisdecenzo Jul 28, 2022
16a7ecc
fix build
chrisdecenzo Jul 28, 2022
390b792
fix build
chrisdecenzo Jul 28, 2022
5083311
fix build
chrisdecenzo Jul 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/controller/CHIPDeviceController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1573,6 +1573,7 @@ void DeviceCommissioner::ResumeCommissioning()
mDeviceBeingCommissioned = nullptr;
CommissioningDelegate::CommissioningReport report;
bzbarsky-apple marked this conversation as resolved.
Show resolved Hide resolved

mCommissioningPaused = false;
if (mCommissioningDelegate == nullptr)
bzbarsky-apple marked this conversation as resolved.
Show resolved Hide resolved
{
return;
Expand Down Expand Up @@ -1766,7 +1767,8 @@ void DeviceCommissioner::OnDone(app::ReadClient *)
{
if (features.Has(app::Clusters::NetworkCommissioning::NetworkCommissioningFeature::kWiFiNetworkInterface))
{
ChipLogError(Controller, "----- NetworkCommissioning Features: has WiFi.");
ChipLogError(Controller, "----- NetworkCommissioning Features: has WiFi. endpointid = %d",
path.mEndpointId);
info.network.wifi.endpoint = path.mEndpointId;
}
else if (features.Has(
Expand Down
4 changes: 2 additions & 2 deletions src/controller/CommissioningDelegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ enum CommissioningStage : uint8_t
kGenerateNOCChain,
kSendTrustedRootCert,
kSendNOC,
// ScanNetworks can happen anytime after kArmFailsafe
kScanNetworks,
kWiFiNetworkSetup,
kThreadNetworkSetup,
kWiFiNetworkEnable,
kThreadNetworkEnable,
kFindOperational,
kSendComplete,
kCleanup,
// ScanNetworks can happen anytime after kArmFailsafe. Adding to the end to try to fix circ tests
chrisdecenzo marked this conversation as resolved.
Show resolved Hide resolved
kScanNetworks,
};

const char * StageToString(CommissioningStage stage);
Expand Down