Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32]Added retry logic for rs911x and enabling IPv6 by default for EFR32 wifi #20747

Merged
merged 1 commit into from
Jul 15, 2022
Merged

[EFR32]Added retry logic for rs911x and enabling IPv6 by default for EFR32 wifi #20747

merged 1 commit into from
Jul 15, 2022

Conversation

chirag-silabs
Copy link
Contributor

Problem

EFR32 + RS911x was giving Joining issues to AP while doing commissioning without any delay

Enabling IPv6 by default

Change overview

Added a retry case whenever the Join to AP is failing on RS911x

Enabling IPv6 only mode by default. Changed the build option to "--chip_enable_wifi_ipv4" which can be used while building to enable IPv4

Testing

Tested on EFR32+RS911x. Shouldn't affect other platforms

@github-actions
Copy link

github-actions bot commented Jul 14, 2022 •
edited
Loading

PR #20747: Size comparison from ccd41c6 to 686f7a4

Increases (4 builds for cc13x2_26x2, efr32, esp32, k32w)
platform target config section ccd41c6 686f7a4 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 669315 669323 8 0.0
.text 592528 592536 8 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 948696 948816 120 0.0
.text 805860 805980 120 0.0
esp32 all-clusters-app c3devkit (read only) 1020256 1020260 4 0.0
.flash.text 1020256 1020260 4 0.0
k32w lock k32w061+release (read/write) 685808 685824 16 0.0
.text 608024 608040 16 0.0
Decreases (5 builds for bl602, cc13x2_26x2, efr32, telink)
platform target config section ccd41c6 686f7a4 change % change
bl602 lighting-app bl602+rpc .text 1090696 1090692 -4 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 172052 172044 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1129232 1126988 -2244 -0.2
.bss 144184 144136 -48 -0.0
.data 2060 2056 -4 -0.2
.text 982968 980776 -2192 -0.2
telink light-switch-app tlsr9518adk80d text 565792 565790 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 817428 817420 -8 -0.0
text 582116 582112 -4 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ccd41c6 686f7a4 change % change
bl602 lighting-app bl602 (read/write) 1398034 1398034 0 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1059008 1059008 0 0.0
bl602+rpc (read/write) 1443466 1443466 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1090696 1090692 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666415 666415 0 0.0
(read/write) 184808 184808 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88167 88167 0 0.0
.text 577932 577932 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632215 632215 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77407 77407 0 0.0
.text 554484 554484 0 0.0
lock-ftd LP_CC2652R7 (read only) 669315 669323 8 0.0
(read/write) 172052 172044 -8 -0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76307 76307 0 0.0
.text 592528 592536 8 0.0
lock-mtd LP_CC2652R7 (read only) 618731 618731 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76187 76187 0 0.0
.text 542056 542056 0 0.0
pump-app LP_CC2652R7 (read only) 678563 678563 0 0.0
(read/write) 163652 163652 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88731 88731 0 0.0
.text 589348 589348 0 0.0
pump-controller-app LP_CC2652R7 (read only) 664379 664379 0 0.0
(read/write) 177956 177956 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84595 84595 0 0.0
.text 579304 579304 0 0.0
shell LP_CC2652R7 (read only) 658906 658906 0 0.0
(read/write) 187820 187820 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84946 84946 0 0.0
.text 573644 573644 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579702 579702 0 0.0
.app_xip_area 458456 458456 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585654 585654 0 0.0
.app_xip_area 459680 459680 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583154 583154 0 0.0
.app_xip_area 462756 462756 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1082220 1082220 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 947156 947156 0 0.0
BRD4161A+rpc (read/write) 1136532 1136532 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 984576 984576 0 0.0
BRD4161A+rs911x (read/write) 948696 948816 120 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 805860 805980 120 0.0
lock-app BRD4161A+wf200 (read/write) 1129232 1126988 -2244 -0.2
.bss 144184 144136 -48 -0.0
.data 2060 2056 -4 -0.2
.text 982968 980776 -2192 -0.2
window-app BRD4161A (read/write) 1076036 1076036 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 939468 939468 0 0.0
esp32 all-clusters-app c3devkit (read only) 1020256 1020260 4 0.0
(read/write) 1485874 1485874 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215760 215760 0 0.0
.flash.text 1020256 1020260 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1074191 1074191 0 0.0
(read/write) 487928 487928 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246188 246188 0 0.0
.flash.text 1068807 1068807 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658944 658944 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581636 581636 0 0.0
lock k32w061+release (read/write) 685808 685824 16 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 608024 608040 16 0.0
linux all-clusters-app debug (read only) 2961321 2961321 0 0.0
(read/write) 154752 154752 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 263805 263805 0 0.0
.text 2520306 2520306 0 0.0
all-clusters-minimal-app debug (read only) 2813897 2813897 0 0.0
(read/write) 146688 146688 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265533 265533 0 0.0
.text 2373330 2373330 0 0.0
bridge-app debug+rpc (read only) 2315945 2315945 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198208 198208 0 0.0
.text 1956002 1956002 0 0.0
chip-tool debug (read only) 10369889 10369889 0 0.0
(read/write) 622720 622720 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 588352 588352 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519061 519061 0 0.0
.text 8418180 8418180 0 0.0
chip-tool-ipv6only arm64 (read only) 10088444 10088444 0 0.0
(read/write) 687921 687921 0 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 623984 623984 0 0.0
.dynamic 528 528 0 0.0
.got 13744 13744 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481788 481788 0 0.0
.text 8041796 8041796 0 0.0
lighting-app debug+rpc (read only) 2551673 2551673 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213896 213896 0 0.0
.text 2167810 2167810 0 0.0
lock-app debug (read only) 2516409 2516409 0 0.0
(read/write) 124512 124512 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 228936 228936 0 0.0
.text 2122306 2122306 0 0.0
ota-provider-app debug (read only) 2322785 2322785 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203704 203704 0 0.0
.text 1956306 1956306 0 0.0
ota-requestor-app debug (read only) 2439857 2439857 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207488 207488 0 0.0
.text 2061218 2061218 0 0.0
shell debug (read only) 2551649 2551649 0 0.0
(read/write) 141104 141104 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227954 227954 0 0.0
.text 2166594 2166594 0 0.0
thermostat-no-ble arm64 (read only) 2595780 2595780 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165668 165668 0 0.0
.text 2190336 2190336 0 0.0
tv-app debug (read only) 3102753 3102753 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2665634 2665634 0 0.0
tv-casting-app debug (read only) 5566969 5566969 0 0.0
(read/write) 161456 161456 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102536 102536 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343241 343241 0 0.0
.text 4947074 4947074 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448400 2448400 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1411044 1411044 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175459 1175459 0 0.0
bss 142900 142900 0 0.0
rodata 142060 142060 0 0.0
text 811596 811596 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155655 1155655 0 0.0
bss 142136 142136 0 0.0
rodata 133608 133608 0 0.0
text 801040 801040 0 0.0
p6 all-clusters-app default (read/write) 2566920 2566920 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1525184 1525184 0 0.0
all-clusters-minimal-app default (read/write) 2512216 2512216 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1470480 1470480 0 0.0
light-app default (read/write) 2442160 2442160 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1400424 1400424 0 0.0
lock-app default (read/write) 2469304 2469304 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1427568 1427568 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797596 797596 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565792 565790 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 817428 817420 -8 -0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 582116 582112 -4 -0.0

@tcarmelveilleux tcarmelveilleux merged commit ae987b0 into project-chip:master Jul 15, 2022
github-actions bot pushed a commit that referenced this pull request Jul 15, 2022
@chirag-silabs @web-flow
Added retry Join for RS911x and enabling only IPv6 by default (#20747)
2d42f44
andy31415 pushed a commit that referenced this pull request Jul 15, 2022
@woody-apple @chirag-silabs
Added retry Join for RS911x and enabling only IPv6 by default (#20747) (
0de54c3 
#20799)

Co-authored-by: chirag-silabs <[email protected]>
@rosahay-silabs rosahay-silabs deleted the bugfix/rs911x-ipv6-retry branch July 26, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@selissia selissia Awaiting requested review from selissia

Assignees
No one assigned
Labels
efr32 examples platform review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chirag-silabs @selissia @bzbarsky-apple @jmartinez-silabs @tcarmelveilleux