-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Interactive mode does not work great with complex/custom … #20743
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-4bb1abda27883642d3d8e610f530b014008c61e3
Jul 14, 2022
Merged
[chip-tool] Interactive mode does not work great with complex/custom … #20743
woody-apple
merged 1 commit into
sve
from
cherry-pick-4bb1abda27883642d3d8e610f530b014008c61e3
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments using json formatting (#20615)
PR #20743: Size comparison from 89d2a6a to de8c58f Increases (4 builds for bl602, cc13x2_26x2, cyw30739, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-4bb1abda27883642d3d8e610f530b014008c61e3
branch
July 14, 2022 21:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arguments using json formatting
Problem
In #19238 "double" quotes supports has been added to the interactive mode in order to pass string that may contains spaces instead of them being splitter into 2 arguments.
In this PR I would like to replace double quotes by double quote does not works great when one is trying to copy-paste complex json arguments to the command line such as:
$ chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233,1111], "targets":null},{"fabricIndex": 1, "privilege": 3, "authMode": 3, "subjects": [3333], "targets":null}]' 0x12344321 0
One would need to escape all the
"
characters to make it works properly, while using single quotes means such strings can be copy pasted without escaping and if one wants to pass an SSID that contains space, it should be 'My SSID' in stead of "My SSSID" which is a much easier and readable change.Change overview
Testing
I tried to convert use the previous write all command into interactive mode.