-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up path usage in build files #20735
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-415ee2f82e4bd49f008e7ab0e02823984a016105
Jul 14, 2022
Merged
Clean up path usage in build files #20735
woody-apple
merged 1 commit into
sve
from
cherry-pick-415ee2f82e4bd49f008e7ab0e02823984a016105
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templates should rebase paths to the build dir before passing them to scripts as scripts generally do not understand GN's // syntax for specifying paths relative to the root. In other cases, paths should be left alone so that build file relative paths can be specified. This is needed for consistency; all GN builtins accept both relative-to-BUILD.gn paths (default) and relative-to-build-root (//) paths.
PR #20735: Size comparison from 89d2a6a to 7ca69a6 Increases (3 builds for bl602, telink)
Decreases (1 build for cyw30739)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-415ee2f82e4bd49f008e7ab0e02823984a016105
branch
July 14, 2022 21:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Templates should rebase paths to the build dir before passing them to
scripts as scripts generally do not understand GN's // syntax for
specifying paths relative to the root.
In other cases, paths should be left alone so that build file relative
paths can be specified. This is needed for consistency; all GN builtins
accept both relative-to-BUILD.gn paths (default) and
relative-to-GN-root (//) paths.
For command line arguments, paths should be specified relative to
the build directory, which will be the working directory of the script.
Change overview
Allow & use relative paths in template arguments
Remove most uses of rebase_path() to create filesystem-absolute paths.
This is rarely needed and can introduce long absolute paths that are different for each developer.
These are replaced with:
BUILD.gn relative paths
GN-rooted (//) paths
get_path_info(path, "abspath")
converts a BUILD.gn relative path to a GN-rooted pathget_label_info(label, "label_no_toolchain")
converts a BUILD.gn relative label to a GN-rooted labelTesting
CI