[chip-tool] Properly shutdown all opened commissioners

[vivien-apple]

Problem

Not all commissioners are closed properly when during chip-tool shutdown.
Fix #20608

It happens because the arguments are cleaned right before the call to MaybeTearDownStack and so the optional argument mCommissionerName does not have a value anymore, which ends up defaulting to alpha

Change overview

• Properly shutdown all the registered commissioners

[github-actions]

PR #20727: Size comparison from a7c94d0 to 9b5e142

Increases (2 builds for bl602, cc13x2_26x2)

platform	target	config	section	a7c94d0	9b5e142	change	% change
bl602	lighting-app	bl602	(read/write)	1397738	1397746	8	0.0
			.text	1058712	1058716	4	0.0
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	669275	669283	8	0.0
			.text	592488	592496	8	0.0

Decreases (6 builds for bl602, cc13x2_26x2, esp32, linux, telink)

platform	target	config	section	a7c94d0	9b5e142	change	% change
bl602	lighting-app	bl602+rpc	.text	1090400	1090396	-4	-0.0
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read/write)	172092	172084	-8	-0.0
esp32	all-clusters-app	c3devkit	(read only)	1020214	1020212	-2	-0.0
			.flash.text	1020214	1020212	-2	-0.0
linux	chip-tool	debug	(read only)	10361505	10361217	-288	-0.0
			.text	8411684	8411396	-288	-0.0
	chip-tool-ipv6only	arm64	(read only)	10079548	10079420	-128	-0.0
			.text	8034676	8034548	-128	-0.0
telink	lighting-app	tlsr9518adk80d	text	582070	582068	-2	-0.0

Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	a7c94d0	9b5e142	change	% change
bl602	lighting-app	bl602	(read/write)	1397738	1397746	8	0.0
			.bss	116978	116978	0	0.0
			.data	4480	4480	0	0.0
			.text	1058712	1058716	4	0.0
		bl602+rpc	(read/write)	1443170	1443170	0	0.0
			.bss	124418	124418	0	0.0
			.data	4600	4600	0	0.0
			.text	1090400	1090396	-4	-0.0
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	666367	666367	0	0.0
			(read/write)	184856	184856	0	0.0
			.bss	74116	74116	0	0.0
			.data	3356	3356	0	0.0
			.rodata	88167	88167	0	0.0
			.text	577884	577884	0	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	632167	632167	0	0.0
			(read/write)	157684	157684	0	0.0
			.bss	73412	73412	0	0.0
			.data	3356	3356	0	0.0
			.rodata	77407	77407	0	0.0
			.text	554436	554436	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	669275	669283	8	0.0
			(read/write)	172092	172084	-8	-0.0
			.bss	71148	71148	0	0.0
			.data	3280	3280	0	0.0
			.rodata	76307	76307	0	0.0
			.text	592488	592496	8	0.0
	lock-mtd	LP_CC2652R7	(read only)	618683	618683	0	0.0
			(read/write)	144264	144264	0	0.0
			.bss	66868	66868	0	0.0
			.data	3280	3280	0	0.0
			.rodata	76187	76187	0	0.0
			.text	542008	542008	0	0.0
	pump-app	LP_CC2652R7	(read only)	678515	678515	0	0.0
			(read/write)	163700	163700	0	0.0
			.bss	71228	71228	0	0.0
			.data	3280	3280	0	0.0
			.rodata	88731	88731	0	0.0
			.text	589300	589300	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	664339	664339	0	0.0
			(read/write)	177996	177996	0	0.0
			.bss	71348	71348	0	0.0
			.data	3276	3276	0	0.0
			.rodata	84595	84595	0	0.0
			.text	579264	579264	0	0.0
	shell	LP_CC2652R7	(read only)	658858	658858	0	0.0
			(read/write)	187868	187868	0	0.0
			.bss	76420	76420	0	0.0
			.data	3360	3360	0	0.0
			.rodata	84946	84946	0	0.0
			.text	573596	573596	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	579662	579662	0	0.0
			.app_xip_area	458416	458416	0	0.0
			.bss	64184	64184	0	0.0
			.data	716	716	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	585614	585614	0	0.0
			.app_xip_area	459640	459640	0	0.0
			.bss	68912	68912	0	0.0
			.data	720	720	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	583114	583114	0	0.0
			.app_xip_area	462716	462716	0	0.0
			.bss	63392	63392	0	0.0
			.data	660	660	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read/write)	1081772	1081772	0	0.0
			.bss	132996	132996	0	0.0
			.data	2048	2048	0	0.0
			.text	946708	946708	0	0.0
		BRD4161A+rpc	(read/write)	1136084	1136084	0	0.0
			.bss	149676	149676	0	0.0
			.data	2260	2260	0	0.0
			.text	984128	984128	0	0.0
		BRD4161A+rs911x	(read/write)	948248	948248	0	0.0
			.bss	140768	140768	0	0.0
			.data	2048	2048	0	0.0
			.text	805412	805412	0	0.0
	lock-app	BRD4161A+wf200	(read/write)	1129184	1129184	0	0.0
			.bss	144184	144184	0	0.0
			.data	2060	2060	0	0.0
			.text	982920	982920	0	0.0
	window-app	BRD4161A	(read/write)	1075588	1075588	0	0.0
			.bss	134468	134468	0	0.0
			.data	2076	2076	0	0.0
			.text	939020	939020	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	1020214	1020212	-2	-0.0
			(read/write)	1485874	1485874	0	0.0
			.dram0.bss	70080	70080	0	0.0
			.dram0.data	14600	14600	0	0.0
			.flash.rodata	215760	215760	0	0.0
			.flash.text	1020214	1020212	-2	-0.0
			.iram0.text	62902	62902	0	0.0
		m5stack	(read only)	1074119	1074119	0	0.0
			(read/write)	487928	487928	0	0.0
			.dram0.bss	75600	75600	0	0.0
			.dram0.data	34144	34144	0	0.0
			.flash.rodata	246188	246188	0	0.0
			.flash.text	1068735	1068735	0	0.0
			.iram0.text	123267	123267	0	0.0
k32w	light	k32w061+release	(read/write)	658896	658896	0	0.0
			.bss	69516	69516	0	0.0
			.data	1992	1992	0	0.0
			.text	581588	581588	0	0.0
	lock	k32w061+release	(read/write)	685776	685776	0	0.0
			.bss	69980	69980	0	0.0
			.data	2004	2004	0	0.0
			.text	607992	607992	0	0.0
linux	all-clusters-app	debug	(read only)	2961193	2961193	0	0.0
			(read/write)	154752	154752	0	0.0
			.bss	61536	61536	0	0.0
			.data	2048	2048	0	0.0
			.data.rel.ro	84968	84968	0	0.0
			.dynamic	608	608	0	0.0
			.got	4536	4536	0	0.0
			.init	27	27	0	0.0
			.init_array	1048	1048	0	0.0
			.rodata	263805	263805	0	0.0
			.text	2520178	2520178	0	0.0
	all-clusters-minimal-app	debug	(read only)	2813785	2813785	0	0.0
			(read/write)	146688	146688	0	0.0
			.bss	60864	60864	0	0.0
			.data	2048	2048	0	0.0
			.data.rel.ro	77608	77608	0	0.0
			.dynamic	608	608	0	0.0
			.got	4488	4488	0	0.0
			.init	27	27	0	0.0
			.init_array	1048	1048	0	0.0
			.rodata	265533	265533	0	0.0
			.text	2373218	2373218	0	0.0
	bridge-app	debug+rpc	(read only)	2315833	2315833	0	0.0
			(read/write)	125504	125504	0	0.0
			.bss	48928	48928	0	0.0
			.data	3824	3824	0	0.0
			.data.rel.ro	66984	66984	0	0.0
			.dynamic	608	608	0	0.0
			.got	4392	4392	0	0.0
			.init	27	27	0	0.0
			.init_array	728	728	0	0.0
			.rodata	198208	198208	0	0.0
			.text	1955890	1955890	0	0.0
	chip-tool	debug	(read only)	10361505	10361217	-288	-0.0
			(read/write)	622720	622720	0	0.0
			.bss	24728	24728	0	0.0
			.data	3234	3234	0	0.0
			.data.rel.ro	588352	588352	0	0.0
			.dynamic	608	608	0	0.0
			.got	5096	5096	0	0.0
			.init	27	27	0	0.0
			.init_array	640	640	0	0.0
			.rodata	517173	517173	0	0.0
			.text	8411684	8411396	-288	-0.0
	chip-tool-ipv6only	arm64	(read only)	10079548	10079420	-128	-0.0
			(read/write)	687921	687921	0	0.0
			.bss	42961	42961	0	0.0
			.data	3304	3304	0	0.0
			.data.rel.ro	623984	623984	0	0.0
			.dynamic	528	528	0	0.0
			.got	13744	13744	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	480012	480012	0	0.0
			.text	8034676	8034548	-128	-0.0
	lighting-app	debug+rpc	(read only)	2551561	2551561	0	0.0
			(read/write)	129528	129528	0	0.0
			.bss	49440	49440	0	0.0
			.data	2096	2096	0	0.0
			.data.rel.ro	72136	72136	0	0.0
			.dynamic	608	608	0	0.0
			.got	4392	4392	0	0.0
			.init	27	27	0	0.0
			.init_array	816	816	0	0.0
			.rodata	213896	213896	0	0.0
			.text	2167698	2167698	0	0.0
	lock-app	debug	(read only)	2516297	2516297	0	0.0
			(read/write)	124512	124512	0	0.0
			.bss	47840	47840	0	0.0
			.data	1712	1712	0	0.0
			.data.rel.ro	69096	69096	0	0.0
			.dynamic	608	608	0	0.0
			.got	4424	4424	0	0.0
			.init	27	27	0	0.0
			.init_array	792	792	0	0.0
			.rodata	228936	228936	0	0.0
			.text	2122194	2122194	0	0.0
	ota-provider-app	debug	(read only)	2322673	2322673	0	0.0
			(read/write)	118312	118312	0	0.0
			.bss	47488	47488	0	0.0
			.data	1944	1944	0	0.0
			.data.rel.ro	63096	63096	0	0.0
			.dynamic	608	608	0	0.0
			.got	4488	4488	0	0.0
			.init	27	27	0	0.0
			.init_array	672	672	0	0.0
			.rodata	203704	203704	0	0.0
			.text	1956194	1956194	0	0.0
	ota-requestor-app	debug	(read only)	2439745	2439745	0	0.0
			(read/write)	125216	125216	0	0.0
			.bss	49856	49856	0	0.0
			.data	2232	2232	0	0.0
			.data.rel.ro	67288	67288	0	0.0
			.dynamic	608	608	0	0.0
			.got	4480	4480	0	0.0
			.init	27	27	0	0.0
			.init_array	728	728	0	0.0
			.rodata	207488	207488	0	0.0
			.text	2061106	2061106	0	0.0
	shell	debug	(read only)	2551537	2551537	0	0.0
			(read/write)	141104	141104	0	0.0
			.bss	57448	57448	0	0.0
			.data	1264	1264	0	0.0
			.data.rel.ro	76688	76688	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	928	928	0	0.0
			.rodata	227954	227954	0	0.0
			.text	2166482	2166482	0	0.0
	thermostat-no-ble	arm64	(read only)	2595700	2595700	0	0.0
			(read/write)	158289	158289	0	0.0
			.bss	65249	65249	0	0.0
			.data	1704	1704	0	0.0
			.data.rel.ro	83240	83240	0	0.0
			.dynamic	528	528	0	0.0
			.got	5072	5072	0	0.0
			.init	24	24	0	0.0
			.init_array	400	400	0	0.0
			.rodata	165668	165668	0	0.0
			.text	2190256	2190256	0	0.0
	tv-app	debug	(read only)	3102593	3102593	0	0.0
			(read/write)	257704	257704	0	0.0
			.bss	167016	167016	0	0.0
			.data	4848	4848	0	0.0
			.data.rel.ro	79392	79392	0	0.0
			.dynamic	608	608	0	0.0
			.got	4848	4848	0	0.0
			.init	27	27	0	0.0
			.init_array	952	952	0	0.0
			.rodata	249216	249216	0	0.0
			.text	2665474	2665474	0	0.0
	tv-casting-app	debug	(read only)	5566841	5566841	0	0.0
			(read/write)	161456	161456	0	0.0
			.bss	50248	50248	0	0.0
			.data	2416	2416	0	0.0
			.data.rel.ro	102536	102536	0	0.0
			.dynamic	608	608	0	0.0
			.got	4744	4744	0	0.0
			.init	27	27	0	0.0
			.init_array	864	864	0	0.0
			.rodata	343241	343241	0	0.0
			.text	4946946	4946946	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2448312	2448312	0	0.0
			.bss	213940	213940	0	0.0
			.data	5872	5872	0	0.0
			.text	1410956	1410956	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1175411	1175411	0	0.0
			bss	142900	142900	0	0.0
			rodata	142060	142060	0	0.0
			text	811552	811552	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1155623	1155623	0	0.0
			bss	142136	142136	0	0.0
			rodata	133608	133608	0	0.0
			text	800996	800996	0	0.0
p6	all-clusters-app	default	(read/write)	2566472	2566472	0	0.0
			.bss	149120	149120	0	0.0
			.data	2776	2776	0	0.0
			.text	1524736	1524736	0	0.0
	all-clusters-minimal-app	default	(read/write)	2511768	2511768	0	0.0
			.bss	148400	148400	0	0.0
			.data	2776	2776	0	0.0
			.text	1470032	1470032	0	0.0
	light-app	default	(read/write)	2441712	2441712	0	0.0
			.bss	140456	140456	0	0.0
			.data	2592	2592	0	0.0
			.text	1399976	1399976	0	0.0
	lock-app	default	(read/write)	2468856	2468856	0	0.0
			.bss	140304	140304	0	0.0
			.data	2600	2600	0	0.0
			.text	1427120	1427120	0	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	797556	797556	0	0.0
			bss	70576	70576	0	0.0
			noinit	40416	40416	0	0.0
			text	565748	565748	0	0.0
	lighting-app	tlsr9518adk80d	(read/write)	817380	817380	0	0.0
			bss	71420	71420	0	0.0
			noinit	40416	40416	0	0.0
			text	582070	582068	-2	-0.0